D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb added a comment. The highlight effect provided by `PlasmaCore.IconItem` is only visible when used with dark or colourful icons: F6746966: Mute5.gif F6746965: Mute4.gif I also tried reducing the opa

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb updated this revision to Diff 55003. faridb added a comment. - Revert "[Task Manager] Make mute/unmute behaviour configurable" In D19822#439724 , @hein wrote: > Back to work: For this patch to proceed further, please remove the setting

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb added a comment. In D19822#439195 , @rooty wrote: > I like this change I'd just prefer it if you could post screenshots in the test plan section? I added a screen recording to the test plan. In D19822#439396

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb updated this revision to Diff 54823. faridb marked 4 inline comments as done. faridb added a comment. - [Task Manager] Enable ability to mute tasks by default - [Task Manager] Change wording in config ui REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb updated this revision to Diff 54735. faridb added a comment. - [Task Manager] Make mute/unmute behaviour configurable I added the possibility to enable/disable this behaviour in the plasmoid configuration. I added it to the 'Appearance' section even though it's a behaviour. Co

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb added a comment. In D19822#437680 , @ngraham wrote: > Also, it would be nice if you also work on making the volume indicators smaller and always in the corner. This is what it looks like with a small icon in the corner: F6718166:

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb updated this revision to Diff 54731. faridb added a comment. - [Task Manager] Remove unnecessary braces REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=54077&id=54731 BRANCH taskmanager-mute (branched from master) REVISION DETAIL

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb added a comment. Yes, you could accidentally mute an application when using Icons-Only Task Manager. As you can see below, the audio indicator is pretty close to the centre of the task button, which is where you would usually click to activate that task: F6698588: Screenshot_201903

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. faridb requested review of this revision. REVISION SUMMARY The task manager shows an indicator on tasks playing audio (when enabled in the settings). This patch adds the ability to mute/unmu