Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-31 Thread Hanspeter Niederstrasser
, it should be built as MODULE in CMakeLists.txt. The physical install location remains the same and plugins don't have install_names. This corrects the install_name/install location mismatch. The change should not have any effect on non-OS X systems. Thanks, Hanspeter Niederstr

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
marked as submitted. Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, Plasma, and Harald Sitter. Changes --- Submitted with commit 383aa77ebf0b08adca13ce67a90f61c9c6a65851 by David Edmundson on behalf of Hanspeter Niederstrasser to branch master. Bugs: 342962

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
> On Aug. 23, 2015, 1:36 p.m., Hanspeter Niederstrasser wrote: > > Ship It! Oops. My pressing "Ship it" doesn't actually commit. Someone with write access will have to push upstream. Thanks. - Hanspeter ---

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84233 --- Ship it! Ship It! - Hanspeter Niederstrasser On Aug. 23

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
. The physical install location remains the same and plugins don't have install_names. This corrects the install_name/install location mismatch. The change should not have any effect on non-OS X systems. Thanks, Hanspeter Niederstrasser ___ P

Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
s the install_name/install location mismatch. The change should not have any effect on non-OS X systems. Thanks, Hanspeter Niederstrasser ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel