D11205: Fix ActionButton size

2018-03-14 Thread Igor Cota
icota closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11205 To: icota, #kirigami, mart Cc: ngraham, plasma-devel, #kirigami, apol, davidedmundson, mart, hein

D11205: Fix ActionButton size

2018-03-10 Thread Igor Cota
icota created this revision. icota added a reviewer: Kirigami. icota added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. icota requested review of this revision. REVISION SUMMARY Its dimensions were cut in half by the change in largeSpacing introduced in 944f8e8f

D10481: Add FormLayout.qml to kirigami.qrc

2018-02-16 Thread Igor Cota
icota added a commit: R169:bed2722949b6: Add FormLayout.qml to kirigami.qrc. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10481 To: icota, #kirigami, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D10392: Don't trigger SwipeListItem's actions unless they are exposed

2018-02-16 Thread Igor Cota
icota closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10392 To: icota, #kirigami, mart Cc: ngraham, mart, apol, plasma-devel, davidedmundson, hein

D10482: Add an isNull() check before setting wheter QIcon is a mask

2018-02-16 Thread Igor Cota
icota closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10482 To: icota, #kirigami, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D10392: Don't trigger SwipeListItem's actions unless they are exposed

2018-02-15 Thread Igor Cota
icota updated this revision to Diff 27292. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10392?vs=27290&id=27292 REVISION DETAIL https://phabricator.kde.org/D10392 AFFECTED FILES src/controls/templates/SwipeListItem.qml To: icota, #kirigami Cc: ngraham

D10392: Don't trigger SwipeListItem's actions unless they are exposed

2018-02-15 Thread Igor Cota
icota added a comment. @mart Only as a favour to you for the more elegant solution. Thanks! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10392 To: icota, #kirigami Cc: ngraham, mart, apol, plasma-devel, davidedmundson, hein

D10392: Don't trigger SwipeListItem's actions unless they are exposed

2018-02-15 Thread Igor Cota
icota updated this revision to Diff 27290. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10392?vs=26783&id=27290 REVISION DETAIL https://phabricator.kde.org/D10392 AFFECTED FILES src/controls/templates/SwipeListItem.qml To: icota, #kirigami Cc: ngraham

D10482: Add an isNull() check before setting wheter QIcon is a mask

2018-02-13 Thread Igor Cota
icota created this revision. icota added a reviewer: Kirigami. icota added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. icota requested review of this revision. REVISION SUMMARY To avoid stepping on a null QIcon. This can happen when calling ::fromTheme with a i

D10481: Add FormLayout.qml to kirigami.qrc

2018-02-13 Thread Igor Cota
icota created this revision. icota added a reviewer: Kirigami. icota added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. icota requested review of this revision. REVISION SUMMARY Can't use form layout in an app that includes(kirigami.pri) otherwise REPOSITORY R

D10392: Don't trigger SwipeListItem's actions unless they are exposed

2018-02-09 Thread Igor Cota
icota added a comment. @mart It's quite reproducible. Start kirigami gallery (I did it on Android) -- go into 'list view' -- bunch of SwipeListItems there -- tap somewhere to the left of the 'swipe icon' (the one you're supposed to drag left) --- you will trigger either action 1 or 2 as evid

D10392: Don't trigger SwipeListItem's actions unless they are exposed

2018-02-08 Thread Igor Cota
icota created this revision. icota added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. icota requested review of this revision. REVISION SUMMARY I seem to be able to click through a SwipeListItem's delegate and tr

D10247: Add a width ratio to the OverlaySheet

2018-02-02 Thread Igor Cota
icota abandoned this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10247 To: icota, #kirigami Cc: mart, plasma-devel, apol, davidedmundson, hein

D10247: Add a width ratio to the OverlaySheet

2018-02-02 Thread Igor Cota
icota added a reviewer: Kirigami. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10247 To: icota, #kirigami Cc: plasma-devel, apol, davidedmundson, mart, hein

D10247: Add a width ratio to the OverlaySheet

2018-02-02 Thread Igor Cota
icota created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. icota requested review of this revision. REVISION SUMMARY Instead of hardcoding the OverlaySheet to half the mainItem width multiply by the ratio to enable wid