D8277: Background color for sidebar headers

progwolff added a comment. They are important in the primary column to structure the list items. Yet, the list items are more important than the headings, so it is a good idea to have the headings in lower contrast, so that they create less visual attention. The heading in the second

D8277: Background color for sidebar headers

progwolff added a comment. I think it is intended that the headings have low contrast. The user knows that "Schriftarten" is selected, as it is highlighted in the primary column. In the second column it is rather unimportant to have it there at all. So, giving it a solid black would

D8277: Background color for sidebar headers

progwolff updated this revision to Diff 20684. progwolff added a comment. rebase REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8277?vs=20679=20684 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8277 AFFECTED FILES

D8278: rebase

progwolff abandoned this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8278 To: progwolff Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8278: rebase

progwolff created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D8278 AFFECTED FILES

D8277: Background color for sidebar headers

progwolff planned changes to this revision. progwolff added a comment. Need to rebase, sorry... REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8277 To: progwolff, #plasma_workspaces, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8277: Background color for sidebar headers

progwolff added a comment. Before: F5428336: systemsettings_old.png After: F5428338: systemsettings_new.png REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8277 To:

D8277: Background color for sidebar headers

progwolff created this revision. progwolff added reviewers: Plasma: Workspaces, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY kcm modules have backgroundColor as main background color. The new systemsettings

D7256: emit previously shown notifications after resume from idle

progwolff planned changes to this revision. progwolff added a comment. I totally aggree with @davidedmundson's objections. I will think about your comments and hand in another revision when I find some time. Things I will consider: - Don't re-emit persistent notifications. They

D7271: optionally show a history of notifications

This revision was automatically updated to reflect the committed changes. Closed by commit R120:28d86ab43567: optionally show a history of notifications (authored by progwolff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7271?vs=18139=18185#toc REPOSITORY R120 Plasma Workspace

D7271: optionally show a history of notifications

progwolff added a comment. thanks! REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7271 To: progwolff, #plasma, #vdg, davidedmundson Cc: mart, graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7271: optionally show a history of notifications

progwolff marked 2 inline comments as done. progwolff added a comment. so this can be considered accepted? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7271 To: progwolff, #plasma, #vdg Cc: mart, graesslin, davidedmundson, plasma-devel, ZrenBot,

D7271: optionally show a history of notifications

progwolff added a comment. In https://phabricator.kde.org/D7271#135544, @davidedmundson wrote: > Cool, do you have commit access? I have commit access, yes REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7271 To: progwolff, #plasma, #vdg Cc:

D7271: optionally show a history of notifications

progwolff updated this revision to Diff 18139. progwolff added a comment. - fix typo REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7271?vs=18135=18139 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7271 AFFECTED FILES

D7271: optionally show a history of notifications

progwolff updated this revision to Diff 18135. progwolff added a comment. - simplify object copy REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7271?vs=18134=18135 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7271 AFFECTED

D7271: optionally show a history of notifications

progwolff updated this revision to Diff 18134. progwolff added a comment. - use the same delegate for persistent notifications and history items REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7271?vs=18075=18134 BRANCH master REVISION DETAIL

D7271: optionally show a history of notifications

progwolff added a reviewer: VDG. progwolff added a comment. In https://phabricator.kde.org/D7271#135079, @graesslin wrote: > Could you please attach some screenshots and maybe also add the https://phabricator.kde.org/tag/vdg/ to the review? F3860046: notifications_screenshot.png

D7271: optionally show a history of notifications

progwolff updated this revision to Diff 18075. progwolff added a comment. - show number of active items in compact representation, excluding history - show heading above history - don't show actions in history REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D7271: optionally show a history of notifications

progwolff updated this revision to Diff 18051. progwolff added a comment. - fix property name REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7271?vs=18050=18051 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7271 AFFECTED FILES

D7271: optionally show a history of notifications

progwolff updated this revision to Diff 18050. progwolff added a comment. - uncomment unintentionally commented line - rename counters REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7271?vs=18045=18050 BRANCH master REVISION DETAIL

D7271: optionally show a history of notifications

progwolff marked 2 inline comments as done. progwolff added inline comments. INLINE COMMENTS > davidedmundson wrote in Notifications.qml:243 > ? sorry, missed to revert this... > davidedmundson wrote in Notifications.qml:257 > How does this differ to the persistent delegate? > > Can we share

D7271: optionally show a history of notifications

progwolff marked 2 inline comments as done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7271 To: progwolff, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7271: optionally show a history of notifications

progwolff created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Bug 378032. With these changes, notifications can be configured to always persist in the notifications applet. Todo: filter by

D7256: emit previously shown notifications after resume from idle

progwolff created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is an attempt to improve the behaviour of notifications that are triggered while the session is idle. This is related to (but not

<    1   2