D14857: Label job notifications with destination file name

2018-08-16 Thread Karthik Periagaram
karthikp added a comment. I see, thanks! Here's my name and email, Karthik Periagaram karthik.periaga...@gmail.com REVISION DETAIL https://phabricator.kde.org/D14857 To: karthikp, #vdg, ngraham, abetts Cc: abetts, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai

D14857: Label job notifications with destination file name

2018-08-16 Thread Karthik Periagaram
karthikp added a comment. Noob question (this is my first patch through phabricator and I don't have commit rights, naturally): How does one normally proceed now, do I mail or attach here, the patch (as in `git format-patch`) so someone can `git am -s` it into the next release's dev

D14857: Label job notifications with destination file name

2018-08-15 Thread Karthik Periagaram
karthikp updated this revision to Diff 39781. karthikp added a comment. Done! Thanks, I'm not confident in my javascript powers... yet. :) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14857?vs=39775=39781 REVISION DETAIL https://phabricator.kde.org/D14857 AFFECTED FILES

Help fixing minor issue in notifications

2018-08-15 Thread Karthik Periagaram
Hello everyone, I need some help in fixing this bug[1]. I have the plasma-browser integration add-on enabled in my browser and when downloading from places like google drive or similar file upload/sharing websites, the notification in the system tray is structured like this, Downloading

D14857: Label job notifications with destination file name

2018-08-15 Thread Karthik Periagaram
karthikp created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. karthikp requested review of this revision. REVISION SUMMARY If a destination file name is present, it is a better label for a job than the source file name. This is particularly true for