D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

kishoreg added a comment. @ngraham There are no issues on the login screen. Everything fits fine there. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23786 To: kishoreg, #plasma, #vdg, ngraham Cc: filipf, ngraham, plasma-devel, LeGast00n,

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

kishoreg updated this revision to Diff 66601. kishoreg added a comment. Rebase on `Plasma/5.17` branch REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23786?vs=65896=66601 REVISION DETAIL https://phabricator.kde.org/D23786 AFFECTED FILES

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

kishoreg added a comment. Is this fine, or should I revert to the previous diff I uploaded? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23786 To: kishoreg, #plasma, #vdg, ngraham Cc: filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

kishoreg updated this revision to Diff 65896. kishoreg added a comment. @filipf Is this better? Screenshot on small display (1366x768): F7342190: Screenshot_20190912_082244.png Screenshot on big display (1920x1080): F7342191:

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

kishoreg created this revision. kishoreg added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kishoreg requested review of this revision. REVISION SUMMARY This patch removes some spacing which was making the 'switch users' button get slightly

D23768: Set maximum volume of streams properly even if the user has configured a maximum volume <100% in the applet.

kishoreg added a comment. The problem is that the original patch was changing the maximum range of the sliders for application streams and microphones as well. This seemed a bit counter-intuitive, as for example capping the volumes of both the speaker and the music player at 15% would lead

D23768: Set maximum volume of streams properly even if the user has configured a maximum volume <100% in the applet.

kishoreg created this revision. kishoreg added reviewers: ngraham, romangg. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kishoreg requested review of this revision. REVISION SUMMARY Recently, I submitted this patch (https://phabricator.kde.org/D23082) which had a

D23082: Allow to set maximum volume < 100%

kishoreg created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kishoreg requested review of this revision. REVISION SUMMARY Currently one cannot set the maximum volume < 100%. This feature is required because some earphones / speakers are more

D21828: Invert controls direction for process priority slider

kishoreg updated this revision to Diff 59864. kishoreg added a comment. Do the same for the ionice slider too. REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21828?vs=59862=59864 REVISION DETAIL https://phabricator.kde.org/D21828 AFFECTED

D21828: Invert controls direction for process priority slider

kishoreg created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kishoreg requested review of this revision. REVISION SUMMARY Since low 'nice' values correspond to high priority, the slider labels are inverted so that 'higher' corresponds to a lower nice

D21620: Handle Esc properly when focus is in searchbox

kishoreg updated this revision to Diff 59340. kishoreg marked an inline comment as done. kishoreg added a comment. Added explanatory comment. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21620?vs=59260=59340 REVISION DETAIL

D21620: Handle Esc properly when focus is in searchbox

kishoreg created this revision. kishoreg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. kishoreg requested review of this revision. REVISION SUMMARY BUG: 408290 If we place the focus in the searchbar,

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg updated this revision to Diff 58849. kishoreg edited the test plan for this revision. kishoreg added a comment. Removed colon to keep string unchanged. Screenshot: F6858284: Screenshot_20190529_201418.png REPOSITORY R119 Plasma Desktop

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg added a comment. In D21414#471615 , @ngraham wrote: > With no items in the list view, the size looks perfect to me: > > F6858199: Screenshot_20190529_080727.png > > Are you seeing something

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg updated this revision to Diff 58838. kishoreg edited the test plan for this revision. kishoreg added a comment. Moved buttons to the left. F6858110: Screenshot_20190529_180905.png I'll try to figure out how to set the size hint properly.

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg added a comment. BTW, if I open the window standalone (from krunner), it allows me to resize it vertically so that the entire window gets scrollbars. F6856837: Screenshot_20190528_220702.png I can't do this horizontally. Is there some

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg updated this revision to Diff 58797. kishoreg added a comment. Screenshot as of this diff: F6856823: Screenshot_20190528_220210.png Are there any other changes that need to be made? REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg updated this revision to Diff 58786. kishoreg added a comment. This is awkward. I hadn't realized that I was supposed to use one space for indentation. Fixed as per the preexisting convention. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg updated this revision to Diff 58784. kishoreg added a comment. I seem to have messed up the indentation in my previous diff. Here it is with the indentation fixed. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21414?vs=58781=58784

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg marked an inline comment as done. kishoreg added a comment. BTW, checkboxes in other KCMs also seem to have the same spacing as this one had before this change. Is there a way to globally apply this spacing / padding consistently to QCheckBoxes in all KCMs for the sake of

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg updated this revision to Diff 58781. kishoreg added a comment. I've added a colon after the 'Do not search in these locations' text. I've also added spacing between the checkboxes and their text. I've put in 10 px for now. Is there a better way to do this? Without additional

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg updated this revision to Diff 58723. kishoreg edited the summary of this revision. kishoreg added a comment. This patch incorporates Nate's suggestion to remove the box around the 'exclude folders' area. I've added screenshots of all three cases (with spacer, with box, and without

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg added a comment. Before change: F6854280: Screenshot_20190519_105621.png Initial patch: F6854282: Screenshot_20190527_181359.png With box removed: F6854285: Screenshot_20190527_190128.png

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg created this revision. kishoreg added a reviewer: Baloo. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kishoreg requested review of this revision. REVISION SUMMARY I just removed a spacer. It seems like it was added intentionally, so I'm not sure if removing