Kf6 restore session/ autostart apps

:true X-DBUS-StartupType=Unique " in org.kde.kalendarac.desktop I don’t know how to debug it. Do you have an idea where I can debug it ? Thanks -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel: France +33 (0)4 9

Re: Relicensing Plasma Browser Integration Host to GPLv3+

log the following people (and myself) touched that folder: > > David Edmundson > Fabian Vogt > Laurent Montel > Friedrich W. H. Kossebau > Matthijs Tijink > > Are you fine with this, or have any other comments? > > Cheers > Kai Uwe > > (Should probably do

D27866: Make it compile against qt5.15. ::unite is deprecated.

This revision was automatically updated to reflect the committed changes. Closed by commit R123:9e3f9fb2c8cb: Make it compile against qt5.15. ::unite is deprecated. (authored by mlaurent). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D27866: Make it compile against qt5.15. ::unite is deprecated.

mlaurent added a comment. ping ?:) REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D27866 To: mlaurent, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham

D27866: Make it compile against qt5.15. ::unite is deprecated.

mlaurent created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY Make it compile against qt5.15 REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH build_against_qt5.15 (branched from mas

D27408: Fix build with Qt 5.15.0

mlaurent added a comment. So you review all patch from all repo ? :) awesome ! I am not able to do it! And I don't want to do it otherwise no possible to work on my projects. But I am happy that you do it ! :) So for sure I will not review all patchs from framework/plasma, but I am not

D27408: Fix build with Qt 5.15.0

mlaurent added a comment. no each reviews but when you create a patch for qt5.15 as I was the only dev which worked on qt5.15 it was logical to add me. I will not subscribe for each commit in plasma/framework, for sure after 20-30 commits I will not read them. I have ~ 200 mails by days, so

D27408: Fix build with Qt 5.15.0

mlaurent added a comment. In D27408#613565 , @ngraham wrote: > @mlaurent ^^ Just a question: How I can see it if nobody adds me as reviewer (if I remember I was the only one guys who works against qt5.15 from several months so why don't

D27066: remove pointless ifdef

mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. wrong as static_cast is deprecated and it will not work without deprecated method. Or you can convert it to static_cast but "int" signal doesn't exist when we build withou

D26912: Use Qt5 signal syntax, format files, optimizations

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. seems ok for me now. Thanks REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26912 To: alex, mlaurent, davidedmundson Cc: plasma-devel, Orage, LeGast00

D26912: Use Qt5 signal syntax, format files, optimizations

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > autostart.cpp:64 > +connect(widget->btnProperties, &QPushButton::clicked, > +this, static_cast (Autostart::*)()>((&Autostart::slotEditCMD))

D26912: Use Qt5 signal syntax, format files, optimizations

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > addscriptdialog.cpp:39 > +QVBoxLayout *lay = new QVBoxLayout; > +setLayout(lay); > +QLabel *lab = new QLabel(i18n("Shell script path:"), this);

D26790: Remove unused variable (probabilities) + make it compile without deprecated method: reverseDist is already a QMultiHash

mlaurent closed this revision. mlaurent added a comment. Done in 2 commits. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D26790 To: mlaurent, apol Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, ahiemstra, davidedmundson, mart, hein

D26790: Remove unused variable (probabilities) + make it compile without deprecated method: reverseDist is already a QMultiHash

mlaurent created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY Make it compile without deprecated method (qt5.15) REPOSITORY R169 Kirigami BRANCH make_it_compile_qt5.15 (branched from m

D26533: Add a logging category for the backend

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems ok now for me :) thanks REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D26533 To: meven, apol, ngraham, mlaurent Cc: mla

D26533: Add a logging category for the backend

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:14 > TransactionSet.cpp > +libdiscover_backend_debug.cpp > pkui.qrc Why adding it ? it's autogenerated so it's added by cmake

D26189: Port to QRandomGenerator

This revision was automatically updated to reflect the committed changes. Closed by commit R111:161b6c42205f: Port to QRandomGenerator (authored by mlaurent). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26189?vs=72085&id=72098 REVISION DETAIL h

D26189: Port to QRandomGenerator

mlaurent created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY Port to QRandomGenerator TEST PLAN autotest ok REPOSITORY R111 KSysguard Library BRANCH port_QRandomGenerator (branched f

D26063: QMultiHash::insertMulti is deprecated. Use directly ::insert

This revision was automatically updated to reflect the committed changes. Closed by commit R111:3f2fab734574: QMultiHash::insertMulti is deprecated. Use directly ::insert (authored by mlaurent). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26063?vs

D26063: QMultiHash::insertMulti is deprecated. Use directly ::insert

mlaurent created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY QMultiHash::insertMulti is deprecated REPOSITORY R111 KSysguard Library BRANCH remove_qmultihash_insertmulti (branched from

D25736: Make it compile without deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R115:c38b6a9f2953: Make it compile without deprecated method (authored by mlaurent). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25736?vs=70896&id=

D25736: Make it compile without deprecated method

mlaurent added a comment. ping ? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D25736 To: mlaurent, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-

D25736: Make it compile without deprecated method

mlaurent created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without deprecated method REPOSITORY R115 Plasma Audio Volume Applet BRANCH compile_without_deprecated_method (branc

D25729: Make it compile without qt deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R134:f32965ea3a9f: Make it compile without qt deprecated method (authored by mlaurent). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25729?vs=70877&id=

D25709: Make it compile against qt5.14 without deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R858:8eca435225b6: Make it compile against qt5.14 without deprecated method (authored by mlaurent). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.

D25729: Make it compile without qt deprecated method

mlaurent created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY Compile without deprecated qt5.x method REPOSITORY R134 Discover Software Store BRANCH compile_against_qt514_no_deprecated (

D25709: Make it compile against qt5.14 without deprecated method

mlaurent updated this revision to Diff 70876. mlaurent added a comment. Forgot to commit it REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25709?vs=70875&id=70876 BRANCH fix_compile_qt5.14 (branched from master) REVISION DETAI

D25709: Make it compile against qt5.14 without deprecated method

mlaurent updated this revision to Diff 70875. mlaurent added a comment. Fix comment REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25709?vs=70808&id=70875 BRANCH fix_compile_qt5.14 (branched from master) REVISION DETAIL http

D25709: Make it compile against qt5.14 without deprecated method

mlaurent added a comment. yep it seems more logical REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D25709 To: mlaurent, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D25709: Make it compile against qt5.14 without deprecated method

mlaurent created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY Compile against 5.14 without deprecated method REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH fix_compile_qt5.14

D25609: Port KSMServer's KCM to KConfigXT

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmsmserver.h:50 > > + Ui::SMServerConfigDlg *ui; > + SMServerSettings *m_settings; it seems that ui is never deleted. (I can't see it deleted in dest

D25086: Port to KGlobalAccel

mlaurent added a comment. Did you have some problem for commiting it ? Regards REPOSITORY R103 KMenu Editor BRANCH globalaccel (branched from master) REVISION DETAIL https://phabricator.kde.org/D25086 To: davidre, #plasma, davidedmundson, mlaurent Cc: apol, mlaurent, plasma-devel, L

D25086: Port to KGlobalAccel

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. for me all is ok. REPOSITORY R103 KMenu Editor BRANCH globalaccel (branched from master) REVISION DETAIL https://phabricator.kde.org/D25086 To: davidre, #plasma, davidedmundson,

D25086: Port to KGlobalAccel

mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. After that it seems ok for me INLINE COMMENTS > globalaccel.cpp:25 > +kmenueditGroup = KConfigGroup(&khotkeysrc, > QStringLiteral("Data_%1").arg(i)); > +if (k

D25086: [WIP] Port to KGlobalAccel

mlaurent added a comment. For me it seems ok Did you finish it ? is it work ? or still in progress ? REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D25086 To: davidre, #plasma, davidedmundson, mlaurent Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kglobalshortcutseditor.cpp:436 > +// Do we have an application with that name? > +KService::List apps = > KServiceTypeTrader::self

D25086: [WIP] Port to KGlobalAccel

mlaurent added inline comments. INLINE COMMENTS > basictab.cpp:38 > > #ifndef Q_OS_WIN > +#include "globalaccel.h" still necessary to #ifndef ? REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D25086 To: davidre, #plasma, davidedmundson, mlaurent Cc: apol, mlaur

D25086: [WIP] Port to KGlobalAccel

mlaurent added inline comments. INLINE COMMENTS > globalaccel.cpp:55 > +const QList shortcut = > KGlobalAccel::self()->globalShortcut(desktopFile, QStringLiteral("_launch")); > +if (shortcut.size() > 0) { > +return shortcut[0]; if (!shortcut.isEmpty()) { > menuinfo.cpp:180 >

D25086: [WIP] Port to KGlobalAccel

mlaurent added inline comments. INLINE COMMENTS > CMakeLists.txt:39 > -find_package(KHotKeysDBusInterface QUIET) > -if (EXISTS "${CMAKE_SOURCE_DIR}/.git") > - add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06) Why removing it ? REPOSITORY R103 KMenu Editor REVISION DETAIL https://p

D24530: [XembedSNIProxy] If available, always use 32-bit color.

mlaurent added a comment. Hi, You can't commit yet as nobody accepted this patch. Regards REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24530 To: kmaterka, davidedmundson, #plasma_workspaces, #plasma Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-

D24615: Fix crash with sortAllByName/Description

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. it seems ok for me. Thanks REPOSITORY R103 KMenu Editor BRANCH ahmad/takechildren-crash-on-index-rootItem (branched from master) REVISION DETAIL https://phabricator.kde.org/D24

D23823: [KMenuEdit] port away from KStandardDirs

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems ok for me. REPOSITORY R103 KMenu Editor BRANCH master REVISION DETAIL https://phabricator.kde.org/D23823 To: dfaure, mlaurent Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev

Re: CI system maintainability

Le jeudi 28 mars 2019, 18:27:42 CET Friedrich W. H. Kossebau a écrit : > Thanks for reply. More below: > > Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel: > > Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit : > > > Hi Laurent, > &

Re: CI system maintainability

Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit : > Hi Laurent, > > Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel: > > For example I works all days on kde (pim or other) when I wake up, or at > > noon after my lunch or the evening, I

Re: CI system maintainability

ke reviews mandatory" there is not an impact about your work as we know that you are not really active on kde at the moment... For sure I broke kcontact 2 days ago, but as a friend told me when I started to work on kde "We can't create a bug when we don't code..." Regards

D19799: QNetworkReply was not deleted

This revision was automatically updated to reflect the committed changes. Closed by commit R134:4adbb68bf405: QNetworkReply was not deleted (authored by mlaurent). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19799?vs=54387&id=54647 REVISION

D19799: QNetworkReply was not deleted

mlaurent added a comment. is it ok now ? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19799 To: mlaurent, apol, #discover_software_store Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, a

D19959: Fixed issue causing changed signal to be called with false argument

This revision was automatically updated to reflect the committed changes. Closed by commit R123:ed3decc06e38: Fixed issue causing changed signal to be called with false argument (authored by mlaurent). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabric

D19959: Fixed issue causing changed signal to be called with false argument

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Good catch. it's a bug in clazy. Thanks Do you have an commit access ? or do you want that I commit for you ? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL

D19799: QNetworkReply was not deleted

mlaurent updated this revision to Diff 54387. mlaurent added a comment. Fix QScopedPointer REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19799?vs=54015&id=54387 BRANCH delete_qnetwork_reply (branched from master) REVISION DETAIL https

D19851: [kirigami] make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R169:12fb6c5de392: [kirigami] make it compile without foreach (authored by mlaurent). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19851?vs=54207&id=54311 REVISION D

D19851: [kirigami] make it compile without foreach

mlaurent added inline comments. INLINE COMMENTS > apol wrote in kirigamiplugin.cpp:48 > qAsConst isn't necessary because the method is already const. > Is it just for readability? Yep just for readability. It's just for avoiding that we thing it will detach. For sure here it will not detach. RE

D19851: [kirigami] make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R169 Kirigami BRANCH compil

D19799: QNetworkReply was not deleted

mlaurent updated this revision to Diff 54015. mlaurent added a comment. Use QScopedPointer REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19799?vs=53998&id=54015 BRANCH delete_qnetwork_reply (branched from master) REVISION DETAIL https

D19799: QNetworkReply was not deleted

mlaurent updated this revision to Diff 53998. mlaurent added a comment. Fix indent REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19799?vs=53990&id=53998 BRANCH delete_qnetwork_reply (branched from master) REVISION DETAIL https://phabr

D19799: QNetworkReply was not deleted

mlaurent created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY delete networkreply REPOSITORY R134 Discover Software Store BRANCH delete_qnetwork_reply (branched from master) REVISION DE

D18939: KMenuEdit: add search/filter bar

mlaurent added inline comments. INLINE COMMENTS > kmenuedit.cpp:137 > +m_searchLine = new KTreeWidgetSearchLine(this, m_tree); > +m_searchLine->setCaseSensitivity(Qt::CaseSensitivity::CaseInsensitive); > +m_searchLine->setKeepParentsVisible(true); you can use directly Qt::CaseInsensi

D14423: Mingw compile fix

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. For me it seems ok :) I can't test it. > +2 I trust you :) === REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D14423

D12116: Use const'ref here too

This revision was automatically updated to reflect the committed changes. Closed by commit R104:58f9e46b1dad: Use const'ref here too (authored by mlaurent). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12116?vs=31895&id=31949 REVISION DETAIL https://phabr

D12116: Use const'ref here too

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mlaurent requested review of this revision. TEST PLAN compile REPOSITORY R104 KScreen BRANCH use_const_ref REVISION DETAIL https://phabricator.kde.org

D12113: Use nullptr. Use const/ref.

This revision was automatically updated to reflect the committed changes. Closed by commit R104:5dbe76009828: Use nullptr. Use const/ref. (authored by mlaurent). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12113?vs=31880&id=31892 REVISION DETAIL https://

D12110: Extract i18n from qml too

This revision was automatically updated to reflect the committed changes. Closed by commit R104:31b72f4ad003: Extract i18n from qml too (authored by mlaurent). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12110?vs=31876&id=31881 REVISION DETAIL https://ph

D12111: Remove unused code.

This revision was automatically updated to reflect the committed changes. Closed by commit R104:0cc080688be5: Remove unused code. (authored by mlaurent). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12111?vs=31877&id=31882 REVISION DETAIL https://phabricat

D12113: Use nullptr. Use const/ref.

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mlaurent requested review of this revision. TEST PLAN Build REPOSITORY R104 KScreen BRANCH clean_code REVISION DETAIL https://phabricator.kde.org/D121

D12111: Remove unused code.

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mlaurent requested review of this revision. REPOSITORY R104 KScreen BRANCH remove_unused_plasma REVISION DETAIL https://phabricator.kde.org/D12111 AFFEC

D12110: Extract i18n from qml too

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY i18n from qml was not extracted REPOSITORY R104 KScreen BRANCH fix_extract_message REVISION

D12109: Fix clone action (typo in enum)

This revision was automatically updated to reflect the committed changes. Closed by commit R104:c17c08526424: Fix clone action (typo in enum) (authored by mlaurent). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12109?vs=31874&id=31875 REVISION DETAIL http

D12109: Fix clone action (typo in enum)

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY We can't clone screen (typo in enum action) TEST PLAN Plug another screen and try to unify it.

D10605: Fix location of Firefox dbCacheFile

This revision was automatically updated to reflect the committed changes. Closed by commit R120:745cffc9ffd3: Fix location of Firefox dbCacheFile (authored by z3ntu, committed by mlaurent). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10605?vs=27414

D10605: Fix location of Firefox dbCacheFile

mlaurent added a comment. Ok I will commit for you. Regards REPOSITORY R120 Plasma Workspace BRANCH D10605 REVISION DETAIL https://phabricator.kde.org/D10605 To: z3ntu, mlaurent Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10605: Fix location of Firefox dbCacheFile

mlaurent added a comment. Do you have commit access ? REPOSITORY R120 Plasma Workspace BRANCH D10605 REVISION DETAIL https://phabricator.kde.org/D10605 To: z3ntu, mlaurent Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10605: Fix location of Firefox dbCacheFile

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R120 Plasma Workspace BRANCH D10605 REVISION DETAIL https://phabricator.kde.org/D10605 To: z3ntu, mlaurent Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali

D10605: Fix location of Firefox dbCacheFile

mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. Otherwise patch is correct. INLINE COMMENTS > firefox.cpp:58 > if (m_dbCacheFile.isEmpty()) { > -m_dbCacheFile = > QStandardPaths::writableLocation(QStandardPath

D10151: Solved bug 382512

mlaurent added a comment. Ping ? REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent, ngraham Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10151: Solved bug 382512

mlaurent added a comment. For patch it seems ok. But Nathaniel is right. Describe how you tested it, add BUG: etc. Otherwise it's a good start :) Thanks. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent, ngraham Cc: ngraha

D10111: [Klipper] Force plain text on the edit dialog

mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. Indeed it's better. but we need to use setAcceptRichText(false) in edit otherwise we can set html text by dnd or copy. REPOSITORY R120 Plasma Workspace REVISION DETAIL ht

D9325: Use QUrl in the ScreenMapper API

mlaurent added inline comments. INLINE COMMENTS > screenmapper.cpp:101 > const auto screenPathWithScheme = screenUrl.url(); > -const bool isEmpty = (path.isEmpty() || screenUrl.path() == "/"); > +const bool isEmpty = (screenUrl.isEmpty() || screenUrl.path() == "/"); > // restore

D9323: Use ScreenMapper everywhere as a singleton

mlaurent added a comment. Seems ok for me. REVISION DETAIL https://phabricator.kde.org/D9323 To: amantia, #plasma, mwolff, hein Cc: mlaurent, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9325: Use QUrl in the ScreenMapper API

mlaurent added inline comments. INLINE COMMENTS > foldermodeltest.cpp:34 > > +static QUrl stringToUrl(const QString &path) { > +return QUrl::fromUserInput(path, {}, QUrl::AssumeLocalFile); new line after ')' > positionertest.cpp:38 > > +static QUrl stringToUrl(const QString &path) { > +

D9300: Store screenMapping info only once

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. seems good for me REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D9300 To: amantia, #plasma, mwolff, hein, broulik, mlaurent Cc: mlaure

D9300: Store screenMapping info only once

mlaurent added inline comments. INLINE COMMENTS > screenmapper.cpp:202 > +KConfigGroup group(config, QLatin1String("ScreenMapping")); > +QStringList mapping = > group.readEntry(QLatin1String("screenMapping"), QStringList{}); > +setScreenMapping(mapping); cons

D8444: Define default Action when we plug unknown monitor

mlaurent added a comment. Ping ? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D8444: Define default Action when we plug unknown monitor

mlaurent added a comment. @sebas: What do you want as widget design ? Is it ok to add plasma dependancy in kscreen ? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-

D8444: Define default Action when we plug unknown monitor

mlaurent added a comment. (I was in vacation.) Ok so I need to create an osd plasma for it. I can trash this current patch. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: sebas, graesslin, dvratil, davidedmundson, ngraham,

D8493: Make Folder View screen aware

mlaurent added inline comments. INLINE COMMENTS > foldermodeltest.cpp:70 > +delete m_folderDir; > +m_folderDir = 0; > delete m_folderModel; m_folderDir = nullptr > foldermodeltest.cpp:294 > +FolderModel secondFolderModel; > +secondFolderModel.setUrl(m_folderDir->path() + Q

D8493: Make Folder View screen aware

mlaurent added inline comments. INLINE COMMENTS > foldermodel.h:192 > +ScreenMapper* screenMapper() const; > +void setScreenMapper(ScreenMapper* screenMapper); > + Coding style "space before *" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8493

D8444: Define default Action when we plug unknown monitor

mlaurent edited the test plan for this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8444: Define default Action when we plug unknown monitor

mlaurent edited the test plan for this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8444: Define default Action when we plug unknown monitor

mlaurent edited the test plan for this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8444: Define default Action when we plug unknown monitor

mlaurent edited the test plan for this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8444: Define default Action when we plug unknown monitor

mlaurent retitled this revision from "WIP: Define default Action when we plug unknown monitor" to "Define default Action when we plug unknown monitor". REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent Cc: graesslin, dvratil, davidedmundson, ngraham, pla

D8432: Use nullptr. Initialize pointer

This revision was automatically updated to reflect the committed changes. Closed by commit R110:7c602a831f5d: Use nullptr. Initialize pointer (authored by mlaurent). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8432?vs=21172&id=21566 REVISION DETAIL

D8553: It's autotests not tests

This revision was automatically updated to reflect the committed changes. Closed by commit R119:357bb3ab75c9: It's autotests not tests (authored by mlaurent). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8553?vs=21558&id=21565#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UP

D8553: It's autotests not tests

mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8553 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8553: It's autotests not tests

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN compile REPOSITORY R119 Plasma Desktop BRANCH rename_as_autotest REVISION DETAIL https://phabricator.kde.org/D8553 AFFECTED FILES contain

D8549: We use Q_DECL_OVERRIDE or override.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0adccf18e3d0: We use Q_DECL_OVERRIDE or override. (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8549?vs=21551&id=21553 REVISION DET

D8515: Don't loop twice here

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9a5e9be03fe6: Don't loop twice here (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8515?vs=21422&id=21552 REVISION DETAIL https://

D8549: We use Q_DECL_OVERRIDE or override.

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY > use unique keyword override = TEST PLAN compile REPOSITORY R119 Plasma Desktop BRANCH use_override R

D8549: We use Q_DECL_OVERRIDE or override.

mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8549 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8515: Don't loop twice here

mlaurent added a comment. This one too ?:) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8515 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

  1   2   >