Re: Review Request 120353: Add timezones i18n stuff

2014-09-24 Thread Lukáš Tinkl
On Zář. 24, 2014, 2:42 odp., Sebastian Kügler wrote: applets/digital-clock/plugin/timezonesi18n.cpp, line 418 https://git.reviewboard.kde.org/r/120353/diff/1/?file=315266#file315266line418 Does it really make sense to have translations added for UTC offsets, and UTC itself?

Re: Review Request 120353: Add timezones i18n stuff

2014-09-24 Thread Lukáš Tinkl
KLocale/KTimezone to get the stuff we need meanwhile, no need to reinvent the wheel. Users don't care - Lukáš Tinkl On Zář. 24, 2014, 2:02 odp., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 120040: Install kdesu under bin

2014-09-02 Thread Lukáš Tinkl
/120040/#comment45938 The comment should probably also say kdesu5 I'm a bit worried by the multitude of user and distro specific scripts that rely on kdesu being present :/ - Lukáš Tinkl On Zář. 2, 2014, 8:27 odp., Marco Martin wrote

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/#review59397 --- Ship it! Ship It! - Lukáš Tinkl On June 6, 2014, 8:45 a.m

Re: Review Request 118516: Load the networkmanager applet on demand

2014-06-04 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118516/#review59153 --- How would you connect to a VPN in that case? - Lukáš Tinkl

Re: Review Request 118516: Load the networkmanager applet on demand

2014-06-04 Thread Lukáš Tinkl
On June 4, 2014, 1:02 p.m., Lukáš Tinkl wrote: How would you connect to a VPN in that case? Marco Martin wrote: Is networkmanager used to connect a VPN? (and more generally, are there any features in the plasmoid that can be used without networkmanager running?) Yes

Re: Review Request 110135: Adjust Kickoff actions to latest Powerdevil changes

2013-04-23 Thread Lukáš Tinkl
interface for that (org.freedesktop.PowerManagement) - Lukáš Tinkl On April 23, 2013, 7:28 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110135

Re: Review Request 110135: Adjust to new suspend session handling

2013-04-23 Thread Lukáš Tinkl
://git.reviewboard.kde.org/r/110135/#comment23442 I doubt these actions exist on the FDO object, Dario? plasma/generic/dataengines/time/timeengine.cpp http://git.reviewboard.kde.org/r/110135/#comment23441 This is weird... why would you change this? - Lukáš Tinkl On April 23, 2013, 9:12 p.m., Hrvoje

Re: Review Request 110135: Adjust to new suspend session handling

2013-04-23 Thread Lukáš Tinkl
://git.reviewboard.kde.org/r/110135/#comment23445 This is still wrong... plasma/generic/dataengines/time/timeengine.cpp http://git.reviewboard.kde.org/r/110135/#comment23446 ... same as this, you even removed the final t from the service name - Lukáš Tinkl On April 23, 2013, 10:26 p.m., Hrvoje Senjan

Re: networkmanagement plasmoid

2013-03-28 Thread Lukáš Tinkl
/27/plasma-nm-preview/ -- Lukáš Tinkl lti...@redhat.com Software Engineer - KDE desktop team, Brno KDE developer lu...@kde.org Red Hat Inc. http://cz.redhat.com ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request: Fix battery applet screen power management

2012-10-15 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106784/#review20366 --- Ship it! Ship It! - Lukáš Tinkl On Oct. 10, 2012, 3:13 p.m

Re: Review Request: Fix battery applet screen power management

2012-10-10 Thread Lukáš Tinkl
? - Lukáš Tinkl On Oct. 10, 2012, 3:13 p.m., Oliver Henshaw wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106784

<    1   2