:
Code-wise the patch looks fine.
Marco Gulino wrote:
You're right, there's a compatibility break, and we can't even know
starting from which version, since it's an internal database not documented
(I might try looking around, but I don't expect to find much).
If it makes sense, I
favicon is shown.
Removing the database query fix, but leaving the safety guard, and cleaning
favicon cache (to have again a broken feature case), the default icon is
shown.
Thanks,
Marco Gulino
___
Plasma-devel mailing list
Plasma-devel@kde.org
https
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109049/#review27876
---
On Feb. 21, 2013, 7:29 p.m., Marco Gulino wrote
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109049/#review27760
---
On Feb. 19, 2013, 10:42 p.m., Marco Gulino wrote
:
Code-wise the patch looks fine.
Marco Gulino wrote:
You're right, there's a compatibility break, and we can't even know
starting from which version, since it's an internal database not documented
(I might try looking around, but I don't expect to find much).
If it makes sense, I
the plugin, restart krunner, type
bookmarks to view all bookmarks: proper favicon is shown.
Removing the database query fix, but leaving the safety guard, and cleaning
favicon cache (to have again a broken feature case), the default icon is
shown.
Thanks,
Marco Gulino
it to 0 (or
better, NULL), as delete NULL is a noop.
Apart from this, I think it's ok :)
- Marco Gulino
On Sept. 19, 2012, 11:21 a.m., Giorgos Tsiapaliwkas wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
My fault, sorry... I just forgot about that additional dependency. I think
I'll be able to fix it today or tomorrow, by simply disabling chrome
support when QJSON is not found.
Small problem: there is no builtin CMake script for QJSON, there's one
around that works quite fine, however, I've been
://git.reviewboard.kde.org/r/105673/#review16476
---
On July 26, 2012, 10:23 a.m., Marco Gulino wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r
-home/Chrome-Bookmarks-SecondProfile.json
PRE-CREATION
plasma/generic/runners/bookmarks/tests/testchromebookmarks.h PRE-CREATION
plasma/generic/runners/bookmarks/tests/testchromebookmarks.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/105673/diff/
Testing
---
Thanks,
Marco
On July 22, 2012, 11:17 p.m., Aleix Pol Gonzalez wrote:
I don't see the patch...?
Marco Gulino wrote:
it's in a separate branch (the one specified above) , there are too many
files, a patch wouldn't be handy :-)
Marco Martin wrote:
posting a git diff here to master would
(both unit and manual) and
cleanup.
branch: plasma/bookmarksrunner-chrome-gulino, path
/plasma/generic/runners/bookmarks
Diffs
-
Diff: http://git.reviewboard.kde.org/r/105673/diff/
Testing
---
Thanks,
Marco Gulino
___
Plasma-devel
missing: maybe a little more testing (both unit and manual) and
cleanup.
branch: plasma/bookmarksrunner-chrome-gulino, path
/plasma/generic/runners/bookmarks
Diffs
-
Diff: http://git.reviewboard.kde.org/r/105673/diff/
Testing
---
Thanks,
Marco Gulino
generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105673/#review16244
---
On July 22, 2012, 10:27 p.m., Marco Gulino wrote:
---
This is an automatically generated e
On Fri, Jul 20, 2012 at 11:50 AM, Alex Fiestas afies...@kde.org wrote:
If it's ok I can start pushing refactored code to master starting
tomorrow.
That was fast! :p
I was in Tibet the last 4 years, i learned some secret refactoring
tecniques :P Also, these two days i don't have much stuff
Thank you, but this proxy is kinda too much restrictive, i can use https,
but ssh on https port doesn't seem to work.
Anyway, not a big deal... in a few hours i'll be on holiday for a whole
month, no proxy or firewalls in the way :)
On Fri, Jul 20, 2012 at 1:11 PM, Ben Cooksley bcooks...@kde.org
like a hack is needed, since i cant load blob icons directly into a pixmap.
I tried using temporary files, and it works, but it sounds like a dirty
approach, kinda study it a little more before pushing.
Thanks
Marco
On Fri, Jul 20, 2012 at 1:59 PM, Marco Gulino marco.gul...@gmail.comwrote:
Thank
Hello!
As i've been suggested, forwarding my previous mail in here, since i'm
working on plasma files.
Thanks
Marco
-- Forwarded message --
From: Marco Gulino marco.gul...@gmail.com
Date: Thu, Jul 19, 2012 at 9:43 AM
Subject: back developing [KRunner Bookmarks for chrome]
To: kde
Well yes, but i don't mean to develop a separate runner, just add chrome
support to the existing one (which already supports Firefox and Opera too).
And yes, i saw a chrome runner too, but it's a standalone runner. I'll
probably still look at it, but the main point is to refactor the existing
one
19 matches
Mail list logo
