D6420: Restore active client after ending showing desktop

graesslin added a comment. In https://phabricator.kde.org/D6420#120233, @broulik wrote: > Still there? sorry, but what do you mean? FYI, I noticed that I did forget to remove the expect fail prior to reading your comment (you were faster and there is no mobile in

D6420: Restore active client after ending showing desktop

graesslin updated this revision to Diff 15955. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Remove expect fail from testing REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6420?vs=15951=15955 BRANCH

D6420: Restore active client after ending showing desktop

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Showing desktop requests focus on the desktop window. This means the active window is reset. When ending showing desktop the state was

D6411: [platforms/x11] Use a GlxContextAttributeBuilder

graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Based on the work of https://phabricator.kde.org/R108:3f4995fb9b4fd753a304ea65020bbafdd174936b this change introduces a

D6401: [platforms/x11] Request OpenGL 2.1 instead of 1.2

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Mismatch in the major/minor version. Requesting 1.2 doesn't make any sense given that KWin requires 2.1. REPOSITORY R108 KWin

D6396: Refactor the specification of OpenGL context attributes

This revision was automatically updated to reflect the committed changes. Closed by commit R108:3f4995fb9b4f: Refactor the specification of OpenGL context attributes (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6396?vs=15894=15900

D6400: Set correct icons for plasma config windows on wayland

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D6400 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D6396: Refactor the specification of OpenGL context attributes

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in egl_context_attribute_builder.cpp:50 > Do you have some sort of checklist of C++11 features to use? > > For a single integer, emplace_back is going to do the exact same thing as the > standard push_back. If one always

D6396: Refactor the specification of OpenGL context attributes

graesslin marked an inline comment as done. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6396 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart,

D6396: Refactor the specification of OpenGL context attributes

graesslin updated this revision to Diff 15894. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Fix missing haveCreateContext - good spot Sir! REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6396?vs=15885=15894

D6047: WIP: Support XDG v6

graesslin added a comment. In https://phabricator.kde.org/D6047#119698, @mart wrote: > trying to implement the kwin part of ping btw, will do in a branch of the branch kwin/xdgv6 no need to hurry with it. IMHO the way ping works is completely broken and won't work. At least Qt

D6344: [platforms/x11] Add support for GLX_NV_robustness_video_memory_purge

This revision was automatically updated to reflect the committed changes. Closed by commit R108:97fa72ee48b7: [platforms/x11] Add support for GLX_NV_robustness_video_memory_purge (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D6304: Properly block the edge also for touch screen edges

This revision was automatically updated to reflect the committed changes. Closed by commit R108:6267d597311c: Properly block the edge also for touch screen edges (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6304?vs=15663=15893

D6396: Refactor the specification of OpenGL context attributes

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The current way to specify the OpenGL context attributes does no longer scale as can be seen in https://phabricator.kde.org/D6344.

D6186: Implement software cursor in OpenGL backend

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6186 To: Kanedias, graesslin, davidedmundson Cc: aacid, luebking, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D6186: Implement software cursor in OpenGL backend

graesslin added inline comments. INLINE COMMENTS > Kanedias wrote in scene_opengl.h:141 > Should we heal other methods suffering from this? I can prepare such patch. No, we don't change the existing code. Only new code gets override. REPOSITORY R108 KWin REVISION DETAIL

D6186: Implement software cursor in OpenGL backend

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Looks good to me. Just a minor comment regarding where to put the new virtual method. Setting to reject changes as requested by Albert :-) INLINE COMMENTS >

D6047: WIP: Support XDG v6

graesslin added a comment. could you please upload a version with context? INLINE COMMENTS > mart wrote in xdgshell_interface.h:80 > from kwin, client.cpp: > i guess that's the kwin part that will have to use this. > it uses a single timer, and tries for a couple of timeout, as soon as the

D6344: [platforms/x11] Add support for GLX_NV_robustness_video_memory_purge

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Based on earlier phab-request https://phabricator.kde.org/D2079. Adds the nvidia memory purge extension to the robust context

D6323: Remove roundtrip to XServer from Workspace::xStackingOrderIntroduce a method Workspace::markXStackingOrderAsDirty

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This method replaces the calls x_stacking_dirty = true in the code base allowing for further refactoring of that functionality.

D6304: Properly block the edge also for touch screen edges

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY There was a regression introduced with bug fix https://phabricator.kde.org/R108:eec6afe6f5fef80f519c7afb33e4fd568d74aab0 which added

D6274: Use AbstractClient instead of Client in placement

This revision was automatically updated to reflect the committed changes. Closed by commit R108:92207be904aa: Use AbstractClient instead of Client in placement (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6274?vs=15587=15619 REVISION

D6275: Make Workspace::switchWindow operate on AbstractClient

This revision was automatically updated to reflect the committed changes. Closed by commit R108:763fbf5fafd0: Make Workspace::switchWindow operate on AbstractClient (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6275?vs=15588=15620

D6264: Fix switch desktop on screenedge while resizing a Wayland window

This revision was automatically updated to reflect the committed changes. Closed by commit R108:7a3c29261226: Fix switch desktop on screenedge while resizing a Wayland window (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D6273: [tabbox] Fix casts to Client where it should be AbstractClient

This revision was automatically updated to reflect the committed changes. Closed by commit R108:3b9ccc65a3a8: [tabbox] Fix casts to Client where it should be AbstractClient (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D6258: Workaround Qt regression of no longer delivering events for the root window

This revision was automatically updated to reflect the committed changes. Closed by commit R108:a6dee74ee455: Workaround Qt regression of no longer delivering events for the root window (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D6260: Better handle cases when the xkb keymap fails to be created

This revision was automatically updated to reflect the committed changes. Closed by commit R108:0df09a8cbbb1: Better handle cases when the xkb keymap fails to be created (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6260?vs=15551=15614

D6257: Fix switch desktop through edge when moving window

This revision was automatically updated to reflect the committed changes. Closed by commit R108:c45e165514ec: Fix switch desktop through edge when moving window (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6257?vs=15543=15616 REVISION

D6275: Make Workspace::switchWindow operate on AbstractClient

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY By using AbstractClient instead of Client the method works also for Wayland windows. REPOSITORY R108 KWin BRANCH

D6274: Use AbstractClient instead of Client in placement

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY There were a few places where we still used Client instead of AbstractClient. By changing this the placement also works for Wayland

D6273: [tabbox] Fix casts to Client where it should be AbstractClient

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY A few areas in TabBox perform casts from Toplevel to Client. By casting to Client instead of AbstractClient the Wayland windows are

Re: Review Request 130163: Add ConsoleKit2 support for launching Wayland sessions

. Could you please reopen the request on phabricator.kde.org in order to reach all developers. Not everyone is looking at reviewboard any more. Thank you! - Martin Flöser On June 19, 2017, 9:42 a.m., Eric Koegel wrote

D6257: Fix switch desktop through edge when moving window

graesslin added a dependent revision: D6264: Fix switch desktop on screenedge while resizing a Wayland window. REPOSITORY R108 KWin BRANCH fix-screenedge-window-move-5.10 REVISION DETAIL https://phabricator.kde.org/D6257 To: graesslin, #kwin, #plasma, broulik Cc: plasma-devel, kwin,

D6264: Fix switch desktop on screenedge while resizing a Wayland window

graesslin added a dependency: D6257: Fix switch desktop through edge when moving window. REVISION DETAIL https://phabricator.kde.org/D6264 To: graesslin, #kwin, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6264: Fix switch desktop on screenedge while resizing a Wayland window

graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Screenedges only allows to switch desktop while moving window, not while resizing. There was a special branch which only checked this for

D6258: Workaround Qt regression of no longer delivering events for the root window

graesslin added a comment. In https://phabricator.kde.org/D6258#117243, @fvogt wrote: > What about the 5.8 branch? I'm not aware of any distros that use it with Qt 5.9, but IMO it needs to be fixed there as well. I think it is not reasonable for a distribution to keep Plasma on

D6260: Better handle cases when the xkb keymap fails to be created

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY If the keymap cannot be created a few pointers in Xkb are null. We should make sure to not call any xkbcommon functions on those null

D6258: Workaround Qt regression of no longer delivering events for the root window

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY With qtbase 2b34aefcf02f09253473b096eb4faffd3e62b5f4 we do no longer get events reported for the X11 root window. Our keyboard handling

D6257: Fix switch desktop through edge when moving window

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY There was a regression introduced in ScreenEdges when introducing the activatesForPointer method. It considered the switch desktop on

D6164: Make shadows work for windows 100% width or height

graesslin added inline comments. INLINE COMMENTS > mart wrote in utils.h:205 > not sure about calling a local function qMax3, it would suggest it comes from > qt. > > maybe utilsMax3 or something without q make it a variadic template function and call it maxOfAll REPOSITORY R108 KWin

Re: Plasma Vision v 2.0

Am 2017-06-12 01:19, schrieb Aleix Pol: On Sun, Jun 11, 2017 at 11:13 PM, Jonathan Riddell wrote: Yay, I like it. Across different operating systems? We don't do anything on Windows or Mac. Jonathan On Fri, Jun 09, 2017 at 09:40:28AM +0200, Jens Reuterberg wrote:

Re: Plasma Vision v 2.0

Am 2017-06-09 09:40, schrieb Jens Reuterberg: Time to get back to the vision. Plasma Vision 2 Plasma never dictates the user's needs, it only strives to solve them. Plasma never defines what the user should be allowed to do, it only ensures that she can. I'm not too happy with

D6141: make shadows work for windows 100%width or height

graesslin added inline comments. INLINE COMMENTS > geometry.cpp:2010 > } > +emit geometryShapeChanged(this, geometryBeforeUpdateBlocking()); > addRepaintDuringGeometryUpdates(); why is the signal moved? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6141

D3051: [applets/notification] Add nullptr check

graesslin abandoned this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3051 To: graesslin, #plasma, sebas, broulik Cc: mart, sebas, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, lukas

D6004: Add method to unlock greeter via consolekit.

graesslin added inline comments. INLINE COMMENTS > tcberner wrote in abstractlocker.cpp:62 > I'm not sure, if we can predictably get the name of the correct "broken" > session from within the script -- of course, the script could just unlock all > the sessions by iterating over them, but that

Re: Touchpad KCM

Am 2017-06-01 01:03, schrieb Aleix Pol: Hey, Anybody knows if it's possible not to show the touchpad KCM at all if it's not available? It's a bit odd to get it but see it all gray with an error saying "touchpad not found". FWIW this is an issue present in the KDE Slimbook. Slimbook could

D3650: lower mouse acceleration limit to 0.0

graesslin added a comment. In https://phabricator.kde.org/D3650#112888, @apol wrote: > In https://phabricator.kde.org/D3650#80584, @graesslin wrote: > > > According to my comments in the Wayland port: the value 1.0 means no acceleration. Values below 1.0 mean a de-acceleration or a

Re: Next Plasma LTS and openSUSE

Am 2017-05-29 12:56, schrieb David Edmundson: Stealing this LTS thread, there's something from Qt I'd like to copy: Currently, Qt 5.6 LTS is in the _‘strict’_ phase where it only receives selected critical fixes and next it is moving into the ‘_very strict_’ phase. During this final phase, Qt

D5825: kcheckpass: Add support in for non-Linux platforms via kevent.

graesslin added a subscriber: rjvbb. graesslin added a comment. In https://phabricator.kde.org/D5825#112682, @rjvbb wrote: > In https://phabricator.kde.org/D5825#112464, @davidedmundson wrote: > > > OS X is not a supported Plasma platform, BSD is. > > > Just for future

D6004: Add method to unlock greeter via consolekit.

graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:78 > TYPE RUNTIME > -PURPOSE "Needed for emergency unlock in case that the greeter is broken. > In case your distribution does

Re: Plasma Vision v 2.0

Am 2017-06-14 13:37, schrieb Sebastian Kügler: On Fri, 09 Jun 2017 09:40:28 +0200 Jens Reuterberg wrote: Time to get back to the vision. The comments we got were useful, and it seems the discussion is petering out ... that's probably a good sign. I didn't sense any

D6175: Fix build with future glibc (major/minor macros), BSD compatible

graesslin added a comment. Personally I would say master only as it is for future glibc. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6175 To: asturmlechner, #plasma Cc: graesslin, plasma-devel, kwin, #kwin, adridg, ZrenBot, spstarr, progwolff, lesliezhai,

Re: Notice of significant adjustment to KWin

messages (.desktop file) - always resolve ours 1432efb SVN_SILENT made messages (.desktop file) - always resolve ours e591280 Merge branch 'Plasma/5.10' Greetings Roman On Sat, Jun 10, 2017 at 8:41 PM, Martin Flöser <mgraess...@kde.org> wrote: Am 2017-06-10 11:43, schrieb Roman: Why have ther

Re: Notice of significant adjustment to KWin

Am 2017-06-10 11:43, schrieb Roman: Why have there been so many commits removed? I thought the offending one was 28e4e9eaad1, so everything before that couldn't have stayed in? I asked for the first one prior to montel's first commit according to git log on cgit.kde.org. Might be that I did a

D6175: Fix build with future glibc (major/minor macros), BSD compatible

graesslin added a comment. If I understand correctly this is no longer a change suited for the 5.8 branch. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6175 To: asturmlechner, #plasma Cc: graesslin, plasma-devel, kwin, #kwin, adridg, ZrenBot, spstarr, progwolff,

Why KWin master was hard reset

Hi all, I want to shortly explain why I requested a hard reset of KWin master to undo the override changes. First of all the changes went in without code review. This is not common in the case of KWin. I'm sure the changes were well intended and given that it is uncommon to do a hard

D5994: Force kaccess to run under X

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. normally we do that in the main function prior to creating the QApplication. c.f. kmail or kwin_x11. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D5928: Introducing Night Color - KWin's native blue light filter at nighttime

graesslin added a comment. I wouldn't call it color correction as we used to have a mechanism called color correction in the past which did something very different. Personal suggestion: gamma correction or color temperature correction. Sorry cannot do a full review for the next few

Re: Plasma 5.10 voice over text

Am 2017-05-17 14:03, schrieb Łukasz Sawicki: This explains what it is, it doesn't explain what's changed since the last release. "Folder View is now the default desktop ..." Changed to "Due to the popular demand we changed to Folder View as the default desktop which allows users to put

D5887: Remove pid changedSignal in Client::PlasmaWindow

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R127 KWayland BRANCH asdfasdf REVISION DETAIL https://phabricator.kde.org/D5887 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel,

D5872: pidChanged also signals dataChanged in WindowModel

graesslin added a comment. In https://phabricator.kde.org/D5872#109962, @hein wrote: > I'm fine with no change signal, but heads-up that libtaskmanager has code connecting to it, so if you remove it from kwayland please also adapt plasma-workspace or the build breaks. I highly

D5872: pidChanged also signals dataChanged in WindowModel

graesslin added a comment. like David explained: we don't need the change signal and IMHO we shouldn't expose "wrong API". I consider having a changed signal for a PID wrong API as it indicates that the PID could change. But it won't ever change, so we shouldn't expose it. I know that all

D5756: Set pid on the ClientConnection backing the PlasmaWindow surface.

graesslin added a comment. In https://phabricator.kde.org/D5756#109957, @hein wrote: > What was the regression? (I'm aware of a failing unit test, but since the unit test itself was new, it was obviously not a regression.) The regression is the fact that kwayland was green and

D5851: Fix the PID updated in PlasmaWindowedModel

graesslin added a comment. In https://phabricator.kde.org/D5851#109478, @davidedmundson wrote: > It makes absolutely no sense to have a pidChanged signal and then say clients shouldn't be using it. > > Either window has no reason to have a pidChanged signal or we should connect to

D5851: Fix the PID updated in PlasmaWindowedModel

graesslin added inline comments. INLINE COMMENTS > plasmawindowmodel.cpp:84 > > +QObject::connect(window, ::pidChanged, q, > +[window, this] { this->dataChanged(window, PlasmaWindowModel::Pid); } In the original report I critized that we connect to a pid changed signal. That

D5747: add pid to plasma window management protocol

graesslin reopened this revision. graesslin added a comment. This revision is now accepted and ready to land. Can reproduce the failing test locally. Please fix ASAP! Broken tests is not acceptable in KWayland. This change has been on review so long, I find it quite disappointing that it was

D5756: Set pid on the ClientConnection backing the PlasmaWindow surface.

graesslin added a comment. Please note that I'm going to revert all changes which are built up on a broken API change in KWayland. We need to take quality serious, so if the KWayland regression doesn't get fixed asap I will have to revert everything. REPOSITORY R108 KWin REVISION DETAIL

D5747: add pid to plasma window management protocol

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH sebas/processid REVISION DETAIL https://phabricator.kde.org/D5747 To: sebas, #plasma, hein, graesslin Cc: apol, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr,

D5747: add pid to plasma window management protocol

graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > plasmawindowmodel.cpp:84 > > + > QObject::connect(window, ::activeChanged, q, Unrelated newline > plasma-window-management.xml:263 > + >

D5743: Fix deprecation warnings. setSelection -> setSelectedUrl ui -> uiDelegate

graesslin accepted this revision. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH fix_deprecations (branched from master) REVISION DETAIL https://phabricator.kde.org/D5743 To: markg, davidedmundson, graesslin Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,

D5757: add requestToggleKeepAbove/below

graesslin added a comment. Your tests in plasma window management do not test the new requests. INLINE COMMENTS > test_wayland_windowmanagement.cpp:483 > +using namespace KWayland::Server; > +// this test verifies setting the showing desktop state > +

Re: D4997: Support for long running kcheckpass supporting multiple authentications

Am 2017-05-12 09:18, schrieb Tobias C. Berner: Hi there I think this review introduced some Linux-only features: signalfd() is only present on Linux. So this breaks kcheckpass on FreeBSD (and probably everything non-Linux too). Would it be possible to have the long-running auth stuff hidden

D5488: Improve the escape key handling for breaking constrained pointers

This revision was automatically updated to reflect the committed changes. Closed by commit R108:229be65e4002: Improve the escape key handling for breaking constrained pointers (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D5747: add pid to plasma window management protocol

graesslin added a comment. In https://phabricator.kde.org/D5747#108916, @apol wrote: > Who is going to be setting this pid? Because note that containerized applications don't know their own pid (see kdbusaddons & knotifications patches for big shrug). It's KWin. Who gets the

D5815: Use resourceClass as fallback for XWayland clients instead of resourceName.

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH arcpatch-D5756 REVISION DETAIL https://phabricator.kde.org/D5815 To: hein, #plasma, graesslin Cc: kwin, plasma-devel, #kwin, ZrenBot, spstarr, progwolff, lesliezhai,

D5488: Improve the escape key handling for breaking constrained pointers

graesslin updated this revision to Diff 14413. graesslin added a comment. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. Fixes REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D5757: add requestToggleKeepAbove/below

graesslin added a comment. In https://phabricator.kde.org/D5757#108706, @hein wrote: > Martin, did you mix things up here maybe? The patch has changes to autotests/client/test_wayland_windowmanagement.cpp. The "newRow" bit isn't related to QAIM. It's a row of test data. no, I

D5757: add requestToggleKeepAbove/below

graesslin added a comment. Forget my last two comments - confused the review REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,

D5747: add pid to plasma window management protocol

graesslin added inline comments. INLINE COMMENTS > test_plasma_window_model.cpp:215 > > void PlasmaWindowModelTest::testRoleNames_data() > { Please extend this REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5747 To: sebas, #plasma, hein, graesslin Cc:

D5757: add requestToggleKeepAbove/below

graesslin added inline comments. INLINE COMMENTS > test_plasma_window_model.cpp:214 > > void PlasmaWindowModelTest::testRoleNames_data() > { Please extend this > test_plasma_window_model.cpp:306 > > void PlasmaWindowModelTest::testDefaultData_data() > { Please extend this REPOSITORY

D5747: add pid to plasma window management protocol

graesslin added inline comments. INLINE COMMENTS > plasmawindowmodel.cpp:84-86 > +QObject::connect(window, ::pidChanged, q, > +[window, this] { this->dataChanged(window, PlasmaWindowModel::Pid); } > +); I consider it as impossible that the PID changes. REPOSITORY R127

D5801: Split XDGTest to allow testing both V5 and V6

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Are you sure the API is so compatible that you can run it like that? REPOSITORY R127 KWayland BRANCH davidedmundson/xdgv6 REVISION DETAIL https://phabricator.kde.org/D5801

D5488: Improve the escape key handling for breaking constrained pointers

graesslin planned changes to this revision. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5488 To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, lukas

D5795: List both setup and monitor UUIDs in debug

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH xdgv6 REVISION DETAIL https://phabricator.kde.org/D5795 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, lesliezhai,

D5757: add requestToggleKeepAbove/below

graesslin requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr,

D5757: add requestToggleKeepAbove/below

graesslin added a comment. In https://phabricator.kde.org/D5757#108115, @mart wrote: > In https://phabricator.kde.org/D5757#108070, @graesslin wrote: > > > Please also extend the test in autotests/client/test_wayland_windowmanagement.cpp > > > isn't it covered by no,

D5758: wire up requestToggleKeepAbove/below

graesslin accepted this revision. graesslin added a comment. As it depends on newer frameworks: commit embargo till 5.10 is branched. REPOSITORY R120 Plasma Workspace BRANCH phab/abovebelow REVISION DETAIL https://phabricator.kde.org/D5758 To: mart, #plasma, hein, graesslin Cc:

D5755: Expose PlasmaWindow::pid through WaylandTasksModel.

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Obviously commit embargo till 5.10 is branched is still in place. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D5755 To: hein,

D5757: add requestToggleKeepAbove/below

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Please also extend the test in autotests/client/test_wayland_windowmanagement.cpp REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart,

D5746: Move code on wayland surface being created.

graesslin accepted this revision. graesslin added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kwaylandintegration.cpp:157 > + > +#include "kwaylandintegration.moc" Just wondering: why is the moc file needed now? REPOSITORY R135 Integration for Qt

D5756: Set pid on the ClientConnection backing the PlasmaWindow surface.

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D5756 To: hein, #plasma, sebas, graesslin Cc: kwin, plasma-devel, #kwin, ZrenBot, spstarr, progwolff, lesliezhai,

D5746: Move code on wayland surface being created.

graesslin added inline comments. INLINE COMMENTS > kwaylandintegration.cpp:42 > > +static bool s_useQt58Workaround; > + I don't really like the name of the variable as it's going to be the future way and not "a workaround" once we depend on Qt 5.8 or later. REPOSITORY R135 Integration for

D5756: Set pid on the ClientConnection backing the PlasmaWindow surface.

graesslin added a comment. Please note that the code you wrote will give you an incorrect PID for all XWayland windows. Instead of going through the ClientConnection I suggest to use KWin::Toplevel::pid(). That one returns the correct pid for all X windows. But it would crash for Wayland

D5755: Expose PlasmaWindow::pid through WaylandTasksModel.

graesslin added a comment. Commit embargo till 5.10 is branched. INLINE COMMENTS > waylandtasksmodel.cpp:340 > } else if (role == AppPid) { > -// FIXME Implement. > +return window->pid(); > } You are aware that pid is not always correct? Any process started by KWin

D5756: Set pid on the ClientConnection backing the PlasmaWindow surface.

graesslin added a comment. This has commit embargo till 5.10 is branched. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5756 To: hein, #plasma, sebas, graesslin Cc: kwin, plasma-devel, #kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening,

D5756: Set pid on the ClientConnection backing the PlasmaWindow surface.

graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > abstract_client.cpp:708 > updateAppId(); > -w->setSkipTaskbar(skipTaskbar()); > +w->setPid(surface()->client()->processId()); > +

D5748: workaround for correct wayland positioning

graesslin added a comment. I assume this are adjustments for Qt 5.8 or later. How does this work with Qt 5.7? I fear if we change like this we are going to break Qt 5.7. INLINE COMMENTS > view.cpp:217 > { > +qWarning()< // QXcbWindow overwrites the state in its show

D5747: add pid to plasma window management protocol

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Please also extend the autotests/client/test_wayland_windowmanagement.cpp INLINE COMMENTS > plasmawindowmanagement.h:385 > + * @returns The process id this window

D5538: Implement QPlatformTheme::fileIconPixmap()

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Please fix the style issues. INLINE COMMENTS > kdeplatformtheme.cpp:124-125 > +#if QT_VERSION < QT_VERSION_CHECK(5, 8, 0) > +QPixmap KdePlatformTheme::fileIconPixmap(const

D5733: Keep all touchpad QActions in the main thread

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D5733 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff,

<    8   9   10   11   12   13   14   >