Re: Review Request 127285: use QDBusConnectionInterface::serviceOwnerChanged to watch mpris2 service

2016-03-09 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127285/#review93360 --- Ship it! Ship It! - Martin Klapetek On March 5, 2016

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Martin Klapetek
ng to maintain the code as part of plasma-the-code while Yuri probably thought this is about removing it from plasma-the-shell, ie. from kicker/kickoff etc. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: VDG approved widgets

2016-03-08 Thread Martin Klapetek
and I'm the > maintainer, it's not that easy. (I work at an company something like TÜV) > Kai was suggesting in his email an entry in the applet's .desktop file. That was what I was reacting to with my reply. This has nothing to do with

Re: VDG approved widgets

2016-03-08 Thread Martin Klapetek
ng like an Usability and Design review at the > widget with an brand and hopefully some external plasmoid dev's (GHNS) will > also come to the VDG to get an aproval. > No, what I mean was that what Kai was suggesting can be fabricated super easily, making things look like they got V

Re: VDG approved widgets

2016-03-08 Thread Martin Klapetek
On Tue, Mar 8, 2016 at 4:55 PM, Kai Uwe Broulik wrote: > Hi, > > I like that! > > X-Plasma-VDG-Approved=true :) > On the other hand, that does not really prevent /all/ the widgets to be VDG approved without the VDG approval :) Cheers -- Martin Klapet

Re: VDG approved widgets

2016-03-08 Thread Martin Klapetek
just a badge on the icon? Or does the applet export that in the .desktop file? Or something else entirely? Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

2016-03-01 Thread Martin Klapetek
, while minimum requirement is "2.8.12". Can you perhaps change the cmake module to not use pkg_get_variable for now? - Martin Klapetek On Feb. 14, 2016, 1:09 p.m., Pino Toscano wrote: > > --- > This is an automatically g

Re: Review Request 127159: Make the KPeople qml example slightly more usable

2016-02-24 Thread Martin Klapetek
marked as submitted. Review request for KDE Frameworks, KDEPIM and Plasma. Changes --- Submitted with commit 6ef69a8a17985926ad89543ba932f835d455cec8 by Martin Klapetek to branch master. Repository: kpeople Description --- I've done this quite some time ago but noticed only

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-24 Thread Martin Klapetek
> On Feb. 24, 2016, 11:34 a.m., Lars Pontoppidan wrote: > > Ship It! > > Marco Martin wrote: > you can do the actual merge now, you still have to do it via git. > > Lars Pontoppidan wrote: > I've done my best - it's in master now :) - Thanks > > Marco Martin wrote: > i closed the r

Review Request 127159: Make the KPeople qml example slightly more usable

2016-02-23 Thread Martin Klapetek
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/23/cfcc2a9e-bc54-4031-85a6-9368f70f8056__snapshot96.png After https://git.reviewboard.kde.org/media/uploaded/files/2016/02/23/e87bd7e0-9420-4ac4-919a-8a78cd7abc26__snapshot95.png Thanks, Martin Kla

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

2016-02-23 Thread Martin Klapetek
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/#review92660 --- On Nov. 18, 2015, 1:33 a.m., Martin Klapetek wrote: > > -

Re: kdereview: breeze-grub & breeze-plymouth

2016-02-19 Thread Martin Klapetek
design stuff had a new name you only have to be carefull to > maintain everything. > > my name suggestion would be mailüfterl ( > https://en.m.wikipedia.org/wiki/Mail%C3%BCfterl) > Yeah, maybe something more like what the 98% of the world can pronounce :P Cheers -- Martin Klapetek | KDE

Re: kdereview: breeze-grub & breeze-plymouth

2016-02-19 Thread Martin Klapetek
nt bar with that tiny line near the bottom). Should this whole set of design be named something else while the old ones are kept (somewhere) as "breeze"? Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-18 Thread Martin Klapetek
r all fonts, this loop really > needs to go > > Daniel Faust wrote: > As far as I understand maximumCharacterWidth returns the width of the > widest character of the font - which can be ridiculously wide given that the > font supports some wild unicode characters. >

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-18 Thread Martin Klapetek
> On Feb. 18, 2016, 1:05 a.m., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127035: Show Frameworks version next to Qt Version

2016-02-10 Thread Martin Klapetek
;) - Martin Klapetek On Feb. 10, 2016, 11:31 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127032: Add Frameworks version to system information in bug report

2016-02-10 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127032/#review92236 --- Ship it! - Martin Klapetek On Feb. 10, 2016, 6:09 p.m

Re: Review Request 127011: Don't list twice KIO in find_package

2016-02-08 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127011/#review92170 --- Ship it! Ship It! - Martin Klapetek On Feb. 8, 2016, 4

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Martin Klapetek
anges? - Martin Klapetek On Feb. 5, 2016, 12:19 a.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

[Differential] [Accepted] D901: [KRunner] Use time-based sorting rather than length for auto-completion

2016-02-04 Thread mck182 (Martin Klapetek)
mck182 accepted this revision. mck182 added a comment. This revision is now accepted and ready to land. Well that was easy :) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D901 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Closed] D899: [notifications] Make the text selectable in the popup too

2016-02-04 Thread mck182 (Martin Klapetek)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE4819282d329f: [notifications] Make the text selectable in the popup too (authored by mck182). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.

[Differential] [Updated, 128 lines] D899: [notifications] Make the text selectable in the popup too

2016-02-04 Thread mck182 (Martin Klapetek)
mck182 updated this revision to Diff 2192. mck182 added a comment. Keep the MouseArea visible always as it pushes the action buttons to the side REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D899?vs=2190&id=2192 BRANCH mklapetek/sele

[Differential] [Updated] D899: [notifications] Make the text selectable in the popup too

2016-02-04 Thread mck182 (Martin Klapetek)
mck182 added a reviewer: Plasma. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D899 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mck182, Plasma Cc: plasma-devel ___

[Differential] [Request, 128 lines] D899: [notifications] Make the text selectable in the popup too

2016-02-04 Thread mck182 (Martin Klapetek)
mck182 created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This simplifies the component by removing the Loader-property combo and leaves just a read-only TextEdit BUG: 358981 REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRA

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread Martin Klapetek
> On Feb. 4, 2016, 3:26 p.m., Martin Klapetek wrote: > > FYI, This may not entirely work as > > https://bugs.kde.org/show_bug.cgi?id=358869 shows > > David Edmundson wrote: > ack, there's a new message that we're not catching. > > I don&

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread Martin Klapetek
/show_bug.cgi?id=358869 shows - Martin Klapetek On Aug. 1, 2015, 2:08 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126092: Konqui based Emotion pack named eKspression

2016-02-03 Thread Martin Klapetek
/view/raw/39a38ece I think the face-smile-big could still use a bit more "smily" mouth (it looks like it's about to eat something big). Other than that, I think it looks great! It's a ship it from me. Good work! - Martin Klapetek On Jan. 28, 2016, 11:21 p.m.,

Re: Plasma Bugs - a stricter approach

2016-02-03 Thread Martin Klapetek
me, let's please not make this about the numbers. I regularly see bugs closed as wrong duplicates, which in the end does not help the user at all, it only helps to keep our bug count down. Let's try to raise the quality of our handling too, not only quantity. Cheers -- M

[Powerdevil] [Bug 349750] Laptop does not suspend when lid closed in lock screen

2016-02-03 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=349750 --- Comment #7 from Martin Klapetek --- Does not happen for me anymore. Niall - what's your plasma version? -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-

Re: RFC: plasma logo as start menu icon and ksplash logo

2016-02-03 Thread Martin Klapetek
On Wed, Feb 3, 2016 at 12:16 PM, Ivan Čukić wrote: > > @Offtopic: What happened to kde.org revamp? > >From what I understood, the neon website is supposed to be a proving ground for the new kde.org. Cheers -- Martin Klapetek | K

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek
On Feb. 1, 2016, 8:30 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126949/ > --- &g

Re: Review Request 126956: [Desktop Containment] Remove custom tooltip delegate

2016-02-01 Thread Martin Klapetek
back in 8 days, I guess we should wait for his input on why this is needed. - Martin Klapetek On Feb. 1, 2016, 10:23 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Martin Klapetek
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126949/#review91883 --- On Feb. 1, 2016, 8:30 p.m., Martin Klapetek wrote: > > -

Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Martin Klapetek
dgets/translucentbackground.svgz 47b418d src/desktoptheme/oxygen/widgets/viewitem.svgz cec433e Diff: https://git.reviewboard.kde.org/r/126949/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/ma

Re: Review Request 126950: Fix kicker userExtraRunners

2016-02-01 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126950/#review91894 --- Ship it! Ship It! - Martin Klapetek On Feb. 1, 2016, 8

Re: Review Request 126954: [Notifications] Fix Job finished persistency

2016-02-01 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126954/#review91890 --- Ship it! Thanks - Martin Klapetek On Feb. 1, 2016, 9

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Martin Klapetek
To reply, visit: https://git.reviewboard.kde.org/r/126949/#review91874 ------- On Feb. 1, 2016, 8:30 p.m., Martin Klapetek wrote: > > --- > This is an automatical

Re: Performance issue with plasmoid and dataengine combination

2016-01-29 Thread Martin Klapetek
it will give some interesting information on where it is stuck. If you don't have plasma built from source, then make sure you install debug packages for plasma-framework and at least plasma-workspace. And also Qt. Cheers -- Martin Klapetek | KDE Developer __

Re: Review Request 126907: [klipper] Remove "Don't ask again" on clear clipboard history

2016-01-27 Thread Martin Klapetek
> On Jan. 27, 2016, 4:55 p.m., Thomas Pfeiffer wrote: > > So, the situation is not that special: We ask for confirmation to err on > > the side of caution (which makes sense since there is no going back) but > > don't want to bother users with dialogs they don't care about. In fact, the > > si

[plasmashell] [Bug 328593] Dual screen has regressed in plasma-shell

2016-01-26 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=328593 Martin Klapetek changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution

[plasmashell] [Bug 358578] Active window taskbar entry background too bright in Breeze Dark theme

2016-01-26 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358578 Martin Klapetek changed: What|Removed |Added Component|general |Theme - Breeze Target Milestone

[Breeze] [Bug 358578] Active window taskbar entry background too bright in Breeze Dark theme

2016-01-26 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358578 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org --- Comment #2 from Martin

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/#review91599 --- Ship it! Looks good to me, thanks! - Martin Klapetek

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

2016-01-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126879/#review91586 --- Ship it! Looks good, thanks! - Martin Klapetek On Jan

Re: PSA: KAccounts now requires two env vars set

2016-01-20 Thread Martin Klapetek
on't need to bother packagers to figure out how to make it > work. > Yeah, that could be done. I'll have a look. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 358271] Some comboboxes are missing shadows and are hard to click

2016-01-20 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358271 --- Comment #1 from Martin Klapetek --- Created attachment 96757 --> https://bugs.kde.org/attachment.cgi?id=96757&action=edit Screenshot Thanks for the report Reattaching the screenshot here; for future reference, always please attach scre

[Breeze] [Bug 358271] Some comboboxes are missing shadows and are hard to click

2016-01-20 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358271 Martin Klapetek changed: What|Removed |Added Summary|Some selectboxes are|Some comboboxes are missing

Re: KDE papercuts love

2016-01-20 Thread Martin Klapetek
controls look somewhat broken and many icons are actually missing. I propose just removing them and encouraging people to take it over and put at kde-look.org. Better to not ship at all than broken like that imo. Cheers -- Martin Klapetek | KDE Developer __

PSA: KAccounts now requires two env vars set

2016-01-18 Thread Martin Klapetek
will affect the Applications 16.04 release. [1] - https://bugs.kde.org/show_bug.cgi?id=347219 Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-14 Thread Martin Klapetek
> On Jan. 14, 2016, 7:22 p.m., Martin Klapetek wrote: > > It should probably still show when you get disconnected and *not* > > reconnected (to any network) on resume? > > Kai Uwe Broulik wrote: > Doesn't it tell you that anyway? At least when I try to connect

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-14 Thread Martin Klapetek
*not* reconnected (to any network) on resume? - Martin Klapetek On Jan. 14, 2016, 7:19 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126689: Change minimum Size of Calendar

2016-01-13 Thread Martin Klapetek
pplet switching. Marco? - Martin Klapetek On Jan. 11, 2016, 12:41 a.m., andreas kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 126689: Change minimum Size of Calendar

2016-01-13 Thread Martin Klapetek
> On Jan. 13, 2016, 9:04 p.m., andreas kainz wrote: > > any feedback. as you see in the screenshot it works now on the desktop, the > > panel and on a sidebar panel Ah yes, sorry, my system is currently in a bit broken state, let me try to fix it now and get back asap. - Martin ---

Re: Review Request 126727: [plasmaquick/dialog] Don't use KWindowEffects for Notification window type

2016-01-13 Thread Martin Klapetek
marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 311cde3ba5d884da15905096732b9cb8eba2bedd by Martin Klapetek to branch master. Repository: plasma-framework Description --- [plasmaquick/dialog] Don't use KWindowEffect

Re: Review Request 126668: [notifications] Place the popup directly when it is displayed

2016-01-13 Thread Martin Klapetek
marked as submitted. Review request for Plasma. Changes --- Submitted with commit c1a7d61fbab7620f9f92f25ae82e96b9bf3a589c by Martin Klapetek to branch Plasma/5.5. Repository: plasma-workspace Description --- Now with the geometry being correct right after the popup is being

Review Request 126727: [plasmaquick/dialog] Don't use KWindowEffects for Notification window type

2016-01-12 Thread Martin Klapetek
-framework Description --- [plasmaquick/dialog] Don't use KWindowEffects for Notification window type Diffs - src/plasmaquick/dialog.cpp 8f4ee57435949256e319ff6a4534163f2db73bd8 Diff: https://git.reviewboard.kde.org/r/126727/diff/ Testing --- Thanks, Martin Kla

Re: Review Request 126689: Change minimum Size of Calendar

2016-01-10 Thread Martin Klapetek
> On Jan. 10, 2016, 11:10 p.m., Martin Klapetek wrote: > > This actually doesn't do anything because the parent item has > > > > Plasmoid.switchWidth: units.gridUnit * 12 > > Plasmoid.switchHeight: units.gridUnit * 12 > > > > ...so it w

Re: Review Request 126689: Change minimum Size of Calendar

2016-01-10 Thread Martin Klapetek
w/raw/72636384 - Martin Klapetek On Jan. 10, 2016, 8:56 p.m., andreas kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 126658: Notifications again not works correctly [revert parch 126408]

2016-01-08 Thread Martin Klapetek
> On Jan. 7, 2016, 4:36 a.m., Martin Klapetek wrote: > > No. > > > > I'm fine with disabling the first animation. Post a separate patch > > for that and that only. > > > > Any configuration issues that are left need to be identified > > and fi

Re: KDE Discover binary & library names

2016-01-08 Thread Martin Klapetek
On Fri, Jan 8, 2016 at 9:41 AM, Aleix Pol wrote: > > Should we rename it to "plasma-discover" then? > > Some +1 from Plasma maintainers? :D > +1 Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list P

Re: Review Request 126669: [Task Manager] Don't show on which virtual desktop a window is if there is just one

2016-01-07 Thread Martin Klapetek
, I see "Available on all activities" but have only one) - Martin Klapetek On Jan. 7, 2016, 11 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 126668: [notifications] Place the popup directly when it is displayed

2016-01-07 Thread Martin Klapetek
SACRIFICE 2 MINUTES TO APPLY THIS PATCH AND TRY IT Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126668: [notifications] Place the popup directly when it is displayed

2016-01-07 Thread Martin Klapetek
Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126658: Notifications again not works correctly [revert parch 126408]

2016-01-06 Thread Martin Klapetek
> On Jan. 7, 2016, 4:36 a.m., Martin Klapetek wrote: > > No. > > > > I'm fine with disabling the first animation. Post a separate patch > > for that and that only. > > > > Any configuration issues that are left need to be identified > > and fi

Re: Review Request 126658: Notifications again not works correctly [revert parch 126408]

2016-01-06 Thread Martin Klapetek
> On Jan. 7, 2016, 4:36 a.m., Martin Klapetek wrote: > > No. > > > > I'm fine with disabling the first animation. Post a separate patch > > for that and that only. > > > > Any configuration issues that are left need to be identified > > and fi

Re: Review Request 126658: Notifications again not works correctly

2016-01-06 Thread Martin Klapetek
ost a separate patch for that and that only. Any configuration issues that are left need to be identified and fixed, not by reverting and moving things back again. - Martin Klapetek On Jan. 7, 2016, 4:30 a.m., Anthony Fieroni wrote: > > ---

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-05 Thread Martin Klapetek
stead (if available on the mpris). That would at least give some useful/nice info. Plus the music players are usually minimized anyway (breaking the thumbnails). Thoughts? - Martin Klapetek On Jan. 5, 2016, 9:45 p.m., Kai Uwe Broulik

Request for delaying Plasma 5.5.2 by a day

2016-01-04 Thread Martin Klapetek
pdate your plasma-workspace, restart plasmashell and watch for notifications acting up. If all is well, 5.5.2 can be released as is. If there are troubles, I'll revert and postpone to 5.5.3. [1] - https://git.reviewboard.kde.org/r/126408/ Cheers -- Martin Klapetek

Re: Review Request 126408: [notifications] Refactor the screen handling code

2016-01-04 Thread Martin Klapetek
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 0c6b354b7e22297544f1d37608d6fdcd777c4d52 by Martin Klapetek to branch Plasma/5.5. Repository: plasma-workspace Description --- If anybody with multi-screen setup could test this, that'd be

Re: Review Request 126381: kwayland backend for libkscreen

2016-01-04 Thread Martin Klapetek
> On Dec. 24, 2015, 9:23 p.m., Hrvoje Senjan wrote: > > backends/CMakeLists.txt, line 3 > > > > > > Either this should be guarded by KF5Wayland_FOUND, or KF5Wayland should > > be marked as required in top CMakeLis

Re: Review Request 124047: Improve clock's tooltip layout

2016-01-04 Thread Martin Klapetek
marked as submitted. Review request for Plasma. Changes --- Submitted with commit f5297033c4a0fba416b971f2bdbcb04c56858947 by Martin Klapetek to branch master. Bugs: 348078 https://bugs.kde.org/show_bug.cgi?id=348078 Repository: plasma-workspace Description --- In kde4 times

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2016-01-04 Thread Martin Klapetek
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 6e0d0c49a3cf5881757b57f55c60033efd6cb3d1 by Martin Klapetek to branch master. Repository: plasma-desktop Description --- This is a part 2 patch for https://git.reviewboard.kde.org/r/126463/ This

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2016-01-04 Thread Martin Klapetek
f9c29a5 Diff: https://git.reviewboard.kde.org/r/126464/diff/ Testing --- All works as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126460: Honor SkipGrouping hint from KNotification

2016-01-04 Thread Martin Klapetek
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 81c74b1efbb8a694335c79fecb7a83f3168b0b29 by Martin Klapetek to branch master. Repository: plasma-workspace Description --- https://git.reviewboard.kde.org/r/126459/ introduced new flag that allows to

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2016-01-04 Thread Martin Klapetek
isit: https://git.reviewboard.kde.org/r/126464/#review89866 ------- On Dec. 21, 2015, 11:12 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated

Re: Review Request 126463: Allow applets to set full ToolTip item

2016-01-04 Thread Martin Klapetek
marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 3992593f31681254fb5fa9bafcaa47e18fc19421 by Martin Klapetek to branch master. Repository: plasma-framework Description --- Adds new property available as Plasmoid.toolTipItem that

Re: Review Request 126408: [notifications] Refactor the screen handling code

2016-01-04 Thread Martin Klapetek
d try is running a nested kwin_wayland with multiple outputs > > and start plasmashell there. That should help you simulating multi-screen. > > Martin Klapetek wrote: > You still could test it and see if it does not cause any regressions > (which it shouldn't). > &

Re: Review Request 126597: Notificatioins rework

2016-01-03 Thread Martin Klapetek
with the checkbox is good. Finally, your patch actually puts the popup over my panel. --- tl;dr - r126408 needs to go in, then we can break your patch down to smaller patches and apply what is still relevant. - Martin Klapetek On Jan. 2, 2016, 2:26 p.

Re: Review Request 126597: Notificatioins rework

2016-01-02 Thread Martin Klapetek
://git.reviewboard.kde.org/r/126408/ I will review your code on Monday. - Martin Klapetek On Jan. 2, 2016, 2:26 p.m., Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: Review Request 124047: Improve clock's tooltip layout

2015-12-31 Thread Martin Klapetek
.technically anyway. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/#review90384 --- On Dec. 31, 2015, 9

Re: Review Request 124047: Improve clock's tooltip layout

2015-12-31 Thread Martin Klapetek
- See screenshots. File Attachments Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/12/22/b51c1559-8f2c-42bc-8eb6-203ef3d53637__snapshot69.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Pl

Re: Review Request 124047: Improve clock's tooltip layout

2015-12-31 Thread Martin Klapetek
> On Dec. 22, 2015, 10:53 p.m., Kai Uwe Broulik wrote: > > It still does not shrink if timezones are removed. > > > > Otherwise looking good. > > Martin Klapetek wrote: > Tips for the shrinking issue? Ok found the issue; it was because I was setting a Loa

Re: Review Request 126463: Allow applets to set full ToolTip item

2015-12-31 Thread Martin Klapetek
5 Diff: https://git.reviewboard.kde.org/r/126463/diff/ Testing --- I can have custom tooltip item in digital clock without any artifacts while all other applets still have correct tooltips. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-deve

Re: Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

2015-12-30 Thread Martin Klapetek
lik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126570/ > --- > > (Updated Dec. 29, 2015, 11:55 p.m.) > > > Review request for Plasma, KDE Usability

Re: Review Request 126566: Add "applicationcrash" notification event

2015-12-29 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126566/#review90308 --- Ship it! Ship It! - Martin Klapetek On Dec. 29, 2015, 10

Re: Review Request 126461: Use the SkipGrouping flag for the "widget deleted" notification

2015-12-29 Thread Martin Klapetek
marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit f639996becc2fae284d9c83273856dee510b699d by Martin Klapetek to branch master. Bugs: 356653 http://bugs.kde.org/show_bug.cgi?id=356653 Repository: plasma-framework Description

Re: Review Request 126460: Honor SkipGrouping hint from KNotification

2015-12-29 Thread Martin Klapetek
it: https://git.reviewboard.kde.org/r/126460/#review89856 --- On Dec. 21, 2015, 9:24 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 124047: Improve clock's tooltip layout

2015-12-29 Thread Martin Klapetek
generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/#review89950 --- On Dec. 22, 2015, 8:38 p.m., Martin Klapetek wrote: > > --- > This is an automatica

Re: Review Request 126092: Konqui based Emotion pack named eKspression

2015-12-29 Thread Martin Klapetek
icons as in the first round. - Martin Klapetek On Dec. 23, 2015, 9:05 p.m., andreas kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-12-29 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #83 from Martin Klapetek --- Can you check if you have 2 kded5 processes running? Your backtrace again shows no activity at all. That said, please compare the backtrace with the previous ones before you upload a new one, there's no

Re: Review Request 126498: Use the right graphics for min and max sliders

2015-12-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126498/#review90042 --- Ship it! Ship It! - Martin Klapetek On Dec. 24, 2015, 2

Re: Review Request 126499: Add explanatory message why layout combo is disabled whilst widgets are locked

2015-12-23 Thread Martin Klapetek
-KMessageWidget (do we have a component for that already?) - Martin Klapetek On Dec. 24, 2015, 2:43 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 124047: Improve clock's tooltip layout

2015-12-22 Thread Martin Klapetek
925 Diff: https://git.reviewboard.kde.org/r/124047/diff/ Testing --- See screenshots. File Attachments Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/12/22/b51c1559-8f2c-42bc-8eb6-203ef3d53637__snapshot69.png Thanks, Marti

Re: Review Request 124047: Improve clock's tooltip layout

2015-12-22 Thread Martin Klapetek
Testing --- See screenshots. File Attachments (updated) Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/12/22/b51c1559-8f2c-42bc-8eb6-203ef3d53637__snapshot69.png Thanks, Martin Klapetek ___ Plasma-devel maili

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2015-12-22 Thread Martin Klapetek
rg/r/126464/#review89910 --- On Dec. 21, 2015, 11:12 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

<    1   2   3   4   5   6   7   8   9   10   >