D14493: fontinst quits after KJob is done

mathiastillman created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mathiastillman requested review of this revision. REVISION SUMMARY As the summary says, when installing/removing multiple fonts to system the expected b

D14493: fontinst quits after KJob is done

mathiastillman added a comment. It does indeed fix both of those bugs. I have added that in the summary now, sorry about that. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14493 To: mathiastillman, #plasma Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot

D14493: fontinst quits after KJob is done

mathiastillman added a comment. Okay, that makes sense. kfontinst doesn't actually display a UI at all, instead it just receives dbus commands from kcm - so there is no real GUI class, it just uses QCoreApplication. I could add a QEventLoopLocker to KFI::FontInst though, but, from reading th

D14493: fontinst quits after KJob is done

mathiastillman updated this revision to Diff 38831. mathiastillman added a comment. Use a QEventLoopLocker instead of completely disabling the quit lock functionality. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14493?vs=38795&id=38831 REVISION

D14493: fontinst quits after KJob is done

mathiastillman added a comment. Well, it's sort of a daemon, but it doesn't run until the user logs out - there's a built-in timeout of 30 seconds that will check for any connected clients and if none are found it will kill itself. The KCM communicates with the fontinst daemon via dbus :) R

D14493: fontinst quits after KJob is done

mathiastillman updated this revision to Diff 38832. mathiastillman added a comment. Grammatical fixes ;) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14493?vs=38831&id=38832 REVISION DETAIL https://phabricator.kde.org/D14493 AFFECTED FILES kc

D14493: fontinst quits after KJob is done

mathiastillman marked an inline comment as done. mathiastillman added a comment. Either one is fine by me as well, so pick whichever one you fancy :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14493 To: mathiastillman, #plasma, dfaure, aacid, gateau Cc: w

D14493: fontinst quits after KJob is done

mathiastillman closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14493 To: mathiastillman, #plasma, dfaure, aacid, gateau Cc: wbauer, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D14493: fontinst quits after KJob is done

mathiastillman added a comment. It would indeed, but I will wait for input before pushing it as I'm not entirely sure how it's decided what release a patch goes in to. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14493 To: mathiastillman, #plasma, dfaure,

D14493: fontinst quits after KJob is done

mathiastillman added a comment. Okay, so should I wait for someone else to reply before committing it to the 5.12 and 5.13 branches? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14493 To: mathiastillman, #plasma, dfaure, aacid, gateau Cc: wbauer, ngraham,

D19002: Fix window thumbnails not working since frameworks 5.55

mathiastillman created this revision. mathiastillman added a reviewer: mvourlakos. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mathiastillman requested review of this revision. REVISION SUMMARY This fixes a problem where window thumbnails are no longer visible since

D19003: Update visibility of mainItem of the window thumbnail since this is no longer done automatically in KDE Frameworks 5.55.

mathiastillman created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mathiastillman requested review of this revision. REPOSITORY R878 Latte Dock BRANCH master REVISION DETAIL https://phabricator.kde.org/D19003 AFFECTED FILES plasmoid/package/co

D19002: Fix window thumbnails not working since frameworks 5.55

mathiastillman closed this revision. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D19002 To: mathiastillman, mvourlakos Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20774: Import QtGraphicalEffects 1.0 instead of 1.2 to fix dependency issue.

mathiastillman created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mathiastillman requested review of this revision. REVISION SUMMARY Fixes an issue where the shell plasmoid fails to load when QtGraphicalEffects 1.2 is missing from the system. This ca

D20774: Import QtGraphicalEffects 1.0 instead of 1.2 to fix dependency issue.

This revision was automatically updated to reflect the committed changes. Closed by commit R878:99454c0b15ba: Import QtGraphicalEffects 1.0 instead of 1.2 to fix dependency issue. (authored by mathiastillman). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D