Panel icon sizing bug in 4.4

2010-05-23 Thread Mike Kasick
Hi folks, This issue was first raised on the KDE community forums [1], for which my reply is fifth in the thread. It was recommended that I post the issue here. There appears to be a bug, or at least a change in behavior for panel icon sizing in KDE 4.4 (specifically Debian 4.4.3-2). In previou

Re: Panel icon sizing bug in 4.4

2010-05-23 Thread Mike Kasick
On Sun, May 23, 2010 at 10:28:00AM -0700, Chani wrote: > one of the bug reports mentioned that KDE's default icon size should be > respected, although it's not clear whether that was implemented. It wasn't. > if that setting is not followed, then you have found a bug, and patches > are welcome.

Re: Panel icon sizing bug in 4.4

2010-05-24 Thread Mike Kasick
On Mon, May 24, 2010 at 10:56:53AM +0200, Marco Martin wrote: > What should be modified i think is the size hint of the Icon applet, in > workspace, that is explicitly used here > and should have a sizehint of Panel in vertical/horizontal formfactors and > Desktop in Planar OK. Attached is a p

Re: Panel icon sizing bug in 4.4

2010-05-25 Thread Mike Kasick
On Tue, May 25, 2010 at 10:20:46AM -0700, Aaron J. Seigo wrote: > kickoff is a popup applet should be handled by PopupApplet and so shouldn't > be > patched for this. The "new-style" kickoff is indeed, I don't think the patches touch the regular LauncherApplet. The "old-style" kickoff (better

Re: Panel icon sizing bug in 4.4

2010-06-01 Thread Mike Kasick
On Tue, May 25, 2010 at 12:38:44PM -0700, Aaron J. Seigo wrote: > there was one commit per set of files changed; so one for PopupApplet in > libplasma, one for kickoff, one for lancelot (iirc?) and one for the control > panel. I tested these out, they work great! One more issue: the "simple" A

Re: Panel icon sizing bug in 4.4

2010-06-03 Thread Mike Kasick
On Tue, May 25, 2010 at 12:38:44PM -0700, Aaron J. Seigo wrote: > > Is there a chance this will make it into 4.4.4? If not, I might want to > > i highly doubt it, sorry :( Thanks for your effors in getting this into trunk. The latest revisions (with MenuLauncherApplet::sizeHint defined const)

Re: Panel icon sizing bug in 4.4

2010-06-07 Thread Mike Kasick
On Thu, Jun 03, 2010 at 07:50:24PM -0400, Mike Kasick wrote: > I've gone through SVN and cherry-picked the patches for each applet and > backported them to the KDE 4.4 SVN branch--keeping just the changes > relevant to iconSizeChanged/sizeHint as well as setting of the Panel