D26499: remove an unused header

2020-06-12 Thread Miklós Máté
miklosm added a reviewer: Plasma: Workspaces. miklosm added a comment. Can I get a review on this? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26499 To: miklosm, #plasma_workspaces Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D26499: remove an unused header

2020-01-07 Thread Miklós Máté
miklosm created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. miklosm requested review of this revision. REVISION SUMMARY It was imported from libksysguard, but I don't know why. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

2018-06-08 Thread Miklós Máté
miklosm added a comment. BTW the updateInterval, which caused the conflict, is not as useful as it sounds, because the data source sends new data at a fixed 1Hz frequency. REVISION DETAIL https://phabricator.kde.org/D12857 To: miklosm, #plasma, mart Cc: ngraham, mart, plasma-devel,

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

2018-06-08 Thread Miklós Máté
miklosm updated this revision to Diff 35855. miklosm added a comment. Rebased on current master CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12857?vs=34080=35855 REVISION DETAIL https://phabricator.kde.org/D12857 AFFECTED FILES

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

2018-06-06 Thread Miklós Máté
miklosm added a comment. In D12857#274212 , @ngraham wrote: > Do you need someone to land this for you, Miklós? Yes, please. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12857 To: miklosm, #plasma,

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

2018-06-04 Thread Miklós Máté
miklosm added a comment. In D12857#273608 , @ngraham wrote: > Screenshot please! See https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots Screenshots of how the network monitor looks like on a vertical panel:

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

2018-06-04 Thread Miklós Máté
miklosm added inline comments. INLINE COMMENTS > mart wrote in cpu.qml:45 > CPU usage should be removed from the context as this is now used for > different things? It's used for the same things as before. The only change is that this function no longer formats the whole label, just returns

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

2018-05-13 Thread Miklós Máté
miklosm created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. miklosm requested review of this revision. REVISION SUMMARY When the applet is on a vertical panel, its horizontal size is limited, and the speedLabel clashes

D12853: Calendar widget: fix resize

2018-05-13 Thread Miklós Máté
miklosm created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. miklosm requested review of this revision. REVISION SUMMARY If the fullRepresentation has a minimum size, the applet cannot be shrinked back to show the

Re: Review Request 129308: Calendar: clear selection on opening

2016-12-14 Thread Miklós Máté
marked as submitted. Review request for Plasma. Changes --- Submitted with commit c30edd9bedfd13459eecdf110fcb61d8f465523a by David Edmundson on behalf of Miklós Máté to branch Plasma/5.8. Repository: plasma-workspace Description --- When opening the calendar popup of the digital

Re: Review Request 129308: Calendar: clear selection on opening

2016-12-14 Thread Miklós Máté
> On Nov. 2, 2016, 3:49 p.m., David Edmundson wrote: > > do you have commit access? > > Miklós Máté wrote: > I don't have commit access. I noticed that this hasn't been committed yet. Is there something wrong with the

Re: Review Request 129308: Calendar: clear selection on opening

2016-11-02 Thread Miklós Máté
/r/129308/#review100506 --- On Nov. 2, 2016, 12:30 a.m., Miklós Máté wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 129308: Calendar: clear selection on opening

2016-11-02 Thread Miklós Máté
ure, using "if (isExpanded)" works too. - Miklós --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129308/#review100502 -------

Re: Review Request 129309: Fix broken systemloadviewer tooltip

2016-11-02 Thread Miklós Máté
commit. Thanks for fixing it. - Miklós Máté On Nov. 2, 2016, 7:15 a.m., Antonio Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 129230: Count only applications in memory usage

2016-10-19 Thread Miklós Máté
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 346b492b362a1ee74ea809de80c0cdaa60ef1dda by David Edmundson on behalf of Miklós Máté to branch Plasma/5.8. Repository: kdeplasma-addons Description --- This restores the behavior of the widget

Re: Review Request 129230: Count only applications in memory usage

2016-10-19 Thread Miklós Máté
an bug #366342 ? - Miklós --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129230/#review100147 --- On Oct. 19, 2016, 8

Review Request 129230: Count only applications in memory usage

2016-10-19 Thread Miklós Máté
/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 9b2ad1e Diff: https://git.reviewboard.kde.org/r/129230/diff/ Testing --- Thanks, Miklós Máté