nathanhenry updated this revision to Diff 23839.
nathanhenry added a comment.
Fixed m_actionCollection, manager and solved viewer
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9271?vs=23837&id=23839
BRANCH
Memory-Leak-Fixes
REVISION DETAIL
htt
nathanhenry added inline comments.
INLINE COMMENTS
> davidedmundson wrote in Viewer.cpp:145
> and then it will crash here.
Should this be dereferenced outside the loop or not at all?
> davidedmundson wrote in kcm.cpp:83-85
> The runner manager has a parent object.
>
> http://doc.qt.io/qt-5/obj
nathanhenry marked 2 inline comments as done.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9271
To: nathanhenry, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,
nathanhenry updated this revision to Diff 23837.
nathanhenry added a comment.
Fixed indentation and removed new_argv and new_argc
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9271?vs=23692&id=23837
BRANCH
Memory-Leak-Fixes
REVISION DETAIL
htt
nathanhenry added inline comments.
INLINE COMMENTS
> davidedmundson wrote in Viewer.cpp:140-143
> that can't be right.
More info?
> davidedmundson wrote in kcm.cpp:83-85
> 1. this doesn't leak
>
> 2. what's the point of making a manager?
How doesn't this leak when excluding my change?
REPOSI
nathanhenry updated this revision to Diff 23692.
nathanhenry added a comment.
Forgot to remove debug statement
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9271?vs=23691&id=23692
BRANCH
Memory-Leak-Fixes
REVISION DETAIL
https://phabricator.kd
nathanhenry created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Fixed memory leak in oldCorr
Fixed memory leak
Fixed memory leak
REPOSITORY
R119 Plasma Desktop
BRANCH
Memory-Leak-Fixes
R
