D26409: [kicker] Use arrow functions in event handlers

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Fixes warnings from qmllint about unqualified property access. It also makes the

D26406: [kicker] Fix some unqualified root property access

This revision was automatically updated to reflect the committed changes. Closed by commit R119:64aa80431386: [kicker] Fix some unqualified root property access (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26406: [kickoff] Fix some unqualified root property access

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Those will break in Qt 6. Apply suggestions from qmllint TEST PLAN Did

D25990: Simplify android checks in cmake

This revision was automatically updated to reflect the committed changes. Closed by commit R169:28c13770a73a: Simplify android checks in cmake (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25990?vs=71519=72411 REVISION DETAIL

D26224: [kicker] Fix a few unqualified property access

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bf1eb34cf7b4: [kicker] Fix a few unqualified property access (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26224?vs=72178=72179

D26224: [kicker] Fix a few unqualified property access

nicolasfella added a comment. I couldn't make it work properly either so there are tons of false positives, but you still can get some useful results from it REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26224 To: nicolasfella, #plasma Cc: davidedmundson,

D26224: [kicker] Fix a few unqualified property access

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Those will break in Qt 6. Port a few trivial ones suggested by qmllint TEST PLAN

D26200: Add shortcut for closing pages

nicolasfella created this revision. nicolasfella added reviewers: Kirigami, mart, ngraham. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY The lack of standard way to close a page has always bothered me,

D26199: Remove unneeded shortcut for page naviagtion

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Kirigami provides shortcuts for page navigation out of the box TEST PLAN Still can switch pages by Alt+Arrow

D25580: [System Tray] Unified data model for System Tray items

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D25580 To: kmaterka, #plasma, broulik, ngraham, nicolasfella Cc:

D25990: Simplify android checks in cmake

nicolasfella created this revision. nicolasfella added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R169 Kirigami BRANCH andro REVISION DETAIL https://phabricator.kde.org/D25990

D25989: Don't build and install app templates on android

nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:123 > add_subdirectory(src) > -add_subdirectory(templates) > +if (NOT CMAKE_SYSTEM_NAME STREQUAL "Android") > +add_subdirectory(templates) if(ANDROID) is enough REPOSITORY R169 Kirigami REVISION DETAIL

D25989: Don't build and install app templates on android

nicolasfella added inline comments. INLINE COMMENTS > nicolasfella wrote in CMakeLists.txt:123 > if(ANDROID) is enough if (NOT ANDROID) obviously REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25989 To: jbbgameich, #kirigami, #android Cc: nicolasfella,

D25908: Lock screen by default, on mobile

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Works fine for me REPOSITORY R122 Powerdevil BRANCH master REVISION DETAIL https://phabricator.kde.org/D25908 To: apol, #plasma, broulik, nicolasfella Cc: nicolasfella,

D25908: Lock screen by default, on mobile

nicolasfella added a comment. Oh yes please +1 REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D25908 To: apol, #plasma, broulik Cc: nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D25772: [Notifications] Add ServerInfo class

nicolasfella added a comment. I would like to have something like this in KNotifications to be able to check which features/hints the server supports without doing the DBus stuff myself REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25772 To: broulik,

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

This revision was automatically updated to reflect the committed changes. Closed by commit R135:a5bdd39f9355: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox (authored by nicolasfella). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

nicolasfella added a comment. Can Plasma depend on Frameworks master or does this have to wait until 5.66 release? REPOSITORY R135 Integration for Qt applications in Plasma BRANCH prov REVISION DETAIL https://phabricator.kde.org/D25701 To: nicolasfella, #plasma, #frameworks, apol

D25580: [System Tray] Unified data model for System Tray items

nicolasfella added a comment. Looks very good in general. A few style nitpicks INLINE COMMENTS > ConfigEntries.qml:68 > var list = []; > -for (var i = 0; i < statusNotifierModel.count; ++i) { > -var item = statusNotifierModel.get(i); > -list.push({ >

D25672: Port to std::sort

This revision was automatically updated to reflect the committed changes. Closed by commit R122:2a9997672cac: Port to std::sort (authored by nicolasfella). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25672?vs=71056=71057 REVISION DETAIL

D25672: Port to std::sort

nicolasfella updated this revision to Diff 71056. nicolasfella added a comment. - include algorithm REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25672?vs=70707=71056 BRANCH qsort REVISION DETAIL https://phabricator.kde.org/D25672 AFFECTED FILES

D25725: Get icon size from QStyle

This revision was automatically updated to reflect the committed changes. Closed by commit R97:669773fc8007: Get icon size from QStyle (authored by nicolasfella). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25725?vs=70865=71055 REVISION DETAIL

D25725: Get icon size from QStyle

nicolasfella created this revision. nicolasfella added reviewers: Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. TEST PLAN No visual difference REPOSITORY R97 Bluedevil BRANCH it REVISION DETAIL

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

nicolasfella added a comment. Unrelated to the issue: For GLIB2 we have a ECM find module that makes things a bit nicer. See https://invent.kde.org/snippets/601 For GOBJECT we don't have one, but since we afaik use it on at least one other place it might be worth making one REPOSITORY

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

nicolasfella created this revision. nicolasfella added reviewers: Plasma, Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY setPixmapProvider will be deprecated with D25700

D25694: Port away from DesktopIcon

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH fo REVISION DETAIL https://phabricator.kde.org/D25694 AFFECTED FILES

D25672: Port to std::sort

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY qsort is deprecated REPOSITORY R122 Powerdevil BRANCH qsort REVISION DETAIL

D25556: Remove dead code

This revision was automatically updated to reflect the committed changes. Closed by commit R120:aff09d73f337: Remove dead code (authored by nicolasfella). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25556?vs=70371=70375 REVISION DETAIL

D25556: Remove dead code

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY lol REPOSITORY R120 Plasma Workspace BRANCH lol REVISION DETAIL

D25549: [kcms/keyboard] Port away from KToolInvokation

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY kdeinit will most likely be dropped. Use QProcess to start it normally TEST PLAN

D25537: [kaccess] Remove unneeded KService dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5c29f1f4aaee: [kaccess] Remove unneeded KService dependency (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25537?vs=70324=70342

D25537: [kaccess] Remove unneeded KService dependency

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. TEST PLAN Builds REPOSITORY R119 Plasma Desktop BRANCH kacc REVISION DETAIL https://phabricator.kde.org/D25537 AFFECTED FILES

D25385: Use icon name instead of pixmap in notification

This revision was automatically updated to reflect the committed changes. Closed by commit R116:fc443ccedbfc: Use icon name instead of pixmap in notification (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D25384: Remove some unused includes

This revision was automatically updated to reflect the committed changes. Closed by commit R119:caaedab8808e: Remove some unused includes (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25384?vs=69962=69984 REVISION DETAIL

D25383: Remove some unused includes

This revision was automatically updated to reflect the committed changes. Closed by commit R97:3729eb68013e: Remove some unused includes (authored by nicolasfella). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25383?vs=69961=69983 REVISION DETAIL

D25385: Use icon name instead of pixmap in notification

nicolasfella updated this revision to Diff 69964. nicolasfella added a comment. - More REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25385?vs=69963=69964 BRANCH noti REVISION DETAIL https://phabricator.kde.org/D25385

D25385: Use icon name instead of pixmap in notification

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY It's both easier and better TEST PLAN builds

D25384: Remove some unused includes

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. TEST PLAN builds REPOSITORY R119 Plasma Desktop BRANCH incl REVISION DETAIL

D25383: Remove some unused includes

nicolasfella created this revision. nicolasfella added reviewers: Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. TEST PLAN builds REPOSITORY R97 Bluedevil BRANCH incl REVISION DETAIL

D24743: Update GTK settings according to Plasma settings

nicolasfella added a comment. Works really well, good job! Some minor nitpicks INLINE COMMENTS > CMakeLists.txt:69 > add_subdirectory(tests) > +add_subdirectory(kded-module) > Nitpick, feel free to ignore since it was probably done by me: usually we call the folder just 'kded' >

D25223: Avoid side effects during menu initialization

nicolasfella added a comment. My long-term goal is to get rid of the application side KStatusNotifierItem and amend the QSystemTrayIcon API REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D25223 To: kmaterka, #plasma, #frameworks,

D25223: Avoid side effects during menu initialization

nicolasfella added subscribers: davidedmundson, nicolasfella. nicolasfella added a comment. In D25223#561561 , @kmaterka wrote: > Off-topic idea: This QPA integration uses KStatusNotifierItem, which then translates it to DBus. Wouldn't it be

D24934: [notifications] Center no notification text on mobile

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c3ab37034791: [notifications] Center no notification text on mobile (authored by nicolasfella). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24934: [notifications] Center no notification text on mobile

nicolasfella updated this revision to Diff 68721. nicolasfella added a comment. - Fix it REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24934?vs=68720=68721 BRANCH cent REVISION DETAIL https://phabricator.kde.org/D24934 AFFECTED FILES

D24934: [notifications] Center no notification text on mobile

nicolasfella added a comment. Looks just more complicated to me, but :shrug: REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24934 To: nicolasfella, #plasma, #vdg, broulik Cc: broulik, KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24934: [notifications] Center no notification text on mobile

nicolasfella updated this revision to Diff 68720. nicolasfella added a comment. - Do as Kai says REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24934?vs=68718=68720 BRANCH cent REVISION DETAIL https://phabricator.kde.org/D24934 AFFECTED

D24934: [notifications] Center no notification text on mobile

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH cent REVISION DETAIL https://phabricator.kde.org/D24934 AFFECTED FILES

D24924: Don't reset model when adding an active connection

This revision was automatically updated to reflect the committed changes. Closed by commit R116:6929300787ac: Dont reset model when adding an active connection (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D24919: Don't reset model when device state changes

This revision was automatically updated to reflect the committed changes. Closed by commit R116:2bb496b0708f: Dont reset model when device state changes (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24919?vs=68694=68698#toc REPOSITORY R116 Plasma Network

D24927: Use updateItem

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH uu REVISION DETAIL

D24924: Don't reset model when adding an active connection

nicolasfella updated this revision to Diff 68695. nicolasfella added a comment. - Only emit changed roles - Use updateItem REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24924?vs=68691=68695 BRANCH updavail REVISION DETAIL

D24919: Don't reset model when device state changes

nicolasfella updated this revision to Diff 68694. nicolasfella added a comment. - Only emit changed roles - Use updateItem REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24919?vs=68693=68694 BRANCH noreset2 REVISION DETAIL

D24919: Don't reset model when device state changes

nicolasfella updated this revision to Diff 68693. nicolasfella added a comment. - Only emit changed roles REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24919?vs=68677=68693 BRANCH noreset2 REVISION DETAIL

D24924: Don't reset model when adding an active connection

nicolasfella updated this revision to Diff 68691. nicolasfella added a comment. - Only emit changed roles REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24924?vs=68681=68691 BRANCH updavail REVISION DETAIL

D24923: Use more return early

This revision was automatically updated to reflect the committed changes. Closed by commit R116:c56f00b52786: Use more return early (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24923?vs=68689=68690

D24923: Use more return early

nicolasfella added inline comments. INLINE COMMENTS > jgrulich wrote in networkmodel.cpp:402 > I think this is a valid Qt coding style, it was just my obsession to use > curly braces everywhere, even for single line body. As much as I hate it, crossi is right.

D24923: Use more return early

nicolasfella updated this revision to Diff 68689. nicolasfella added a comment. - Conding style REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24923?vs=68680=68689 BRANCH ret REVISION DETAIL https://phabricator.kde.org/D24923

D24922: Don't reset model when available connection appears

This revision was automatically updated to reflect the committed changes. Closed by commit R116:d971703e1df5: Dont reset model when available connection appears (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D24920: Add missing role changes

This revision was automatically updated to reflect the committed changes. Closed by commit R116:17e4fd449991: Add missing role changes (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24920?vs=68678=68687

D24924: Don't reset model when adding an active connection

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY same resoning as in D24903 REPOSITORY R116

D24923: Use more return early

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH ret REVISION DETAIL

D24922: Don't reset model when available connection appears

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY addAvailableConnection() does the proper row/data update handling already Depends

D24920: Add missing role changes

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY A few roles were not marked as changed properly. TEST PLAN Builds REPOSITORY

D24919: Don't reset model when device state changes

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY same resoning as in D24903 TEST PLAN Toggled

D24910: Fix build

This revision was automatically updated to reflect the committed changes. Closed by commit R116:ba142dd7125c: Fix build (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24910?vs=68660=68661 REVISION DETAIL

D24905: Use return early

This revision was automatically updated to reflect the committed changes. Closed by commit R116:f301f1ead38a: Use return early (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24905?vs=68658=68659 REVISION

D24905: Use return early

nicolasfella updated this revision to Diff 68658. nicolasfella added a comment. - s/break/continue - Fixup REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24905?vs=68644=68658 BRANCH returnearly REVISION DETAIL

D24903: Don't reset model when activeconnectionstate changed

This revision was automatically updated to reflect the committed changes. Closed by commit R116:4627aaf6f066: Dont reset model when activeconnectionstate changed (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D24900: [mobile/wifi] Remove special font style for active connection

This revision was automatically updated to reflect the committed changes. Closed by commit R116:5e9ff384b503: [mobile/wifi] Remove special font style for active connection (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D24899: Remove commented out code

This revision was automatically updated to reflect the committed changes. Closed by commit R116:33991d909626: Remove commented out code (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24899?vs=68636=68654#toc REPOSITORY R116 Plasma Network Management Applet

D24897: [mobile/wifi] Remove broken confirmation dialog when forgetting a connection

This revision was automatically updated to reflect the committed changes. Closed by commit R116:b83e86d817bc: [mobile/wifi] Remove broken confirmation dialog when forgetting a connection (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D24903: Don't reset model when activeconnectionstate changed

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY resetting the model when a single property changes is using a sledgehammer to crack a

D24899: Remove commented out code

nicolasfella updated this revision to Diff 68636. nicolasfella added a comment. - Remove more REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24899?vs=68635=68636 BRANCH comm REVISION DETAIL https://phabricator.kde.org/D24899

D24808: [mobile/wifi] Group networks by connection state

This revision was automatically updated to reflect the committed changes. Closed by commit R116:cca7e8d08d42: [mobile/wifi] Group networks by connection state (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D24897: [mobile/wifi] Remove broken confirmation dialog when forgetting a connection

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY The confirmation is broken and doesn't appear

D24900: [mobile/wifi] Remove special font style for active connection

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY Now that the lsit is grouped by connection state we don't need to use font tweaks to

D24899: Remove commented out code

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH comm REVISION DETAIL

D24905: Use return early

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY Makes the code more readable by reducing the indentation depth REPOSITORY R116

D22201: [mobile/wifi] Rework NetworkSetting header

This revision was automatically updated to reflect the committed changes. Closed by commit R116:02888058564f: [mobile/wifi] Rework NetworkSetting header (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22201?vs=60970=68491#toc REPOSITORY R116 Plasma Network

D24808: [mobile/wifi] Group networks by connection state

nicolasfella updated this revision to Diff 68490. nicolasfella added a comment. - Use section property REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24808?vs=68376=68490 BRANCH groups REVISION DETAIL

D24808: [mobile/wifi] Group networks by connection state

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH groups REVISION DETAIL

D24804: Fix regression in mobile wifi kcm

nicolasfella added inline comments. INLINE COMMENTS > meven wrote in main.qml:30 > PlasmNM.Handler must be kept, (used line 56) oops, fixed REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24804 To: nicolasfella, meven, jgrulich Cc:

D24804: Fix regression in mobile wifi kcm

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R116:fefb9ef507ef: Fix regression in mobile wifi kcm (authored by nicolasfella). REPOSITORY R116 Plasma Network

D24804: Fix regression in mobile wifi kcm

nicolasfella created this revision. nicolasfella added a reviewer: meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY D23578

D24766: Revert change to make the notification persistent

nicolasfella added a comment. Yes please! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D24766 To: ngraham, apol, broulik, #discover_software_store Cc: nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D24719: Fix laptop screen being off when opening the lid

This revision was automatically updated to reflect the committed changes. Closed by commit R104:e47dc21a7b78: Fix laptop screen being off when opening the lid (authored by nicolasfella). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24719?vs=68110=68179

D24719: Fix laptop screen being off when opening the lid

nicolasfella added a comment. I tested it. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24719 To: nicolasfella, #plasma, romangg Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D24719: Fix laptop screen being off when opening the lid

nicolasfella updated this revision to Diff 68110. nicolasfella added a comment. - Fixes REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24719?vs=68099=68110 BRANCH fixit REVISION DETAIL https://phabricator.kde.org/D24719 AFFECTED FILES

D24718: [wayland] Don't init m_internalConfig twice

This revision was automatically updated to reflect the committed changes. Closed by commit R110:f948b5bcedbb: [wayland] Dont init m_internalConfig twice (authored by nicolasfella). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24718?vs=68097=68100

D24719: Fix laptop screen being off when opening the lid

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY filePath() returns the full path to the config file. readFile() then prepends

D24718: [wayland] Don't init m_internalConfig twice

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY It it initialized 4 lines prior. Once should be enough. TEST PLAN

D24648: Don't show context drawer if all actions are invisible

This revision was automatically updated to reflect the committed changes. Closed by commit R169:5f13c7b9c200: Dont show context drawer if all actions are invisible (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D24649: Set new icon for battery applet

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6ae88953a37e: Set new icon for battery applet (authored by nicolasfella). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24649?vs=67935=67963 REVISION

D24649: Set new icon for battery applet

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY It's not visible in the desktop system tray, but it is visible in the Plasma Mobile drawer where it is the only colorful

D24648: Don't show context drawer if all actions are invisible

nicolasfella created this revision. nicolasfella added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Discover can be in a state where the only action in the context drawer is

D24645: Drop Configure from KCM title

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R116:a495e38eee01: Drop Configure from KCM title (authored by nicolasfella). REPOSITORY R116 Plasma Network Management

D24645: Drop Configure from KCM title

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY None of the desktop KCMs has configure in the title REPOSITORY R116 Plasma Network

D24607: Fix showing menu toolbutton when no drawer is available

This revision was automatically updated to reflect the committed changes. Closed by commit R169:15871270ae55: Fix showing menu toolbutton when no drawer is available (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D24607: Fix showing menu toolbutton when no drawer is available

nicolasfella updated this revision to Diff 67841. nicolasfella added a comment. - Check if isMenu is undefined REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24607?vs=67839=67841 BRANCH veggie REVISION DETAIL https://phabricator.kde.org/D24607

D24601: [mobile/wifi] Use network name as title for settings page

nicolasfella added inline comments. INLINE COMMENTS > apol wrote in ConnectionItemDelegate.qml:114 > Just make it `title: ItemUniqueName` That doesn't seem to work REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24601 To: nicolasfella,

<    1   2   3   4   5   6   >