D27367: fix activity runner

McPain updated this revision to Diff 75900. McPain marked an inline comment as done. McPain added a comment. removed 2nd hunk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27367?vs=75605&id=75900 REVISION DETAIL https://phabricator.kde.org/D27367 AFFECTED FILES runners/activit

D17217: Implement free memory notifier

McPain added a comment. In D17217#412961 , @davidedmundson wrote: > > It would just be nice not to have to think about this stuff > > There is an OOM killer. That OOM killer is faster than a human, has access to more info about processes and

D27367: fix activity runner

McPain created this revision. McPain added reviewers: broulik, ngraham, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY Activity runner is now useless: m_activities is always nullptr in Activ

D27365: fix condition in KonsoleProfiles::run

McPain added a comment. Happens to be a regression after 2f3bcfa REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27365 To: McPain, heikobecker Cc: plasma-devel, Orage, LeGast00n, The-F

D27365: fix condition in KonsoleProfiles::run

McPain created this revision. McPain added a reviewer: heikobecker. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY Looks like there's a typo and it's not intended to exec "konsole --profile" with empty profile

D21872: Translate keyboard layouts in sddm

McPain added a comment. In D21872#481213 , @ngraham wrote: > In D21872#481173 , @McPain wrote: > > > In D21872#481154 , @davidedmundson wrote: > > > > >

D21872: Translate keyboard layouts in sddm

McPain added a comment. In D21872#481154 , @davidedmundson wrote: > It might be better to do it in > > XkbKeyboardBackend.cpp:184 in SDDM which is where the model comes from. I don't see any matching files in sddm REPOSITORY R120 P

D21872: Translate keyboard layouts in sddm

McPain added a comment. F6901033: изображение.png F6901031: изображение.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21872 To: McPain, ngraham Cc: plasma-devel, LeGast00n, j

D21872: Translate keyboard layouts in sddm

McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21872 AFFECTED FILES sddm-theme/KeyboardButton.qml To: McPain Cc:

D21497: fill layouts from X server when there are no layouts in config

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a14258a0cd60: fill layouts from X server when there are no layouts in config (authored by McPain). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21497?vs=58

D15247: Show tooltips in krunner

McPain added a comment. In D15247#472461 , @ngraham wrote: > IMO what's seen in your screenshot is not useful behavior. If the full text fits in the regular UI, there's no need to show a tooltip; it's just redundant. I see. Somehow `subTe

D21497: fill layouts from X server when there are no layouts in config

McPain added a comment. In D21497#472546 , @ngraham wrote: > Looks good and works for me, though I'm not super familiar with this code so I'd appreciate a review from @hein or @broulik. I'll land this tomorrow if everything will be still

D21497: fill layouts from X server when there are no layouts in config

McPain updated this revision to Diff 58951. McPain added a comment. style: for CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21497?vs=58950&id=58951 REVISION DETAIL https://phabricator.kde.org/D21497 AFFECTED FILES kcms/keyboard/keyboard_config.cpp kcms/keyboard/keyboard_dae

D21497: fill layouts from X server when there are no layouts in config

McPain updated this revision to Diff 58950. McPain added a comment. foreach -> for use const CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21497?vs=58932&id=58950 REVISION DETAIL https://phabricator.kde.org/D21497 AFFECTED FILES kcms/keyboard/keyboard_config.cpp kcms/keybo

D15247: Show tooltips in krunner

McPain added a comment. In D15247#472255 , @ngraham wrote: > I am still not actually getting any tooltips when I hover over an elided entry. > > F6860589: Screenshot_20190530_114108.png strange

D21497: fill layouts from X server when there are no layouts in config

McPain updated this revision to Diff 58932. McPain set the repository for this revision to R119 Plasma Desktop. McPain added a comment. updated paths REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21497?vs=58911&id=58932 REVISION DETAIL https://ph

D21497: fill layouts from X server when there are no layouts in config

McPain updated this revision to Diff 58911. McPain added a comment. 1. Overwrite `configureLayouts` based on whether `layouts` is empty or not 2. Make sure fetched layouts were saved to config CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21497?vs=58889&id=58911 REVISION DETAIL

D21497: fill layouts from X server when there are no layouts in config

McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY BUG: 348198 TEST PLAN 1. move ~/.config/kxkbrc 2. connect a USB keyboard 3. layout changing works REPOSITORY R119 Plasma Des

D15247: Show tooltips in krunner

McPain added a comment. In D15247#364814 , @mart wrote: > In D15247#341864 , @McPain wrote: > > > Additionally, tooltips are glitching if you move the mouse pointer too fast between items{F6324386

D15247: Show tooltips in krunner

McPain added a comment. In D15247#364814 , @mart wrote: > In D15247#341864 , @McPain wrote: > > > Additionally, tooltips are glitching if you move the mouse pointer too fast between items{F6324386

D20900: Reject invalid keys

This revision was automatically updated to reflect the committed changes. Closed by commit R116:257b03b185d3: Reject invalid keys (authored by McPain). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20900?vs=57249&id=57266 REVISION DET

D20788: Reset model when there are new available connections

This revision was automatically updated to reflect the committed changes. Closed by commit R116:4cb1e69c1a61: Reset model when there are new available connections (authored by McPain). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D207

D20900: Reject invalid keys

McPain updated this revision to Diff 57249. McPain marked an inline comment as done. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20900?vs=57245&id=57249 BRANCH D20900 REVISION DETAIL https://phabricator.kde.org/D20900 AFFECTED

D20900: Reject invalid keys

McPain updated this revision to Diff 57245. McPain edited the summary of this revision. McPain removed 1 blocking reviewer(s): jgrulich. Herald added 1 blocking reviewer(s): jgrulich. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20900

D20900: Reject invalid keys

McPain updated this revision to Diff 57239. McPain retitled this revision from "Reject short PSK passwords" to "Reject invalid keys". McPain edited the summary of this revision. McPain added a comment. validate WPA-PSK and WEP keys REPOSITORY R116 Plasma Network Management Applet CHANGES S

D20900: Reject short PSK passwords

McPain updated this revision to Diff 57237. McPain added a comment. Use validation REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20900?vs=57189&id=57237 REVISION DETAIL https://phabricator.kde.org/D20900 AFFECTED FILES kded/p

D20788: Reset model when there are new available connections

McPain added a comment. In D20788#458047 , @jgrulich wrote: > You said it's broken so I would preffer not landing a broken patch. I thought it was a regression when I applied this patch. Could reproduce an error (see D20900

D20788: Reset model when there are new available connections

McPain requested review of this revision. McPain added a comment. This revision is now accepted and ready to land. Tomorrow I'll land this patch, but I submitted another one https://phabricator.kde.org/D20900 REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://ph

D20900: Reject short PSK passwords

McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. McPain requested review of this revision. REVISION SUMMARY PasswordDialog accepted all WPA-PSK keys, included ones shorter than 8 characters, which causes s

D20788: Reset model when there are new available connections

McPain added a comment. In D20788#457772 , @jgrulich wrote: > I think resetting the model might not be necessary, when addAvailableConnection() is called, it then updates item with a new available connection, which invalidates the filter anyway

D20788: Reset model when there are new available connections

McPain planned changes to this revision. McPain added a comment. The patch "as-is" is broken. I had reports about resetting model right after clicking "Connect" button - model resets and there are no connection attempts. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D20788: Reset model when there are new available connections

McPain created this revision. McPain added a reviewer: jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. McPain requested review of this revision. REVISION SUMMARY BUG: 406765 NetworkManager will remove all conn

D18979: foldermodel: store information about screen used

McPain added a comment. In D18979#441799 , @hein wrote: > Thanks! Do you need help landing this? Any instructions about "how to commit an accepted revision?" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/

D18979: foldermodel: store information about screen used

McPain added a comment. In D18979#428230 , @hein wrote: > Can you explain more what this is trying to achieve / what it solves with an example? https://bugsfiles.kde.org/attachment.cgi?id=117630 REPOSITORY R119 Plasma Desktop REVISION

D18979: foldermodel: store information about screen used

McPain requested review of this revision. McPain added a comment. Seems like I can't use distinct screen mapping for each activity yet REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18979 To: McPain, broulik, sebas Cc: plasma-devel, jraleigh, GB_2, ragreen, P

D18979: foldermodel: store information about screen used

McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY BUG: 401464 According to FolderModel::filterAcceptsRow code, it is possible that folderview is used by containment but not assoc

D18182: Fix new file creation leading to dupe items on a fresh view

McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in foldermodel.cpp:170 > Also I don't think I understand this: > > - Delay this via queued connection, such that the row is available and can be > mapped > > at the point of rowsInserted() the row should be available, If not

D18182: Fix new file creation leading to dupe items on a fresh view

McPain added a comment. Somebody review this for me, please, I'm too far away from actually testing it REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18182 To: hein, #plasma, McPain Cc: davidedmundson, fvogt, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zre

D18182: Fix new file creation leading to dupe items on a fresh view

McPain requested changes to this revision. McPain added a comment. This revision now requires changes to proceed. That's what I got with this patch. F6563817: изображение.png Please remove Qt::QueuedConnection from both connections. Additionally,

D17217: Implement free memory notifier

McPain added a comment. In D17217#378768 , @davidedmundson wrote: > > Thanks. Any examples in KDE? I can't implement this from scratch right now. > > There is not, it would requires writing new C code. > It's something I can help with.

D18182: Fix new file creation leading to dupe items on a fresh view

McPain added inline comments. INLINE COMMENTS > fvogt wrote in foldermodel.cpp:154 > It doesn't use Qt::QueuedConnection explicitly - is the comment wrong or is > it done implicitly? According to e94888701 and cc9c3d3

D18182: Fix new file creation leading to dupe items on a fresh view

McPain accepted this revision. McPain added a comment. This revision is now accepted and ready to land. It works, thanks. Removed D17689 and D17707 patches so I close then REPOSITORY R119 Plasma Desktop BRANCH Pl

D17689: [RFC] Positioner: call initMaps even if m_enabled == false

McPain added a comment. In D17689#391265 , @hein wrote: > Here's my take: https://phabricator.kde.org/D18182 is this intentional you mentioned *this* review, not https://phabricator.kde.org/D17707? REPOSITORY R119 Plasma Desktop REVIS

D17689: [RFC] Positioner: call initMaps even if m_enabled == false

McPain added a comment. In D17689#379900 , @hein wrote: > Cool, thanks for the update. I'm a bit flooded before the Christmas holidays, but I'll try to make sense of this in early 2019. ping? REPOSITORY R119 Plasma Desktop REVISION DE

D17809: Check icon positions after move

McPain added inline comments. INLINE COMMENTS > positioner.cpp:418 > + */ > +while ((!isBlank(to) && from != to) || toIndices.contains(to)) { > to++; AFAIK, the first part of condition is "check if `to` is blank and if it's not, check whether we're not m

D17809: Check icon positions after move

McPain updated this revision to Diff 48238. McPain added a comment. Fixed condition mistake CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17809?vs=48220&id=48238 REVISION DETAIL https://phabricator.kde.org/D17809 AFFECTED FILES containments/desktop/plugins/folder/positioner.cp

D17809: Check icon positions after move

McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY BUG: 402574 When we're moving a bunch of icons to the area which is already busy, we didn't check whether we're moving icons to

D17707: FolderView: set sort mode to unserted after catching insert signal

McPain created this revision. McPain added reviewers: hein, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY When new item is created, the initMaps() is called. Positioner will init his maps relyi

D17689: Positioner: call initMaps even if m_enabled == false

McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY see BUG: 401023 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17689 AFFECTED FILES plasma-deskt

D17217: Implement free memory notifier

McPain added a comment. Anybody? REVISION DETAIL https://phabricator.kde.org/D17217 To: McPain, broulik, #vdg, ngraham Cc: davidedmundson, graesslin, abetts, ngraham, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17508: Simplify perStripe definition

McPain created this revision. McPain added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY We can get rid of double-checking of > gridView.flow == GridView.FlowLeftToRight because t

D15423: System settings: make date/time format preview consistent

McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in kcmformats.cpp:322 > I don't understand, why is this sometimes empty? Sorry for delayed reply. In KCMFormats::initCombo we add locales to combo boxes. First we add a QString() for "No change" option and then we add all poss

D17217: Implement free memory notifier

McPain updated this revision to Diff 46892. McPain added a comment. Default limit: 25% -> 10% Fix typos Auto detect swap, removed "includeSwap" setting KSysGuard: show kill button (implemented in D17366 ) CHANGES SINCE LAST UPDATE https://phabricato

D17366: Implement "Kill" button when sysguard was invoked from freememorynotifier

McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY If ksysguard was invoked from freememorynotifier directly, every process is displayed with its own kill button. In most "OOM-risky"

D17217: Implement free memory notifier

McPain added a comment. In D17217#367842 , @davidedmundson wrote: > There's also an alternative that I'd like to suggest: > According to https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt there's a system called "memory pressure" y

D17217: Implement free memory notifier

McPain added a comment. In D17217#367545 , @abetts wrote: > Is having this feature an optional feature? Can it be turned off? I'll make the notification "disableable" tomorrow REPOSITORY R120 Plasma Workspace REVISION DETAIL https://

D17217: Implement free memory notifier

McPain added a comment. In D17217#367525 , @ngraham wrote: > Thanks for all the work! > > ...But is this actually useful or actionable for the majority of users? Free space is a fairly understandable concept: if you run out, you need to dele

D17217: Implement free memory notifier

McPain created this revision. McPain added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY FreeMemoryNotifier will warn when free RAM is running out. By default, it is 25% without swap spac

D15333: Group Widget + Color Picker = Widget Out Of Bounds

McPain added inline comments. INLINE COMMENTS > mart wrote in main.qml:111 > can you put this in the commit description as well? How to get commit access? REVISION DETAIL https://phabricator.kde.org/D15333 To: McPain, #plasma, ngraham Cc: mart, davidedmundson, cfeck, plasma-devel, ragreen, P

D15247: Show tooltips in krunner

McPain added a comment. Any ideas how to fix the bugs I mentioned above? REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D15247 To: McPain, #plasma, broulik, ngraham Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, se

D15247: Show tooltips in krunner

McPain added a comment. Additionally, tooltips are glitching if you move the mouse pointer too fast between items{F6324386 } REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D15247 To: McPain, #plasma, broulik, ngraham Cc: ngraham,

D15247: Show tooltips in krunner

McPain added a comment. Found out that sometimes displayed text appears to be elided (not always reproducible) Resolution: 1920x1080, dpi: 142 F6324374: Screenshot_20181012_165807.png REPOSITORY R112 Milou REVISION DETAIL https://phabricator

D15247: Show tooltips in krunner

McPain added a comment. Anybody? REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D15247 To: McPain, #plasma, broulik, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16038: Allow dictionary runner to search multiple times

McPain created this revision. McPain added a reviewer: jriddell. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY Any time we search a word definition we add a source to our match engine but we never remove it.

D15333: Group Widget + Color Picker = Widget Out Of Bounds

McPain added inline comments. INLINE COMMENTS > main.qml:138 > > -readonly property int thickness: > Math.ceil(Math.min(parent.width, parent.height) / units.iconSizes.small) > We need to make thickness independent from length. REVISION DETAIL https://phabricator.kde.org/D1533

D15333: Group Widget + Color Picker = Widget Out Of Bounds

McPain updated this revision to Diff 42413. McPain added a comment. (height * 2) + spacer.height -> (height - spacer.height) / 2 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15333?vs=41157&id=42413 REVISION DETAIL https://phabricator.kde.org/D15333 AFFECTED FILES applets/colo

D15333: Group Widget + Color Picker = Widget Out Of Bounds

McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:111 > Please explain the rationale behind this. > > Especially the spacer.width being divided by 2 in the second part of the > statement. > Especially the spacer.width being divided by 2 in the second part of the

D15423: System settings: make date/time format preview consistent

McPain added a comment. Before: F6252186: изображение.png After: F6252262: изображение.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 To: McPain, hein Cc: ngraham, plasm

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

McPain added a comment. In D14064#322643 , @davidedmundson wrote: > Urgh. Just read the code. > > We don't reset when we type a new letter. To do so would have a jumpy ui. Instead we reset when we get results back. > > That leaves a prob

D15423: System settings: make date/time format preview consistent

McPain created this revision. McPain added a reviewer: hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY BUG: 398493 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 AF

D15333: Group Widget + Color Picker = Widget Out Of Bounds

McPain created this revision. McPain added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY BUG: 398356 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15333 A

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added a subscriber: ngraham. McPain added a comment. In D14895#320987 , @ngraham wrote: > +1 for the concept. No opinion about the notification, but I think it's fine. Removing myself as a reviewer since I don't feel qualified to offer a

D15247: Show tooltips in krunner

McPain added a comment. In D15247#320523 , @ngraham wrote: > Thanks, the patch applies now. > > Can you verify that this works for you? When I apply the patch (and reboot for good measure), I still don't see tooltips for items whose names are

D15247: Show tooltips in krunner

McPain added a comment. In D15247#319839 , @ngraham wrote: > The patch does not apply because of an extraneous `milou` in the path for your diff: > > Consider setting up `arc`; it makes the patch submission process so much simpler and less e

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added a comment. Just in case, I don't have commit access REVISION DETAIL https://phabricator.kde.org/D14895 To: McPain, broulik, ngraham, davidedmundson Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 40973. McPain marked 12 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=40923&id=40973 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengines/soliddevice/CMakeLists.txt dataengines/solidd

D15247: Show tooltips in krunner

McPain updated this revision to Diff 40956. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15247?vs=40924&id=40956 REVISION DETAIL https://phabricator.kde.org/D15247 AFFECTED FILES lib/qml/ResultDelegate.qml To: McPain, #plasma, broulik, ngraham Cc: ngraham, plasma-devel, ragreen,

D15247: Show tooltips in krunner

McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY In case of something long in krunner you can't read the whole string because of one line restriction and fixed krunner width. Th

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 40923. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=39934&id=40923 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengines/soliddevice/CMakeLists.txt dataengines/soliddevice/soliddeviceengine.cpp dataengines/

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in soliddeviceengine.cpp:555 > I think you can just move the notification to > > connect(job, &KIO::FileSystemFreeSpaceJob::result, ...) { > > if (job->error() == ERR_SERVER_TIMEOUT) { > > > > } > } > > but I haven't

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in soliddeviceengine.cpp:560 > Sure, it /might/ work, but you're still fetching a random window N seconds > after a user event. > > I don't see how we can know that will result in correct behaviour. Any ideas how to do it co

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in soliddeviceengine.cpp:555 > not sure you need this timer > > 1. You should still get the job finishing with error ERR_SERVER_TIMEOUT. > (untested, but the protocol manager in the client does have some stuff doing > this) >

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 39934. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=39933&id=39934 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengines/soliddevice/CMakeLists.txt dataengines/soliddevice/soliddeviceengine.cpp dataengines/

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 39933. McPain marked 4 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=39929&id=39933 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengines/soliddevice/CMakeLists.txt dataengines/solidde

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added inline comments. INLINE COMMENTS > anthonyfieroni wrote in soliddeviceengine.cpp:564 > You can remove it, see below. What if it creates another job working on the same path? The purpose is "check if nobody is working on path", not "save the timer pointer" > anthonyfieroni wrote i

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 39929. McPain added a comment. Used KIO::FileSystemFreeSpaceJob CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=39901&id=39929 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengines/soliddevice/CMakeLists.txt

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added a comment. In D14895#310633 , @broulik wrote: > Might not be an issue as you call `setData` anyway but just something I want you to keep in mind for testing. something like setData(udi, I18N_NOOP("Free Space"), QVarian

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added a comment. In D14895#310633 , @broulik wrote: > Might not be an issue as you call `setData` anyway but just something I want you to keep in mind for testing. I REVISION DETAIL https://phabricator.kde.org/D14895 To: McPain

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added a comment. In D14895#310633 , @broulik wrote: > Also beware that `bool SolidDeviceEngine::updateSourceEvent` is currently supposed to return `true` Who will use that `true`? I didn't found any places where that value is use

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added a comment. In D14895#310535 , @davidedmundson wrote: > Thanks for looking into this. > > Whilst this looks fine, we have a more standard abstraction layer for async IO via KIO. > There's a FileSystemFreeSpaceJob which should

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 39901. McPain marked 3 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=39897&id=39901 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengines/soliddevice/CMakeLists.txt dataengines/solidde

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 39897. McPain added a comment. Removed useless debug string REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=39896&id=39897 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengi

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain created this revision. McPain added reviewers: broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY BUG: 397537 Earlier plasmashell assumed that you'll get free space info immediately (w

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

McPain added a comment. ping? REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D14064 To: McPain, broulik Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

McPain added a comment. In D14064#291125 , @broulik wrote: > I would rather see a thorough investigation on what this does and why it is or is not needed. There's a couple of slow runners that suffer issues because of premature resetting but I d

D14064: Dictionary haven't enough time to complete query before resetting by milou

McPain created this revision. McPain added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY https://bugs.kde.org/show_bug.cgi?id=390776 REPOSITORY R112 Milou

D14063: KRunner Dictionary can't find anything

McPain created this revision. McPain added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY https://bugs.kde.org/show_bug.cgi?id=390776 REPOSITORY R114 Plasm

D10338: Don't show tooltips for inactive windows

McPain accepted this revision. McPain added a comment. This revision is now accepted and ready to land. This commit looks good and it works just as planned REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D10338 To: broulik, #plasma, graesslin, McPain

D9506: milti-screen sleep fix

McPain abandoned this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D9506 To: McPain, sebas, drosca Cc: zerg, anthonyfieroni, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9506: milti-screen sleep fix

McPain added a comment. UPD: I found monitor combination that makes KScreen works: AOC(hdmi)-iiyama(D-SUB) If I swap monitors, KSCeen doesn't work (noticed it past friday evening) REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D9506 To: McPain, sebas, dro

  1   2   >