D20222: Plasma-Workspace. The last checkbox in the widget settings

pavelmos added a comment. In D20222#466116 , @davidedmundson wrote: > Generally I don't like things being blocked for no discernable reason. It makes toggling between two things order dependent. > > > If the user disables the last checkbox,

D20223: Make disk monitor widget only show real devices by default

pavelmos added a comment. Please skip this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20223 To: pavelmos, broulik, #plasma, davidre, ngraham, mart Cc: ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-moha

D20222: Plasma-Workspace. The last checkbox in the widget settings

pavelmos added a comment. Please skip this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20222 To: pavelmos, broulik, #plasma, davidre, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, se

D20223: Make disk monitor widget only show real devices by default

pavelmos added a comment. In D20223#442883 , @ngraham wrote: > I've edited the title and summary to be a bit more clear. Does that help and is it accurate? Yes that's right. Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL h

D17796: Show accurate checked state for system monitor configuration pages

pavelmos added a comment. It seems to me that everything is fine. Are there any other comments or questions? REVISION DETAIL https://phabricator.kde.org/D17796 To: pavelmos, jriddell, #plasma, ngraham Cc: broulik, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zre

D20223: Plasma-Workspace. Filtering the diskactivity widget settings upon first launch.

pavelmos added a comment. In D20223#442762 , @davidedmundson wrote: > Can you explain not what the change is doing, but why we're making it? > > What happens if I'm trying to monitor a removable USB disk? Thanks for your responce!

D20223: Plasma-Workspace. Filtering the diskactivity widget settings upon first launch.

pavelmos created this revision. pavelmos added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pavelmos requested review of this revision. REVISION SUMMARY Made filtering the diskactivity widget settings upon first launch. Now, when the widget is f

D20222: Plasma-Workspace. The last checkbox in the widget settings

pavelmos created this revision. pavelmos added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pavelmos requested review of this revision. REVISION SUMMARY Added a ban on disabling the last checkbox in the widget settings. There will always be at l

D17796: Show accurate checked state for system monitor configuration pages

pavelmos added a comment. I have no commit access. REVISION DETAIL https://phabricator.kde.org/D17796 To: pavelmos, jriddell, #plasma, ngraham Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, m

D17796: Show accurate checked state for system monitor configuration pages

pavelmos added a comment. In D17796#382974 , @ngraham wrote: > There we go, it works now! Code change looks sane to me. > > Please change the title to something more descriptive, such as "Show accurate checked state for system monitor configu

D17796: Plasma Workspace. Fixed general settings of the widgets.

pavelmos updated this revision to Diff 48278. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17796?vs=48186&id=48278 REVISION DETAIL https://phabricator.kde.org/D17796 AFFECTED FILES applets/systemmonitor/common/contents/ui/ConfigGeneral.qml To: pavelmos, jriddell, #plasma, ngraha

D17796: Plasma Workspace. Fixed general settings of the widgets.

pavelmos created this revision. pavelmos added projects: Plasma: Workspaces, Plasma (Plasma 5.14). Herald edited projects, added Plasma; removed Plasma (Plasma 5.14), Plasma: Workspaces. Herald added a subscriber: plasma-devel. pavelmos requested review of this revision. REVISION SUMMARY Fixed

D17095: Fixed comic widget crash

pavelmos added a comment. I have no commit access. REVISION DETAIL https://phabricator.kde.org/D17095 To: pavelmos, jriddell, bshah, davidedmundson, #plasma, mart Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17094: Fixed comic widget context menu crash

pavelmos added a comment. I have no commit access. REVISION DETAIL https://phabricator.kde.org/D17094 To: pavelmos, jriddell, bshah, davidedmundson, mart Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17094: Fixed comic widget context menu crash

pavelmos updated this revision to Diff 46064. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17094?vs=45994&id=46064 REVISION DETAIL https://phabricator.kde.org/D17094 AFFECTED FILES applets/comic/comic.cpp applets/comic/comic.h To: pavelmos, jriddell, bshah, davidedmundson Cc:

D17095: Fixed comic widget crash

pavelmos added inline comments. INLINE COMMENTS > anthonyfieroni wrote in comic.cpp:196 > Just move this after brace. Yes, I agree. Your remark is true REVISION DETAIL https://phabricator.kde.org/D17095 To: pavelmos, jriddell, bshah, davidedmundson, #plasma Cc: anthonyfieroni, plasma-devel,

D17095: Fixed comic widget crash

pavelmos updated this revision to Diff 45996. pavelmos marked an inline comment as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17095?vs=45995&id=45996 REVISION DETAIL https://phabricator.kde.org/D17095 AFFECTED FILES applets/comic/comic.cpp To: pavelmos, jriddell, bshah,

D17095: Fixed comic widget crash

pavelmos created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pavelmos requested review of this revision. REVISION SUMMARY Crash happens on trying to load an unsupported format content such as video. To prevent a crash, the patch blocks the loading of

D17094: Fixed comic widget context menu crash

pavelmos created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pavelmos requested review of this revision. REVISION SUMMARY Crash happens on trying to use the context menu of widget with no active comics. The patch disables some items in this context