D14697: X11: set GDK_SCALE (try 2)

eszlari created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. eszlari requested review of this revision. REVISION SUMMARY BUG: 387849 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1469

D14697: X11: set GDK_SCALE (try 2)

eszlari added inline comments. INLINE COMMENTS > broulik wrote in startkde.cmake:98 > Where does `kdeglobals_kscreen_scalefactor` come from? Line 52. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma, broulik

D14697: X11: set GDK_SCALE (try 2)

eszlari added a comment. peter.eszl...@gmail.com REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D20242: Add flatpak mime types

eszlari created this revision. eszlari added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. eszlari requested review of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D20242 AFFECTED FILES disco

D20242: Add flatpak mime types

eszlari added a comment. @apol Have forgotten to commit? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D20242 To: eszlari, apol Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D20242: Add flatpak mime types

eszlari added a comment. I think, for my small contributions, this would be overkill, but thanks for your trust! :-) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D20242 To: eszlari, apol Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, le

D25324: Display a warning, if xsettingsd is not found

eszlari added a comment. In D25324#563373 , @gikari wrote: > In D25324#563347 , @eszlari wrote: > > > But seems, this only applies to dependencies checked by find_package(). > > > I'm confused.

D25324: [GTK Config] Add XSettingsd as a runtime dependency

eszlari added a comment. > BUG: 418263 This bug is not fixed by this patch. `xsettingsd` needs to be started in `plasma-workspace/startkde/startplasma.cpp` (or by systemd in the future). > FIXED-IN: 5.19 I would be nice, if this could make it to 5.18, so that `xsettingsd` would

D25324: [GTK Config] Add XSettingsd as a runtime dependency

eszlari added a comment. In D25324#624299 , @gikari wrote: > In D25324#624229 , @eszlari wrote: > > > This bug is not fixed by this patch. `xsettingsd` needs to be started in `plasma-workspace/start

D28360: cmake: make xsettingsd check an option

eszlari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. eszlari requested review of this revision. REVISION SUMMARY This way, packagers won't miss this new runtime dependency. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://

D28360: cmake: make xsettingsd check an option

eszlari added a comment. In D28360#636403 , @gikari wrote: > Why just not make xsettingsd required? It is set to REQUIRED (and ON by default), but can be disabled, mainly because I would like to have this in 5.18, and it seems safer that

D28360: cmake: make xsettingsd check an option

eszlari added a comment. In D28360#636406 , @gikari wrote: > In D28360#636404 , @eszlari wrote: > > > I would like to have this in 5.18 > > > We cannot add mandatory dependencies to the stable

D28360: cmake: make xsettingsd check an option

eszlari added a comment. In D28360#636418 , @gikari wrote: > But the option is enabled by default and needs to be explicitly disabled. This seems to be an overengineered solution. It basically says, that XSettingsd is an optional dependency, whi

D28360: cmake: make xsettingsd check an option

eszlari added a comment. In D28360#636448 , @gikari wrote: > Again, why not just make XSettingsd required? It's simpler. To quote yourself: "We cannot add mandatory dependencies to the stable branches/releases." I think it's importan

D28360: cmake: make xsettingsd check an option

eszlari added a comment. How can I close this? (phabricator UI really sucks, I hope the move to Gitlab is completed soon) REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28360 To: eszlari, gikari Cc: rikmills, kossebau, ngraham, plasma-devel, Orage

D28360: cmake: make xsettingsd check an option

eszlari abandoned this revision. eszlari added a comment. OK, found it. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28360 To: eszlari, gikari Cc: rikmills, kossebau, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, z

D24743: Update GTK settings according to Plasma settings

eszlari added a comment. Maybe a warning about the runtime dependency on xsettingsd should be added to cmake, so distro packagers know about it. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24743 To: gikari, #plasma, #vdg, broulik, cblack Cc: es

D24743: Update GTK settings according to Plasma settings

eszlari added a comment. In D24743#562745 , @gikari wrote: > I'm not very proficient in CMake, so how can I do that? https://cmake.org/cmake/help/latest/command/find_program.html REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAI

D25324: Display a warning, if xsettingsd is not found

eszlari added a comment. I guess he refers to: https://cmake.org/cmake/help/latest/module/FeatureSummary.html#command:set_package_properties But seems, this only applies to dependencies checked by find_package(). REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https:/