D26718: aggregate text for KRunner in DesktopView

pdabrowski added a comment. Moved to GitLab: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/148 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26718 To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik Cc: pzro, pl

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski added a comment. In D27972#645441 , @ngraham wrote: > It almost sounds like we need a "full manual control" mode where it's expected that the system tray applet or keyboard shortcut will be used to turn it on and off on demand.

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski added a comment. I totally missed the D26688 request. And it proposes some great ideas. So just to update my mockup accordingly: As for the tray icon visibility (for the states above): - Manual mode: - disabled = F8230305: off22.

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski added a comment. Maybe I should explain my motives and probably that would let us (including me) understand the goal better. I use Night Color only occasionally and I want to turn it on *manually*. And I like my tray clean. So I only need this icon when I have it manually e

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski updated this revision to Diff 78317. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27972?vs=78315&id=78317 REVISION DETAIL https://phabricator.kde.org/D27972 AFFECTED FILES applets/nightcolor/package/contents/ui/main.qml applets/nightcolor/plugin/monitor.cpp applets

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski added a comment. In D27972#627281 , @ngraham wrote: > In D27972#626302 , @broulik wrote: > > > > > > Could you update the description to be a bit more clear about what exactly has b

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski updated this revision to Diff 78315. pdabrowski edited the summary of this revision. pdabrowski edited the test plan for this revision. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27972?vs=77473&id=78315 REVISION DETAIL https://phabricato

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski updated this revision to Diff 77473. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27972?vs=77472&id=77473 REVISION DETAIL https://phabricator.kde.org/D27972 AFFECTED FILES applets/nightcolor/package/contents/ui/main.qml applets/nightc

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski marked an inline comment as done. pdabrowski added a comment. In D27972#625596 , @zzag wrote: > > Fix for NightColor plasmoid active/passive status > > Could you please describe what's wrong with it right now? I wanted the i

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski marked an inline comment as done. pdabrowski added inline comments. INLINE COMMENTS > zzag wrote in main.qml:36-38 > We want to keep the applet visible even if Night Color is inhibited so user > can quickly uninhibit it. With this patch, the user would have to click the > system tray

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski updated this revision to Diff 77472. pdabrowski edited the summary of this revision. pdabrowski added a comment. new patch REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27972?vs=77379&id=77472 REVISION DETAIL https://phabricator.kde.org

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski updated this revision to Diff 77379. pdabrowski added a comment. more context lines in diff REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27972?vs=77378&id=77379 REVISION DETAIL https://phabricator.kde.org/D27972 AFFECTED FILES apple

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski created this revision. pdabrowski added reviewers: Plasma, zzag, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pdabrowski requested review of this revision. REVISION SUMMARY Fix for NightColor plasmoid active/passive status and its tooltip subtext.

D26718: aggregate text for KRunner in DesktopView

pdabrowski added a comment. In D26718#622311 , @ngraham wrote: > Are you planning to work on that other part in this patch, or in a separate one? I do not plan to change this patch. As for solving the issue with KRunner invoked from sho

D26718: aggregate text for KRunner in DesktopView

pdabrowski updated this revision to Diff 76799. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26718?vs=76798&id=76799 REVISION DETAIL https://phabricator.kde.org/D26718 AFFECTED FILES shell/desktopview.cpp shell/desktopview.h To: pdabrowski,

D26718: aggregate text for KRunner in DesktopView

pdabrowski added inline comments. INLINE COMMENTS > desktopview.cpp:246 > > +bool DesktopView::handleKRunnerTextInput(QKeyEvent *e) { > +// allow only Shift and GroupSwitch modifiers TODO: code style: { REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D267

D26718: aggregate text for KRunner in DesktopView

pdabrowski updated this revision to Diff 76798. pdabrowski retitled this revision from "autostart KRunner with Plasma, aggregate text for KRunner in DesktopView" to "aggregate text for KRunner in DesktopView". pdabrowski edited the summary of this revision. pdabrowski added a comment. Dropped

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski added a comment. In D26718#595756 , @davidedmundson wrote: > I don't want us to make krunner autostart. It's a hack, not a fix. I'm gonna play devil's advocate here :) If having an already running KRunner service is a hack, t

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski planned changes to this revision. pdabrowski added inline comments. INLINE COMMENTS > desktopview.cpp:262 > if (!e->modifiers() || e->modifiers() == Qt::ShiftModifier) { > const QString text = e->text().trimmed(); > if (!text.isEmpty() && text[0].isPrint()) { TO

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski updated this revision to Diff 73740. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26718?vs=73737&id=73740 REVISION DETAIL https://phabricator.kde.org/D26718 AFFECTED FILES krunner/CMakeLists.txt krunner/dbus/org.kde.krunner.service

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski added inline comments. INLINE COMMENTS > broulik wrote in main.cpp:231 > This is not how we want to autostart something :) Instead, you want to place > the desktop file in autostart folder again Right :) I thought of this so that everytime Plasma starts it ensures KRunner is running

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski added a comment. In D26718#595688 , @broulik wrote: > Maybe if we autostarted KRunner based on whether it was used previously "Used previously" as in opened at least once? I guess this is always true for every user, because KR

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski created this revision. pdabrowski added reviewers: Plasma, Plasma: Workspaces, davidedmundson, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pdabrowski requested review of this revision. REVISION SUMMARY autostart KRunner with Plasma as daemon to mi

D22684: [Klipper] Fix clipboard history management

pdabrowski added a comment. Is this OK now? I think the privacy issue caused by that reported regression (#409366) should really be fixed, one way or another. Most people are probably totally unaware their clipboard still contains the last content after they command it to be cleared...

D22684: [Klipper] Fix clipboard history management

pdabrowski added inline comments. INLINE COMMENTS > davidedmundson wrote in historyimageitem.cpp:45 > what's this square about? > > Also if "bpp" is bits per pixel, we need to put it in i18n() for translation The square indicates that the clipboard contains an image, not a literal string like

D22684: [Klipper] Fix clipboard history management

pdabrowski updated this revision to Diff 69856. pdabrowski marked 3 inline comments as done. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22684?vs=69775&id=69856 REVISION DETAIL https://phabricator.kde.org/D22684 AFFECTED FILES applets/clipboar

D22684: [Klipper] Fix clipboard history management

pdabrowski added a comment. Rebased. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22684 To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Zr

D22684: [Klipper] Fix clipboard history management

pdabrowski updated this revision to Diff 69775. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22684?vs=63147&id=69775 REVISION DETAIL https://phabricator.kde.org/D22684 AFFECTED FILES applets/clipboard/contents/ui/ClipboardPage.qml applets/cli

D22684: [Klipper] Fix clipboard history management

pdabrowski added a comment. Bump. This privacy issue (#409366) is still unresolved in latest Plasma. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22684 To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson Cc: davidre, plasma-devel, LeGas

D22684: [Klipper] Fix clipboard history management

pdabrowski added a comment. New, much better solution. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22684 To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, Zren

D22684: [Klipper] Fix clipboard history management

pdabrowski updated this revision to Diff 63147. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22684?vs=63145&id=63147 REVISION DETAIL https://phabricator.kde.org/D22684 AFFECTED FILES applets/clipboard/contents/ui/ClipboardPage.qml applets/cli

D22684: [Klipper] Fix clipboard history management

pdabrowski updated this revision to Diff 63145. pdabrowski edited the summary of this revision. pdabrowski edited the test plan for this revision. pdabrowski added a comment. New, much better solution. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D22684: [Klipper] Fix clipboard history management

pdabrowski updated this revision to Diff 62444. pdabrowski retitled this revision from "[Klipper] Fix clipboard history clearing" to "[Klipper] Fix clipboard history management". pdabrowski edited the summary of this revision. pdabrowski added a comment. This revision is now accepted and ready to

D22684: [Klipper] Fix clipboard history clearing

pdabrowski added a comment. Weak pointer might not work well for this after all. I need to have a second look at this patch. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22684 To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson Cc: plas

D22684: [Plasma Workspace][Klipper] Fixed clipboard history clearing (#409366)

pdabrowski updated this revision to Diff 62410. pdabrowski added a comment. new diff: much better patch REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22684?vs=62398&id=62410 REVISION DETAIL https://phabricator.kde.org/D22684 AFFECTED FILES k

D22684: [Plasma Workspace][Klipper] Fixed clipboard history clearing (#409366)

pdabrowski updated this revision to Diff 62398. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22684?vs=62395&id=62398 REVISION DETAIL https://phabricator.kde.org/D22684 AFFECTED FILES klipper/klipper.cpp To: pdabrowski, #plasma, #plasma_workspa

D22684: [Plasma Workspace][Klipper] Fixed clipboard history clearing (#409366)

pdabrowski created this revision. pdabrowski added reviewers: Plasma, Plasma: Workspaces, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pdabrowski requested review of this revision. REVISION SUMMARY Fixed clipboard history clearing in Klipper: https://bugs.k