rakuco added a comment.
Looks great to me now; I'll leave it to Martin to accept the diff.
INLINE COMMENTS
CMakeLists.txt:34 While here, you could adjust the wording a little, like I
suggested in my comment ("disallow" -> "disallowing", "the greeter and
kcheckpass processes").
REPOSITORY
rakuco added inline comments.
INLINE COMMENTS
CMakeLists.txt:25-30 I think you need to merge these two `add_feature_info()`
calls: as-is, either one or the other will always be shown in the "disabled
features" list, and I guess you only want this to happen if neither call/header
is found. Per
x27;m unable to test this at the moment; if Tobias is around and able to submit a
FreeBSD version it'd be good to integrate it into the same patch, otherwise we
can just do that later.
- Raphael Kubo da Costa
On Dec. 1, 2015, 3:13 p.m., Martin Grä
> On Dec. 1, 2015, 12:04 p.m., Raphael Kubo da Costa wrote:
> > CMakeLists.txt, line 25
> > <https://git.reviewboard.kde.org/r/126203/diff/2/?file=420269#file420269line25>
> >
> > This is being checked for here but not set in
> > `config-kscreenlocker
- Raphael Kubo da Costa
On Dec. 1, 2015, 9:34 a.m., Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.revi
gt; >
> > I will have to ask someone more familiar with that.
>
> Martin Gräßlin wrote:
> > how do I get kwin to output the debug output for the framebuffer
> backend, with qcdebug lines,
>
> Given the notes on it, that seems fine. It's not my intention to p
org/r/126203/#comment60901>
Both `prctl()` and `PR_SET_DUMPABLE` seem to be defined in `sys/prctl.h` on
Linux, so this include should not be necessary.
kcheckpass/kcheckpass.c (line 61)
<https://git.reviewboard.kde.org/r/126203/#comment60902>
Ditto here.
- Raphael Kubo da Co
> On Nov. 30, 2015, 10:34 a.m., Tobias Berner wrote:
> > I think FreeBSD 10 introduced a similar interface in r277322
> > https://svnweb.freebsd.org/base?view=revision&revision=277322
> > Though it is explicitely stated to not be a "security feature".
> >
> > According to the man page of progctl
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121762/#review74261
---
Ship it!
- Raphael Kubo da Costa
On Jan. 18, 2015, 10 p.m
il. To reply, visit:
> https://git.reviewboard.kde.org/r/121763/
> ---
>
> (Updated Dec. 30, 2014, 8:48 p.m.)
>
>
> Review request for Plasma and Raphael Kubo da Costa.
>
>
> Repository: kinfocenter
>
>
> Description
> -
org/r/121762/#comment50700>
You shouldn't need this anymore.
- Raphael Kubo da Costa
On Dec. 30, 2014, 11:37 p.m., Alex Richardson wrote:
>
> ---
> This is an automatically generated e-mail. To r
it would be good if in your final
commit messages you pasted the actual errors clang is throwing at you for
posterity.
- Raphael Kubo da Costa
On Dec. 30, 2014, 8:35 p.m., Alex Richardson wrote:
>
> ---
> This is an automatically
.
- Raphael Kubo da Costa
On Dec. 30, 2014, 8:48 p.m., Alex Richardson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
, and commit each of those
changes (errno, then X11 dependencies etc) separately. Other than that, looks
good to me.
- Raphael Kubo da Costa
On Dec. 30, 2014, 8:33 p.m., Alex Richardson wrote:
>
> ---
> This is an automatically ge
,
Raphael Kubo da Costa
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
ac4978b4ee59d45a18687ccdca7c21e6bcd08854
Diff: https://git.reviewboard.kde.org/r/119651/diff/
Testing
---
kactivitymanagerd stops crashing on startup when loading the activity ranking
plugin.
Thanks,
Raphael Kubo da Costa
___
Plasma-devel mailing list
On July 19, 2014, 12:17 a.m., Vadim Zhukov wrote:
> > (As a general note, for build system related stuff like this you can also
> > try including the "buildsystem" group, which can be more responsive at
> > times)
> >
> > > The ibus-panel can't build on OpenBSD because some required definition
ved in cache, and thus isn't available at
> compile time
This doesn't make much sense; all values found at configuration time in CMake
are then used to generate your make/ninja/whatever files, regardless of whether
they are cached or not.
- Raphael Kubo da Cost
, 2:43 p.m.)
>
>
> Review request for Plasma and Raphael Kubo da Costa.
>
>
> Repository: plasma-workspace
>
>
> Description
> ---
>
> MacroPushRequiredVars has been merged into CMake, and has been renamed to
> CMakePushCheckState
>
>
> D
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105468/#review16173
---
Ping?
- Raphael Kubo da Costa
On July 7, 2012, 3:07 a.m
kde-workspace built fine both before and after this change
Thanks,
Raphael Kubo da Costa
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
s.cp. can you check if that works for you
> and if so i'll backport it.
Yep, it works fine now, thanks.
I'm closing the review as discarded now.
- Raphael
-----------
This is an automatically generated e-mail. To reply, visit:
http://git.revie
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101302/
---
Review request for Plasma.
Summary
---
Do not check if the created Pl
SVN commit 1157732 by rkcosta:
Fix build with gcc < 4.3.0.
The issue was brought up on the kde-packager/release-team mailing lists[1], and
it turns out to be a bug in gcc itself related to an iffy part of the c++
spec[2][3].
Thanks a lot to SadEagle (Maksim Orlovich) for helping chase the cause
24 matches
Mail list logo
