Re: Review Request 108992: Simple optimizations in SignalPlotter

2014-05-05 Thread Raul Fernandes
n a improvement of about 5% in drawPlots() function, the most expensive function in painting. Thanks, Raul Fernandes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108992: Simple optimizations in SignalPlotter

2013-03-08 Thread Raul Fernandes
> On Feb. 22, 2013, 1:32 a.m., Aaron J. Seigo wrote: > > plasma/widgets/signalplotter.cpp, line 230 > > <http://git.reviewboard.kde.org/r/108992/diff/1/?file=114209#file114209line230> > > > > no point in taking PODs out of the loop > > Raul Ferna

Re: Review Request 108992: Simple optimizations in SignalPlotter

2013-02-23 Thread Raul Fernandes
n a improvement of about 5% in drawPlots() function, the most expensive function in painting. Thanks, Raul Fernandes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108992: Simple optimizations in SignalPlotter

2013-02-23 Thread Raul Fernandes
while (it.hasPrevious()) { > >it.previous(); It can't be done as is. The variable i will be used latter (d->plotColors[i].darkColor), so we have to use it. > On Feb. 22, 2013, 1:32 a.m., Aaron J. Seigo wrote: > > plasma/widgets/signalplotter.cpp, line 231 &

Re: Review Request 108992: Simple optimizations in SignalPlotter

2013-02-23 Thread Raul Fernandes
way I'm unsure if it's worth it considering that this patch makes > > everything global, now. > > Raul Fernandes wrote: > I think it is the worst response that I can have. > Never in my entire life I saw anyone that complains about creating > classes outside lo

Re: Review Request 108992: Simple optimizations in SignalPlotter

2013-02-23 Thread Raul Fernandes
way I'm unsure if it's worth it considering that this patch makes > > everything global, now. > > Raul Fernandes wrote: > I think it is the worst response that I can have. > Never in my entire life I saw anyone that complains about creating > classes outside lo

Re: Review Request 108992: Simple optimizations in SignalPlotter

2013-02-20 Thread Raul Fernandes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108992/#review27798 --- Ship it! Ship It! - Raul Fernandes On Feb. 17, 2013, 12:57

Re: Review Request 108992: Simple optimizations in SignalPlotter

2013-02-20 Thread Raul Fernandes
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108992/#review27607 --- On Feb. 17, 2013, 12:57 p.m., Raul Fernandes wrote: > > --

Review Request 108992: Simple optimizations in SignalPlotter

2013-02-17 Thread Raul Fernandes
x0) Diffs - plasma/widgets/signalplotter.cpp 8e9e294 Diff: http://git.reviewboard.kde.org/r/108992/diff/ Testing --- I have tested with KDE 4.10 with no problems. I have seen a improvement of about 5% in drawPlots() function, the most expensive function in painting. Thanks, R