Re: A nepomuk optimisation amplifying a plasma bug

2013-03-12 Thread Simeon Bird
> it should now be fixed in both the KDE/4.10 and master branches .. please test > and confirm. It's fixed! Thanks very much. Simeon ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [Nepomuk] A nepomuk optimisation amplifying a plasma bug

2013-03-12 Thread Simeon Bird
On 12 March 2013 02:49, Luca Beltrame wrote: > In data lunedì 11 marzo 2013 20:37:49, Simeon Bird ha scritto: > >> them. Is there any chance someone who knows how this bit of plasma >> works could fix the bug? I couldn't even figure out where the message >> was b

A nepomuk optimisation amplifying a plasma bug

2013-03-11 Thread Simeon Bird
Hi, There is a plasma bug: https://bugs.kde.org/show_bug.cgi?id=313319 which seems to be that plasma is constantly changing the icon in the list of activities in the activity manager. Using dbus-monitor I was able to see that it is switching between the 'user-desktop' icon and the '' icon (which

Re: Review Request: Fix KRunner's 'spell in foreign language' feature

2012-10-26 Thread Simeon Bird
l-checked a bunch of things in European languages. Thanks, Simeon Bird ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix KRunner's 'spell in foreign language' feature

2012-10-26 Thread Simeon Bird
reply, visit: http://git.reviewboard.kde.org/r/106244/#review20913 --- On Oct. 25, 2012, 5:24 p.m., Simeon Bird wrote: > > --- > This is an automatically

Re: Review Request: Fix KRunner's 'spell in foreign language' feature

2012-10-26 Thread Simeon Bird
------ On Oct. 25, 2012, 5:24 p.m., Simeon Bird wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106244/ > ---

Re: Review Request: Fix KRunner's 'spell in foreign language' feature

2012-10-26 Thread Simeon Bird
gi?id=303831 Diffs (updated) - runners/spellchecker/spellcheck.h 492c370 runners/spellchecker/spellcheck.cpp 672732d Diff: http://git.reviewboard.kde.org/r/106244/diff/ Testing --- Compiled, installed, ran for a week and spell-checked a bu

Re: Review Request: Fix KRunner's 'spell in foreign language' feature

2012-10-24 Thread Simeon Bird
> On Oct. 11, 2012, 12:01 a.m., Simeon Bird wrote: > > Does anyone have any objections? Given that the current behaviour is 'crash > > krunner when invoked' I feel I can't do much damage with this... Ok, it seems no-one has any objections (or indeed any inter

Re: Review Request: Fix KRunner's 'spell in foreign language' feature

2012-10-11 Thread Simeon Bird
behaviour is 'crash krunner when invoked' I feel I can't do much damage with this... - Simeon Bird On Sept. 21, 2012, 1:51 p.m., Simeon Bird wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request: Fix KRunner's 'spell in foreign language' feature

2012-09-21 Thread Simeon Bird
/ Testing --- Compiled, installed, ran for a week and spell-checked a bunch of things in European languages. Thanks, Simeon Bird ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-20 Thread Simeon Bird
gt; > the spelling (or even just moveToThread it if you have to) and instead of > > calling setLanguage from another thread create a signal/slot combination > > between the parent thread and the speller thread and send a language change > > request by emitting a signal fro

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-20 Thread Simeon Bird
gt; > the spelling (or even just moveToThread it if you have to) and instead of > > calling setLanguage from another thread create a signal/slot combination > > between the parent thread and the speller thread and send a language change > > request by emitting a signal fro

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-19 Thread Simeon Bird
gt; > the spelling (or even just moveToThread it if you have to) and instead of > > calling setLanguage from another thread create a signal/slot combination > > between the parent thread and the speller thread and send a language change > > request by emitting a signal fro

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-19 Thread Simeon Bird
tomatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106242/#review18865 --- On Sept. 9, 2012, 10:06 p.m., Simeon Bird wrote: > > --

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-11 Thread Simeon Bird
sentence... > > > > Maybe it would make more sense to "post" the language change operation to > > the spell-checking thread using the same mechanism as the one used to > > "post" spellchecking requests to it? (Disclaimer: I know nothing of the > &

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-11 Thread Simeon Bird
sentence... > > > > Maybe it would make more sense to "post" the language change operation to > > the spell-checking thread using the same mechanism as the one used to > > "post" spellchecking requests to it? (Disclaimer: I know nothing of the > &

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-10 Thread Simeon Bird
sting --- Compiled, installed, used for a week or so, spellchecked a bunch of things. Thanks, Simeon Bird ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-10 Thread Simeon Bird
ame dictLock to lock, and use it for > > all members. Ok - this makes the locking around update() a bit complex. (That was why I didn't do it before: it is not necessary for the krunner spelling fix, and I was lazy) - Simeon

Review Request: Fix KRunner's 'spell in foreign language' feature

2012-08-28 Thread Simeon Bird
o type in the language code directly. Diffs - runners/spellchecker/spellcheck.cpp 672732d Diff: http://git.reviewboard.kde.org/r/106244/diff/ Testing --- Compiled, installed, ran for a week and spell-checked a bunch of things in European languages. Thanks, Simeon Bird ___

Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-08-28 Thread Simeon Bird
03831 Diffs - kdecore/sonnet/speller.cpp b19e74d Diff: http://git.reviewboard.kde.org/r/106242/diff/ Testing --- Compiled, installed, used for a week or so, spellchecked a bunch of things. Thanks, Simeon Bird ___ Plasma-devel mailing list P

Re: Review Request: Reduce the memory usage of the fileWatcher plasmoid

2012-08-16 Thread Simeon Bird
sit: http://git.reviewboard.kde.org/r/105940/#review17369 --- On Aug. 9, 2012, 1:34 a.m., Simeon Bird wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://gi

Review Request: Reduce the memory usage of the fileWatcher plasmoid

2012-08-08 Thread Simeon Bird
. Thanks, Simeon Bird ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel