Re: Plasma Firewall

People, I have spend a great deal of time fine tuning the Firewall, I hope it's ready for a release. On Wed, Jun 3, 2020 at 6:33 PM Tomaz Canabrava wrote: > Lots of nitpicks fixed, still missing some, I'll finish the rest today. > > > On Fri, May 22, 2020 at 6:10 PM Ivan Čukić wr

D25375: Start of the accessibility KCM

tcanabrava abandoned this revision. tcanabrava added inline comments. INLINE COMMENTS > broulik wrote in kcmaccess.cpp:141 > Are you sure this shouldn't be something like > > modifiers & (ScrollMask | LockMask | NumMask) good catch. > broulik wrote in kcmaccess.desktop:9 > What about this?

Re: Plasma Firewall

Lots of nitpicks fixed, still missing some, I'll finish the rest today. On Fri, May 22, 2020 at 6:10 PM Ivan Čukić wrote: > Hi Kai, > > > This is something that Plasma has been missing for a long time. Thanks to > everyone involved! > > > A few comments from a quick run-through over kcm/core:

D29028: feat(wayland): add Wrapland plugin

tcanabrava added a comment. I understand David's point: Wrapland project has one developer and we don't know how successful it will be, while the other backends have developers. What would happen if you suddenly quit / disappear and the project dies? Then kscreen will have a folder of dead

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

tcanabrava updated this revision to Diff 76053. tcanabrava added a comment. - Simplify function / remove desktopResized REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26986?vs=74565=76053 BRANCH wip_fix_screenlocker_detach_reattach REVISION

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

tcanabrava updated this revision to Diff 74565. tcanabrava added a comment. - Simplify Architecture REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26986?vs=74556=74565 BRANCH wip_fix_screenlocker_detach_reattach REVISION DETAIL

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

tcanabrava added a comment. In D26986#602373 , @davidedmundson wrote: > This is definitely an area for improvement. > > This code was initially written before QGuiApplication::screenRemoved existed, which is why it's like this. > I think

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY This patch tries - and fails - to fix the flicker of screens while the kscreenlocker_greeter is active. The reasoning of

D25449: Start of the new Formats KCM

tcanabrava marked 4 inline comments as done. tcanabrava added a comment. F7877402: Screenshot_20200111_155924.PNG With OverlaySheet INLINE COMMENTS > anthonyfieroni wrote in kcm.cpp:41 > https://doc.qt.io/qt-5/qqmlengine-obsolete.html The non

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73281. tcanabrava added a comment. - Merge branch 'master' into arcpatch-D25449 - Use OverlaySheet REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25449?vs=73236=73281 BRANCH arcpatch-D25449 REVISION

D26489: Use qmlRegisterAnonymousType

This revision was automatically updated to reflect the committed changes. Closed by commit R112:7a6b1a037e65: Use qmlRegisterAnonymousType (authored by tcanabrava). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26489?vs=73276=73278 REVISION DETAIL

D26489: Use qmlRegisterAnonymousType

tcanabrava updated this revision to Diff 73276. tcanabrava added a comment. - Move typeRegistration to the Plugin instanciation REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26489?vs=72962=73276 BRANCH arcpatch-D26489 REVISION DETAIL

D25375: Start of the accessibility KCM

tcanabrava updated this revision to Diff 73274. tcanabrava marked 16 inline comments as done. tcanabrava added a comment. - ListElement does not handle i18n calls, use raw array - Dont complain about null background - Failing on Qt 5.14 - Add Key entries to the kconfigxt generator -

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73236. tcanabrava added a comment. - Fix esc and click outside to close the overlay REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25449?vs=73209=73236 BRANCH arcpatch-D25449 REVISION DETAIL

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73209. tcanabrava added a comment. - Fix some keyboard whoes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25449?vs=73188=73209 BRANCH arcpatch-D25449 REVISION DETAIL https://phabricator.kde.org/D25449

D25449: Start of the new Formats KCM

tcanabrava added a comment. (Ignore my broken Theme - i'm trying to discover what's happening.) F7874644: Screenshot_20200110_121232.PNG F7874646: Screenshot_20200110_121252.PNG REPOSITORY R119 Plasma

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73188. tcanabrava marked an inline comment as done. tcanabrava added a comment. - Remove code dependant on Qt 5.14 - Mark that we will use some text in the future - Remove uneeded virtual - Update role names to something more explicit -

D25449: Start of the new Formats KCM

tcanabrava marked 23 inline comments as done. tcanabrava added inline comments. INLINE COMMENTS > broulik wrote in kcm.cpp:37 > You're not importing this anywhere, and this still works? Makes me wonder why > Qt went through the trouble of introducing this when it makes no diference > over

D25449: Start of the new Formats KCM

tcanabrava marked an inline comment as done. tcanabrava added a comment. > Imho a custom `ComboBox` with a search field in its popup or something like that would be a better control. I tried to use the combobox (but of course phabricator destroys my history so it's hard to even

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73145. tcanabrava added a comment. - Readd writeexports.h REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25449?vs=73135=73145 BRANCH arcpatch-D25449 REVISION DETAIL https://phabricator.kde.org/D25449

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73135. tcanabrava added a comment. - Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25449?vs=73130=73135 BRANCH arcpatch-D25449 REVISION DETAIL https://phabricator.kde.org/D25449 AFFECTED FILES

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73130. tcanabrava added a comment. - Change how we set locales - Set the locale - Add missing files - Typos - Set the correct size of the list REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73061. tcanabrava added a comment. - Correctly extract qml - Update documentation text - Remove deprecated calls - Correct placement of pointer and reference symbols - Rename variables on kconfigxt and use name and key - Correct constructor

D25375: Start of the accessibility KCM

tcanabrava updated this revision to Diff 73058. tcanabrava added a comment. - Use QFileDialog to look for audio files REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25375?vs=73057=73058 BRANCH arcpatch-D25375 REVISION DETAIL

D25375: Start of the accessibility KCM

tcanabrava marked 4 inline comments as done. tcanabrava added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:53 > title should already be translated; no need to put this in an `i18n()` call this was a ListElement Q_NOOP_TR issue REPOSITORY R119 Plasma Desktop REVISION DETAIL

D25375: Start of the accessibility KCM

tcanabrava updated this revision to Diff 73057. tcanabrava marked 5 inline comments as done. tcanabrava added a comment. - ListElement does not handle i18n calls, use raw array - Dont complain about null background - Failing on Qt 5.14 - Add Key entries to the kconfigxt generator -

D25375: Start of the accessibility KCM

tcanabrava marked an inline comment as done. tcanabrava added a comment. In D25375#575980 , @ervin wrote: > I think we discussed this already, but I'm not sure so before it gets lost... :-) > > Please consider using both key and name for

D26183: Fix build with Qt 5.14

tcanabrava abandoned this revision. tcanabrava added a comment. since this is commited already I'm closing, and opened a follow up commit: https://phabricator.kde.org/D26489 REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D26183 To: tcanabrava, davidedmundson,

D26489: Use qmlRegisterAnonymousType

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REPOSITORY R112 Milou BRANCH useQmlRegisterAnonymousType REVISION DETAIL https://phabricator.kde.org/D26489 AFFECTED FILES

D26183: Fix build with Qt 5.14

This revision was automatically updated to reflect the committed changes. Closed by commit R112:dfecda35d4c7: Fix build with Qt 5.14 (authored by tcanabrava). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26183?vs=72067=72114 REVISION DETAIL

D26183: Fix build with Qt 5.14

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REPOSITORY R112 Milou BRANCH master REVISION DETAIL https://phabricator.kde.org/D26183 AFFECTED FILES lib/draghelper.cpp To:

D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings

tcanabrava added a comment. I would also say that 'Baloo' means nothing to users, and File search should be used instead. It's an internal name, not really a brand. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25278 To: ngraham, #vdg, #baloo Cc:

D24374: WIP: Initial port of the Date and Time KCM

tcanabrava added a comment. F7802151: kcm_clock.png Quite ugly I'm afraid. I'll port this to KConfigXT over next week. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24374 To: tcanabrava Cc: mart, ngraham,

D25449: Start of the new Formats KCM

tcanabrava added a comment. ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25449 To: tcanabrava Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,

D25375: Start of the accessibility KCM

tcanabrava added a comment. Updated texts by ngraham sugestions. INLINE COMMENTS > ngraham wrote in ActivationGestures.qml:50 > This section doesn't have anything to do with activation gestures. Its > checkboxes might be better placed on other pages more relevant to their > content.

D25375: Start of the accessibility KCM

tcanabrava updated this revision to Diff 71008. tcanabrava added a comment. - Fix localization calls REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25375?vs=71005=71008 BRANCH kcm_acess REVISION DETAIL https://phabricator.kde.org/D25375

D25375: Start of the accessibility KCM

tcanabrava updated this revision to Diff 71005. tcanabrava marked an inline comment as done. tcanabrava added a comment. - Typos and onToggled instead of onCheckStateChanged - Better UX / Texts - Text updates - Remove ActivationGestures page, Fix orca information REPOSITORY R119

D25745: Showcase KConfig Issue with CamelCase keys on ManagedConfigModule

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH showcase_kcofig_issue REVISION DETAIL https://phabricator.kde.org/D25745 AFFECTED FILES

D25375: Start of the accessibility KCM

tcanabrava added a comment. Missing apply button being enabled seems something related to ManagedConfigModule. I don't know what to do there yet. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25375 To: tcanabrava, ngraham Cc: ognarb, mart, ngraham,

D25375: Start of the accessibility KCM

tcanabrava updated this revision to Diff 70754. tcanabrava marked 6 inline comments as done. tcanabrava added a comment. - Add missing setButtons - Fix Typo REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25375?vs=70751=70754 BRANCH kcm_acess

D25375: Start of the accessibility KCM

tcanabrava updated this revision to Diff 70751. tcanabrava marked an inline comment as done. tcanabrava added a comment. - Fix factory name REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25375?vs=70749=70751 BRANCH kcm_acess REVISION DETAIL

D25375: Start of the accessibility KCM

tcanabrava updated this revision to Diff 70749. tcanabrava added a comment. - Fixes - Fixes texts and UI - Simplify Algorithm - Fix Enable / Disable status REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25375?vs=70103=70749 BRANCH kcm_acess

D25449: Start of the new Formats KCM

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY Detangle the code, implement models and start the Qml REPOSITORY R119 Plasma Desktop BRANCH kcm_formats REVISION

D25375: Start of the accessibility KCM

tcanabrava updated this revision to Diff 70103. tcanabrava added a comment. - Fixes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25375?vs=69947=70103 BRANCH kcm_acess REVISION DETAIL https://phabricator.kde.org/D25375 AFFECTED FILES

D25379: WIP: Beginning of the work for Simplifying the Emoticon KCM

tcanabrava added a comment. In D25379#565509 , @davidedmundson wrote: > I was under the impression we were killing this KCM in the very near future. > > The relevant workboard entry: https://phabricator.kde.org/T7292 While the KCM

D25280: [Baloo KCM] Purge index when disabling indexing

tcanabrava added a comment. I gree with david's questioning, sometimes I disable indexing when I'm about to do something heavy, to re-enable it later. I don't want to lose all my data. perhaps there should be a box `purge database data` instead of purging on disable? INLINE COMMENTS >

D25379: WIP: Beginning of the work for Simplifying the Emoticon KCM

tcanabrava updated this revision to Diff 70018. tcanabrava added a comment. - Fix speed of the models - Simplify Logic - Speed up emoticon loading - Re-Enable updateBtn - Re-enable remove theme - Move more data to the Models - Re-enable the rest of the functions - Remove ui file

D25379: WIP: Beginning of the work for Simplifying the Emoticon KCM

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY Before we port this to Qml we need to simplify the code it's currently monolithycal, and need to be split into at least

D24224: Start of the accessibility KCM

tcanabrava added a comment. After squashing the commits to remove the broken history, arc diff opened a new revision. https://phabricator.kde.org/D25375 INLINE COMMENTS > ervin wrote in kcmaccessibilitymouse.kcfg:34 > Wouldn't an Enum be more suited here? This i a spinBox with a range

D25375: Start of the accessibility KCM

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY This rewrites the Accessibility KCM to use Qml and the new Managed Config classes. REPOSITORY R119 Plasma Desktop

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 69945. tcanabrava added a comment. - Use Plasma KCM - Adapt to FormLayout - Fix label - Space every tab equally - Form layout port - FormLayout - Simplify Qml - Port to Form Layout - A much much better layout than tabs - Beginning of

D24224: Start of the accessibility KCM

tcanabrava added a comment. In D24224#561693 , @ngraham wrote: > It doesn't compile: > > /home/nate/kde/usr/include/KF5/KNewStuff3/KNS3/DownloadDialog:1:10: fatal error: kns3/downloaddialog.h: No such file or directory > 1 |

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 69651. tcanabrava added a comment. - Fix Layout REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24224?vs=69650=69651 BRANCH kcm_acess REVISION DETAIL https://phabricator.kde.org/D24224 AFFECTED FILES

D24224: Start of the accessibility KCM

tcanabrava added a comment. F7759258: image.png INLINE COMMENTS > bport wrote in CMakeLists.txt:24 > Not sure why we have this change in this code review, seems unrelated completely unrelated, thanks for spotting. REPOSITORY R119 Plasma Desktop

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 69650. tcanabrava added a comment. - Use Plasma KCM - Adapt to FormLayout - Fix label - Space every tab equally - Form layout port - FormLayout - Simplify Qml - Port to Form Layout - A much much better layout than tabs - Beginning of

D24224: Start of the accessibility KCM

tcanabrava added a comment. F7605185: kcm_access.png Now it uses a Vertical List, providing a better navigation mode, The Settings where also rewritten using KConfigXT so I don't need to deal with all the possible properties. This actually hit a hard

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 68019. tcanabrava added a comment. - Use Plasma KCM - Adapt to FormLayout - Fix label - Space every tab equally - Form layout port - FormLayout - Simplify Qml - Port to Form Layout - A much much better layout than tabs - Beginning of

D24224: Start of the accessibility KCM

tcanabrava added inline comments. INLINE COMMENTS > bport wrote in kcmaccess.h:32-67 > Using KConfigXT will remove lots of boilerplate code (tons of property > declaration + associated methods and easiest, load, save and defaults method). > And with the work done by @ervin on KConfigXT and

D24224: Start of the accessibility KCM

tcanabrava added a comment. In D24224#545013 , @broulik wrote: > Can you please follow KDE Frameworks coding style Sorry, it was by mistake. I'll fix the style. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d66bd8f3e9af: WIP: Beginning of the Baloo/Search KCM Rewrite (authored by tcanabrava). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23718?vs=67572=67701

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 67572. tcanabrava added a comment. - Fix Strings - Fix margins REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23718?vs=67568=67572 BRANCH kcm_baloo_qml REVISION DETAIL

D24224: Start of the accessibility KCM

tcanabrava added a comment. this now depends on https://phabricator.kde.org/D23835 - There's an issue with saving (the save is not activated for some reason, I need to investigate. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24224 To: tcanabrava Cc:

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 67571. tcanabrava added a comment. - Use Plasma KCM - Adapt to FormLayout - Fix label - Space every tab equally - Form layout port - FormLayout - Simplify Qml - Port to Form Layout REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava marked 2 inline comments as done. tcanabrava added a comment. I still need to play a bit with the folder save / load. the code from the old kcm is quite strange. it saves "included folders", but there's nothing using that. perhaps it's safer if we just remove everything that's not

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 67568. tcanabrava added a comment. - fix Comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23718?vs=67567=67568 BRANCH kcm_baloo_qml REVISION DETAIL https://phabricator.kde.org/D23718 AFFECTED

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 67567. tcanabrava marked 7 inline comments as done. tcanabrava added a comment. - Simplify Checkboxes - Fix previouslyEnabled logic - Tell Qml that we have the values - Move code around - Fix QSet math - Qml gives us a Url, we want the Local

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 67563. tcanabrava added a comment. - Fix metadata installation - Fix model loading on Qml - Base work on the Qml - Name fixes - Move ui/main to contents - Fix wrong types in Qml - Plug the controllers - Link to the save button - Fix

D24374: WIP: Initial port of the Date and Time KCM

tcanabrava updated this revision to Diff 67277. tcanabrava added a comment. wq - Restore colors metatada, and correctly set the datetime metadata - s/kcmclock/kcm_clock - Fix author - kcm_name break kauth, it needs kcmname =/ - Fix missing property, Add a Qml Clock (from the Qt

D24374: WIP: Initial port of the Date and Time KCM

tcanabrava updated this revision to Diff 67223. tcanabrava added a comment. - Fix KAuth usage REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24374?vs=67219=67223 BRANCH kcm_dateandtime REVISION DETAIL https://phabricator.kde.org/D24374

D24374: WIP: Initial port of the Date and Time KCM

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY This is mostly the c++ part, missing the Qml - however this one should be easy to do - with the exception of the visual

D24187: Start of the accessibility KCM

tcanabrava abandoned this revision. tcanabrava added a comment. closing this as arc diff opened two reviews with the same content =/ REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24187 To: tcanabrava Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava added a comment. got it, updating. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23718 To: tcanabrava, #plasma, mart, ngraham Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen,

D24224: Start of the accessibility KCM

tcanabrava added a comment. In D24224#537680 , @whiting wrote: > Thanks for taking this on Tomaz, Just throwing some ideas out but if it would help to have less tabs it might be useful to put all the keyboard features on one tab called Keyboard

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 66834. tcanabrava added a comment. - Make buttons work REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24224?vs=66831=66834 BRANCH kcm_acess REVISION DETAIL https://phabricator.kde.org/D24224 AFFECTED

D24224: Start of the accessibility KCM

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY This is a 1 - 1 translation of the QWidgets version of the Accessibility KCM - Most of the functionality is there, and the

D24187: WIP: Start of the accessibility KCM

tcanabrava updated this revision to Diff 66823. tcanabrava added a comment. - Remove the ui file - Rename kcm_access to kcmaccess - Fix typos - Qml Loads. Now, fix beaury - Fix imports and labels - Fix most layouts - Fix layout for the mouse navigation - Initial Working Gestures

D24187: WIP: Start of the accessibility KCM

tcanabrava updated this revision to Diff 66782. tcanabrava added a comment. - Initial Working Gestures REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24187?vs=66781=66782 BRANCH kcm_acess REVISION DETAIL https://phabricator.kde.org/D24187

D24187: WIP: Start of the accessibility KCM

tcanabrava updated this revision to Diff 66781. tcanabrava added a comment. - Rename kcm_access to kcmaccess - Fix typos - Qml Loads. Now, fix beaury - Fix imports and labels - Fix most layouts - Fix layout for the mouse navigation REPOSITORY R119 Plasma Desktop CHANGES SINCE

D24187: WIP: Start of the accessibility KCM

tcanabrava updated this revision to Diff 66758. tcanabrava added a comment. - Remove the ui file REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24187?vs=66746=66758 BRANCH kcm_acess REVISION DETAIL https://phabricator.kde.org/D24187 AFFECTED

D24187: WIP: Start of the accessibility KCM

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY please don't review it yet Remove uneeded Item Beginning of the Modifier Keys KeyboardFilters start

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 66643. tcanabrava added a comment. - Fix metadata installation - Fix model loading on Qml - Base work on the Qml - Name fixes - Move ui/main to contents - Fix wrong types in Qml - Plug the controllers - Link to the save button - Fix

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 66258. tcanabrava added a comment. - Fix metadata installation - Fix model loading on Qml - Base work on the Qml - Name fixes - Move ui/main to contents - Fix wrong types in Qml - Plug the controllers - Link to the save button REPOSITORY

D22762: Take in consideration flat() for the All Applications menu

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R120:b159222aa558: Take in consideration flat() for the All Applications menu (authored by tcanabrava). CHANGED PRIOR TO

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 65378. tcanabrava added a comment. - Name fixes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23718?vs=65375=65378 BRANCH kcm_baloo_qml REVISION DETAIL https://phabricator.kde.org/D23718 AFFECTED

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 65375. tcanabrava added a comment. - Fix metadata installation - Fix model loading on Qml - Base work on the Qml REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23718?vs=65369=65375 BRANCH kcm_baloo_qml

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH kcm_baloo_qml REVISION DETAIL https://phabricator.kde.org/D23718 AFFECTED FILES

D23461: Remove 'magic' filtering of recent apps

tcanabrava added a comment. @ngraham I agree with you completely. it's basically removing a bit of code, smaller patch and the code behaves without surprises. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23461 To: tcanabrava, hein, davidedmundson Cc:

D23461: Remove 'magic' filtering of recent apps

tcanabrava updated this revision to Diff 64818. tcanabrava added a comment. - Revert "Remove filtering of recent apps that are in the favorites" - Add a new Q_PROPERTY to the Recents Model to filter out or not favorites REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D23461: Remove 'magic' filtering of recent apps

tcanabrava added subscribers: ngraham, mart. tcanabrava added a comment. In D23461#520710 , @davidedmundson wrote: > > Is there a reason to change kicker? If not, it needs to be a property. There was a discussion a week ago with @mart

D23461: Remove 'magic' filtering of recent apps

tcanabrava updated this revision to Diff 64798. tcanabrava added a comment. - Revert "Remove 'magic' filtering of recent apps" - Remove filtering of recent apps that are in the favorites REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D23461: Remove 'magic' filtering of recent apps

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY The recent app wasn't displayed if it's recent *and* favorites. REPOSITORY R119 Plasma Desktop BRANCH

D22890: Add new class AllAppsModel that gives us a list of installed Apps

tcanabrava updated this revision to Diff 62965. tcanabrava added a comment. - Add copyright information and docs REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22890?vs=62964=62965 BRANCH allAppsModel REVISION DETAIL

D22890: Add new class AllAppsModel that gives us a list of installed Apps

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY The idea is to replace the rootModel.allAppsModel with this in the future, right now it's a way to not break the rootModel

D22762: Take in consideration flat() for the All Applications menu

tcanabrava added a comment. @hein I'll try to follow your approach. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22762 To: tcanabrava, davidedmundson, hein Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D22762: Take in consideration flat() for the All Applications menu

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0b9eb1e70c96: Take in consideration flat() for the All Applications menu (authored by tcanabrava). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22762: Take in consideration flat() for the All Applications menu

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH flatAllApps REVISION DETAIL https://phabricator.kde.org/D22762 AFFECTED FILES

D22445: WIP: Open from cache / Open Normally

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY Initial work to display the backtraces when plasma starts Parse the files on plasma startup to construct the file model

D22322: Store crash report automatically if shutting down

This revision was automatically updated to reflect the committed changes. tcanabrava marked 2 inline comments as done. Closed by commit R871:5c581620b5f7: Store crash report automatically if shutting down (authored by tcanabrava). CHANGED PRIOR TO COMMIT

D22322: Store crash report automatically if shutting down

tcanabrava updated this revision to Diff 61518. tcanabrava added a comment. - Add pid information to the log files - Store only the last 10 files in the cache directory REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22322?vs=61371=61518 BRANCH

D22322: Store crash report automatically if shutting down

tcanabrava updated this revision to Diff 61371. tcanabrava added a comment. - Add pid information to the log files - rebase REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22322?vs=61360=61371 BRANCH storeGuiless REVISION DETAIL

  1   2   >