[Differential] [Request, 50 lines] D4024: [System Tray] Trigger context menu on press

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Everywhere else context menus are trig

[Differential] [Closed] D4019: [ToolTipDialog] Use KWindowSystem::isPlatformX11() which is cached

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a0119858e400: [ToolTipDialog] Use KWindowSystem::isPlatformX11() which is cached (authored by broulik). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D401

[Differential] [Closed] D3971: RFC: Run first action on Shift+Return

This revision was automatically updated to reflect the committed changes. Closed by commit R112:c5216d347163: Run first action on Shift+Return (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3971?vs=9727&id=9864#toc REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE

[Differential] [Closed] D4011: [Icon Item] Fix updating implicit size when icon sizes change

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8875a04a1bbe: [Icon Item] Fix updating implicit size when icon sizes change (authored by broulik). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4011?vs=

[Differential] [Closed] D4009: [Dialog] Use setPosition / setSize instead of setting everything individually

This revision was automatically updated to reflect the committed changes. Closed by commit R242:4b55493568b1: [Dialog] Use setPosition / setSize instead of setting everything individually (authored by broulik). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.k

[Differential] [Closed] D4001: [Image Wallpaper] Simplify width/height management

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f6ce91499a16: [Image Wallpaper] Simplify width/height management (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4001?vs=9825&id=9861

[Differential] [Closed] D4012: Introduce Units singleton

This revision was automatically updated to reflect the committed changes. Closed by commit R242:56773014e157: Introduce Units singleton (authored by broulik). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4012?vs=9857&id=9859 REVISION DETAIL http

[Differential] [Closed] D4013: [Units] Make iconSizes property constant

This revision was automatically updated to reflect the committed changes. Closed by commit R242:4479fdab7fff: [Units] Make iconSizes property constant (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4013?vs=9842&id=9860#toc REPOSITORY R242 Plasma Frameworks CHANG

[Differential] [Commented On] D3738: [Task Manager] Tooltips redesign

broulik added a comment. I like thew new layout a lot, it might let me keeping them enabled! :D Good job. Few nitpicks: - Font color of the large heading in the tooltip is darker/stronger, I think Heading (used in the default tooltip) sets some opacity making it softer - Descender

[Differential] [Updated] D4012: Introduce Units singleton

broulik marked an inline comment as done. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4012 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, markg, davidedmundson, #plasma Cc: markg, plasma-devel, #frameworks, le

[Differential] [Updated] D4012: Introduce Units singleton

broulik marked 3 inline comments as done. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4012 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, markg, davidedmundson, #plasma Cc: markg, plasma-devel, #frameworks, le

[Differential] [Updated, 33 lines] D4012: Introduce Units singleton

broulik updated this revision to Diff 9857. broulik added a comment. - Return reference instead of ptr - Rename to "instance" - Disable move and stuff REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4012?vs=9846&id=9857 REVISION DETAIL https

[Differential] [Commented On] D4012: Introduce Units singleton

broulik added a comment. I was actually thinking about using the "proper" singleton way but didn't want it to be inconsistent with everywhere else. But, yeah, I'll do that. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4012 EMAIL PREFERENCES https://ph

[Differential] [Request, 13 lines] D4019: [ToolTipDialog] Use KWindowSystem::isPlatformX11() which is cached

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY I think it's wr

[Differential] [Commented On] D3822: use a native event filter to notice the screen was swapped

broulik added inline comments. INLINE COMMENTS > screenpool.cpp:188 > + > +const xcb_query_extension_reply_t* reply = > xcb_get_extension_data(QX11Info::connection(), &xcb_randr_id); > + Is that call to X really neccessary everytime? It's called constantly for all kinds of events. Also at

[Differential] [Request, 2 lines] D4017: Break from loop once we've found a Layout

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY There's no poin

[Differential] [Accepted] D4010: Don't register ConfigModel twice

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks BRANCH master REVISION DETAIL https://phabricator.kde.org/D4010 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Updated, 30 lines] D4012: Introduce Units singleton

broulik updated this revision to Diff 9846. broulik added a comment. - Q_DISABLE_COPY - Make constructor private REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4012?vs=9841&id=9846 REVISION DETAIL https://phabricator.kde.org/D4012 AFFECTED F

[Differential] [Request, 4 lines] D4013: [Units] Make iconSizes property constant

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY It's not the pr

[Differential] [Request, 26 lines] D4012: Introduce Units singleton

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Every single (F

[Differential] [Request, 51 lines] D4011: [Icon Item] Fix updating implicit size when icon sizes change

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The old code wa

[Differential] [Request, 7 lines] D4009: [Dialog] Use setPosition / setSize instead of setting everything individually

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Reduces the amo

[Differential] [Updated] D4001: [Image Wallpaper] Simplify width/height management

broulik updated the summary for this revision. broulik updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4001 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: davide

[Differential] [Updated, 81 lines] D4001: [Image Wallpaper] Simplify width/height management

broulik updated this revision to Diff 9825. broulik added a comment. - Remove now unused m_size member, we just use m_targetSize REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4001?vs=9824&id=9825 REVISION DETAIL https://phabricator.kde.org/D400

[Differential] [Updated, 80 lines] D4001: [Image Wallpaper] Simplify width/height management

broulik updated this revision to Diff 9824. broulik marked an inline comment as done. broulik added a comment. - Use magic plasmoid.width/plasmoid.height - Emit change whenever property changes, ie. move outside of single image if statement - Drop now unused width/height also from slidesho

[Differential] [Request, 74 lines] D4001: [Image Wallpaper] Simplify width/height management

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Directly expose "targetSize" as proper

[Differential] [Commented On] D3085: Use DBusMenu if available

broulik added a comment. Meh. For the title bar button shouldn't matter, though, as there I create a new importer everytime you click the button, so the menu is always up-to-date. Dunno about the applet. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://p

[Differential] [Accepted] D3085: Use DBusMenu if available

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D3085 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, b

[Differential] [Commented On] D3992: Sync kicker tooltip icon to config setting

broulik added a comment. Patch looking fine but Eike had some reservations as the square icon stuff isn't in a version Plasma-desktop depends on, it might be running against the previous version where it will look crap. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL htt

[Differential] [Commented On] D3089: Restore global menu support

broulik added a comment. > to allow me to add the menu in the decoration, is this deliberately not available? No, I just haven't looked at the decorations KCM at all yet. I think we should also add the menu button to the default button order so that when you enable it you get it automat

[Differential] [Updated, 187 lines] D3088: [KDecoration] Restore application menu button

broulik updated this revision to Diff 9783. broulik added a comment. - Add basic autotest that verifies that clicking the app menu button results in an application menu request REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3088?vs=9782&i

[Differential] [Updated, 131 lines] D3088: [KDecoration] Restore application menu button

broulik updated this revision to Diff 9782. broulik added a comment. - Introduce subclass (admittedly with a quite a long name) to avoid adding new virtuals in exported class REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3088?vs=9772&id=

[Differential] [Abandoned] D3156: WIP: Application Menu applet

broulik abandoned this revision. broulik added a comment. Superseded by https://phabricator.kde.org/D3706 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3156 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #pla

[Differential] [Updated, 97 lines] D3088: [KDecoration] Restore application menu button

broulik updated this revision to Diff 9772. broulik added a comment. - Pass through actionId argument REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3088?vs=7574&id=9772 REVISION DETAIL https://phabricator.kde.org/D3088 AFFECTED FILES

[Differential] [Updated, 449 lines] D3089: Restore global menu support

broulik updated this revision to Diff 9771. broulik added a comment. Restricted Application edited projects, added KWin; removed Plasma. - Route through the "actionId" argument - this way an application can tell which submenu to highlight/open (e.g. Alt keyboard activation) REPOSITORY R108

[Differential] [Closed] D3086: Clean up KAppMenu

This revision was automatically updated to reflect the committed changes. Closed by commit R120:90de42f2976c: Clean up KAppMenu (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3086?vs=7784&id=9767 REVISION DETAIL https://phabri

[Differential] [Commented On] D3086: Clean up KAppMenu

broulik added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3086 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterbe

[Differential] [Commented On] D3088: [KDecoration] Restore application menu button

broulik added a comment. What shall we do with this (the new virtual) now? REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D3088 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: sitter, graess

[Differential] [Request, 3 lines] D3982: [Panel Containment] Correctly compare applets without order

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When comparing two applet

[Differential] [Commented On] D3834: [Panel Containment] Replace restore order logic by "algorithms"

broulik added a comment. > I think it's this part: > > appletsOrder["unordered"+i] = plasmoid.applets[i] My loop sorts elements that have no index last, maybe that's wrong somehow? It worked for me for when an applet isn't ordered yet but I can reproduce that adding a new "default

[Differential] [Changed Subscribers] D3257: Close the system tray on escape - system tray

broulik added inline comments. INLINE COMMENTS > mart wrote in PlasmoidPopupsContainer.qml:30 > wouldn't this break keyboard navigation in an item if supported? (like going > up and down in the device list in the device notifier) It did break it. I can no longer automatically type in Klipper or

[Differential] [Closed] D3893: [Folder View] Let IconItem take entire delegate width

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2d2f33a915d3: [Folder View] Let IconItem take entire delegate width (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3893?vs=9563&id=976

[Differential] [Closed] D3892: [Icon Item] Support non-square icons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:d46a91ea57f1: [Icon Item] Support non-square icons (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3892?vs=9658&id=9760#toc REPOSITORY R242 Plasma Frameworks CHANGES S

[Differential] [Closed] D3958: [PackageLoader] Don't access invalid KPluginMetadata

This revision was automatically updated to reflect the committed changes. Closed by commit R290:8391e022e0f0: [PackageLoader] Don't access invalid KPluginMetadata (authored by broulik). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3958?vs=9708&id=9756 REVI

[Differential] [Commented On] D3971: RFC: Run first action on Shift+Return

broulik added a comment. That's why I mention it in the tooltip, so when one wonders "huh, what is this icon on the right?" sees "ooh, Shift+Enter triggers it too!" REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D3971 EMAIL PREFERENCES https://phabricator.kde.org/se

[Differential] [Updated] D3302: [Task Manager] Indicate applications playing audio

broulik updated the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3302 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, drosca, hein Cc: subdiff, apol, colomar,

[Differential] [Updated, 287 lines] D3302: [Task Manager] Indicate applications playing audio

broulik updated this revision to Diff 9750. broulik added a comment. - Improve visuals for icon-only mode - Put Audio Icon into separate qml file REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3302?vs=8026&id=9750 REVISION DETAIL https://phabric

[Differential] [Abandoned] D3910: [Kicker] Don't nuke favorites on startup

broulik abandoned this revision. broulik added a comment. Superseded by https://phabricator.kde.org/D3979 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3910 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, mart,

[Differential] [Accepted] D3979: Fix race condition causing empty favorites.

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3979 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, broulik, #plasma Cc:

[Differential] [Accepted] D3973: wallpapers/image: Use QImageReader in ImageSizeFinder::run()

broulik accepted this revision. broulik added a reviewer: broulik. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3973 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fredrik, #plasma, davidedmundson, broulik Cc: davidedmun

[Differential] [Closed] D3651: Add utility to send broadcast notifications

This revision was automatically updated to reflect the committed changes. Closed by commit R126:455e0209e6a7: Add utility to send broadcast notifications (authored by broulik). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3651?vs=8944&id=9730 REVI

[Differential] [Request, 21 lines] D3971: RFC: Run first action on Shift+Return

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to R112 Milou. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When pressing Shift+Return activat

[Differential] [Request, 1,886 lines] D3969: Kill audioplayercontrolrunner

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R114 Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is yet another mpris implementation

[Differential] [Request, 3 lines] D3968: [Fifteen Puzzle] Start timer on tile click, stop timer on shuffle

broulik created this revision. broulik added reviewers: Plasma, whiting. broulik set the repository for this revision to R114 Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This allows you to "Stop" a game

[Differential] [Request, 34 lines] D3967: [Fifteen Puzzle] Add "Browse" button

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R114 Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY There's a text field for entering a path

[Differential] [Closed] D3966: [Fifteen Puzzle] Animate moving of tiles

This revision was automatically updated to reflect the committed changes. Closed by commit R114:018062bb1294: [Fifteen Puzzle] Animate moving of tiles (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3966?vs=9720&id=9721 REVISION DE

[Differential] [Request, 13 lines] D3966: [Fifteen Puzzle] Animate moving of tiles

broulik created this revision. broulik added reviewers: Plasma, whiting. broulik set the repository for this revision to R114 Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Makes the game a lot nicer to loo

[Differential] [Closed] D3962: Add Appstream summary

This revision was automatically updated to reflect the committed changes. Closed by commit R166:a6f88a9170ef: Add Appstream summary (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3962?vs=9715&id=9719#toc REPOSITORY R166 Spectacle CHANGES SINCE LAST UPDATE https

[Differential] [Request, 1 line] D3962: Add Appstream summary

broulik created this revision. broulik added reviewers: Plasma, bgupta, mak. broulik set the repository for this revision to R166 Spectacle. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN As criticized on kde-devel by Richard Hu

[Differential] [Closed] D3961: [Fifteen Puzzle] Remove custom color picker

This revision was automatically updated to reflect the committed changes. Closed by commit R114:fb6a95332a3c: [Fifteen Puzzle] Remove custom color picker (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3961?vs=9711&id=9714 REVISION

[Differential] [Commented On] D3954: [MPRIS Data Engine] Don't crash if "Metadata" is a map but of wrong type

broulik added a comment. https://cgit.kde.org/plasma-workspace.git/commit/?h=Plasma/5.8&id=03374b185f9bd3bc4f70726ae641014a33278fdd REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3954 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Closed] D3954: [MPRIS Data Engine] Don't crash if "Metadata" is a map but of wrong type

broulik closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3954 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, j

[Differential] [Closed] D3959: [Windowed Widgets Runner] Fix check for whether applet is standalone-capable

This revision was automatically updated to reflect the committed changes. Closed by commit R120:52b1644c8a03: [Windowed Widgets Runner] Fix check for whether applet is standalone-capable (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde

[Differential] [Closed] D3960: [Windowed Widgets Runner] Set applet name instead of plugin ID as runner result text

This revision was automatically updated to reflect the committed changes. Closed by commit R120:04854c155df3: [Windowed Widgets Runner] Set applet name instead of plugin ID as runner result… (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator

[Differential] [Request, 69 lines] D3961: [Fifteen Puzzle] Remove custom color picker

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R114 Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The round color picker looked fancy but f

[Differential] [Commented On] D3959: [Windowed Widgets Runner] Fix check for whether applet is standalone-capable

broulik added a comment. Return "true" and "false" strings maybe? I *think* QVariant is even smart enough to case those to the respective bool values REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3959 EMAIL PREFERENCES https://phabricator.kde.org/settin

[Differential] [Request, 16 lines] D3960: [Windowed Widgets Runner] Set applet name instead of plugin ID as runner result text

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN I don't know how this ever worked but I recal

[Differential] [Request, 3 lines] D3959: [Windowed Widgets Runner] Fix check for whether applet is standalone-capable

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes yet another KPluginMetadata regr

[Differential] [Updated] D3958: [PackageLoader] Don't access invalid KPluginMetadata

broulik updated the test plan for this revision. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D3958 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, apol Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jen

[Differential] [Updated] D3958: [PackageLoader] Don't access invalid KPluginMetadata

broulik updated the test plan for this revision. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D3958 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, apol Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jen

[Differential] [Request, 4 lines] D3958: [PackageLoader] Don't access invalid KPluginMetadata

broulik created this revision. broulik added reviewers: Plasma, apol. broulik set the repository for this revision to R290 KPackage. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY BUG: 374541 TEST P

[Differential] [Updated] D3954: [MPRIS Data Engine] Don't crash if "Metadata" is a map but of wrong type

broulik updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3954 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg

[Differential] [Commented On] D3948: Add-app-to-panel string overhaul.

broulik added inline comments. INLINE COMMENTS > actionlist.cpp:144 > if (ContainmentInterface::mayAddLauncher(appletInterface, > ContainmentInterface::Panel)) { > -actionList << Kicker::createActionItem(i18n("Add to Panel"), > "addToPanel"); > } Perhaps "(Icon Widget)", or "

[Differential] [Request, 4 lines] D3954: [MPRIS Data Engine] Don't crash if "Metadata" is a map but of wrong type

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QDBusArgument MapType fits all kinds o

[Differential] [Updated, 85 lines] D3892: [Icon Item] Support non-square icons

broulik updated this revision to Diff 9658. broulik added a comment. Restricted Application added a subscriber: Frameworks. - Don't blindly round both sizes, instead round one and then scale the other accordingly - Adjust unit test REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPD

[Differential] [Updated, 122 lines] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

broulik updated this revision to Diff 9647. broulik added a comment. - Only offer Open With when for protocols that support listing (avoids it trying to open the "parent folder" of a website url) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3905

[Differential] [Abandoned] D3908: [Look and feel KCM] Notify PaletteChange on DBus

broulik abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3908 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Requested Changes To] D3933: Run all selected items on Enter/Return.

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > FolderView.qml:671 > if (currentIndex != -1 && dir.hasSelection()) { > -var func = root.useListViewMode ? dir.cd

[Differential] [Accepted] D3933: Run all selected items on Enter/Return.

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > foldermodel.cpp:527 > +foreach (const QModelIndex &index, m_selectionModel->selectedIndexes()) > +{ > +run(index.row()); Put { on same line REPOSITOR

[Differential] [Accepted] D3932: Set current index to start of selection range when performing rectangle selection.

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3932 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, broulik, #plasma

[Differential] [Accepted] D3926: Move SNI's libdbusmenu-qt fork to the root directory and use that for appmenu too

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3926 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferen

[Differential] [Updated, 119 lines] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

broulik updated this revision to Diff 9638. broulik added a comment. - Parent jump list QAction to the applet not to leak them REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3905?vs=9637&id=9638 REVISION DETAIL https://phabricator.kde.org/D3905

[Differential] [Updated, 119 lines] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

broulik updated this revision to Diff 9637. broulik added a comment. - assign nullptr after delete REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3905?vs=9580&id=9637 REVISION DETAIL https://phabricator.kde.org/D3905 AFFECTED FILES applets/ic

[Differential] [Commented On] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

broulik added a comment. > for deskto files that points to an app shortcut those two entries would not be added, right? Yes, "Open With" for apps doesn't make sense (what, open desktop file in editor?) and "Open containing folder" would open /usr/share/applications, very useful ;) REPO

[Differential] [Closed] D3906: [Icon Applet] Fully re-populate when user changes Link URL

This revision was automatically updated to reflect the committed changes. Closed by commit R120:53c4f98a3391: [Icon Applet] Fully re-populate when user changes Link URL (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3906?vs=9582

[Differential] [Closed] D3897: [Panel Containment] Explicitly bind visible on both the container and the applet

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d674ede6e5f2: [Panel Containment] Explicitly bind visible on both the container and the applet (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.k

[Differential] [Closed] D3816: [Task Manager] Parent QAction to "parent" instead of this

This revision was automatically updated to reflect the committed changes. Closed by commit R119:58e932c607db: [Task Manager] Parent QAction to "parent" instead of this (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3816?vs=9371&id

[Differential] [Closed] D3911: [Containment Appearance] Make sure to always load a config view

This revision was automatically updated to reflect the committed changes. Closed by commit R119:76ac242c37b7: [Containment Appearance] Make sure to always load a config view (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3911?vs=9

[Differential] [Closed] D3902: Fix X-Plasma-Drop* types

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a0f3d2429d0a: Fix X-Plasma-Drop* types (authored by broulik). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3902?vs=9576&id=9630 REVISION DETAIL https

[Differential] [Commented On] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

broulik added inline comments. INLINE COMMENTS > hein wrote in main.xml:78 > We have KActivitiesStats to track access frequency of locations, doing this > in the TM applet is wrong. I propose you add KActivitieStats support to the > places model and add a sort mode using it. I don't want to ch

[Differential] [Request, 5 lines] D3911: [Containment Appearance] Make sure to always load a config view

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If StackView is empty, currentItem will

[Differential] [Request, 11 lines] D3910: [Kicker] Don't nuke favorites on startup

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Likely race introduced by using QQm

[Differential] [Changed Subscribers] D3822: use a native event filter to notice the screen was swapped

broulik added inline comments. INLINE COMMENTS > screenpool.cpp:37 > { > +qApp->installNativeEventFilter(this); > + No need to install if not on X? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3822 EMAIL PREFERENCES https://phabricator.kde.org/setti

[Differential] [Commented On] D3908: [Look and feel KCM] Notify PaletteChange on DBus

broulik added a comment. Hmm, still able to reproduce the bug at times :/ No idea why it only affects plasmashell context menus, though. Other apps like Dolphin pick up the color right away. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3908 EMAIL PREFEREN

[Differential] [Request, 9 lines] D3908: [Look and feel KCM] Notify PaletteChange on DBus

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Code taken from Colors KCM. BUG: 37

[Differential] [Request, 9 lines] D3906: [Icon Applet] Fully re-populate when user changes Link URL

broulik created this revision. broulik added reviewers: Plasma, dfaure. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When applying KPropertiesDialog

[Differential] [Accepted] D3904: MediaController: Stop queuedPositionUpdate timer when receiving mpris position change

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH mediacontroller-fix1 (branched from Plasma/5.8) REVISION DETAIL https://phabricator.kde.org/D3904 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpr

[Differential] [Request, 119 lines] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This adds the "Open Wit

[Differential] [Updated, 62 lines] D3892: [Icon Item] Support non-square icons

broulik updated this revision to Diff 9577. REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3892?vs=9561&id=9577 REVISION DETAIL https://phabricator.kde.org/D3892 AFFECTED FILES autotests/iconitemtest.cpp autotests/iconitemtest.h src/declarat

[Differential] [Request, 10 lines] D3902: Fix X-Plasma-Drop* types

broulik created this revision. broulik added reviewers: Plasma, apol. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY They are supposed to

  1   2   3   4   5   6   7   8   9   10   >