[Differential] [Closed] D3991: kstart: Port away from K4AboutData

2017-01-06 Thread heikobecker (Heiko Becker)
This revision was automatically updated to reflect the committed changes. Closed by commit R126:da328d6cada1: kstart: Port away from K4AboutData (authored by heikobecker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3991?vs=9796&id=9805#toc REPOSITORY R126 KDE CLI Utilities CHANGES

[Differential] [Request, 157 lines] D3991: kstart: Port away from K4AboutData

2017-01-06 Thread heikobecker (Heiko Becker)
heikobecker created this revision. heikobecker added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY kstart: Port away from K4AboutData kstart: Remove remaining bits of KDELibs4Support REPOSITORY R

[Differential] [Closed] D3734: Search for KF5Kirigami2 instead of KF5Kirigami

2016-12-19 Thread heikobecker (Heiko Becker)
This revision was automatically updated to reflect the committed changes. Closed by commit R134:596589da77ec: Search for KF5Kirigami2 instead of KF5Kirigami (authored by heikobecker). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3734?vs=9171&

[Differential] [Request, 4 lines] D3734: Search for KF5Kirigami2 instead of KF5Kirigami

2016-12-19 Thread heikobecker (Heiko Becker)
heikobecker created this revision. heikobecker added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY plasma-discover crashes if it isn't present. REPOSITORY R134 Discover Software Store BRANCH mas

[Differential] [Closed] D3701: cmake: Raise KF5 requirement to 5.29.0

2016-12-16 Thread heikobecker (Heiko Becker)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:bf1dfd4da511: cmake: Raise KF5 requirement to 5.29.0 (authored by heikobecker). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3701?vs=9064&id=9067 REVISI

[Differential] [Request, 2 lines] D3701: cmake: Raise KF5 requirement to 5.29.0

2016-12-16 Thread heikobecker (Heiko Becker)
heikobecker created this revision. heikobecker added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY At least kwindowsystem-5.29.0 is needed since https://phabricator.kde.org/R120:bbbce3a55e011bd9d3c5

[Differential] [Closed] D3478: Port away from KDELibs4Support

2016-11-23 Thread heikobecker (Heiko Becker)
This revision was automatically updated to reflect the committed changes. Closed by commit rKGAMMAb1a14d377405: Port away from KDELibs4Support (authored by heikobecker). REPOSITORY rKGAMMA KGamma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3478?vs=8458&id=8459 REVISION DETAIL h

[Differential] [Request, 22 lines] D3478: Port away from KDELibs4Support

2016-11-23 Thread heikobecker (Heiko Becker)
heikobecker created this revision. heikobecker added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY By - using KPluginFactory instead of the deprecated KGenericFactory - replacing KHBox with QWi

[Differential] [Closed] D2781: Use KDE_INSTALL_DATAROOTDIR

2016-09-15 Thread heikobecker (Heiko Becker)
This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI3f2db19b3544: Use KDE_INSTALL_DATAROOTDIR (authored by heikobecker). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2781?vs=6748&id=6766 REVISION DETAIL

[Differential] [Request, 2 lines] D2781: Use KDE_INSTALL_DATAROOTDIR

2016-09-14 Thread heikobecker (Heiko Becker)
heikobecker created this revision. heikobecker added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY ...instead of hard-coding CMAKE_INSTALL_PREFIX. TEST PLAN Files are installed into the de

[Differential] [Closed] D2564: Find KF5Wayland with other frameworks

2016-08-24 Thread heikobecker (Heiko Becker)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEfce38e25062f: Find KF5Wayland with other frameworks (authored by heikobecker). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2564?v

[Differential] [Closed] D2563: Include KDECompilerSettings earlier to silence cmake warning

2016-08-24 Thread heikobecker (Heiko Becker)
This revision was automatically updated to reflect the committed changes. Closed by commit rKDECLITOOLSf24fb29f91fe: Include KDECompilerSettings earlier to silence cmake warning (authored by heikobecker). REPOSITORY rKDECLITOOLS KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator

[Differential] [Closed] D2562: Use KDE_INSTALL_DATADIR instead of hard-coding CMAKE_INSTALL_PREFIX

2016-08-24 Thread heikobecker (Heiko Becker)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATIONfd1b24f202c4: Use KDE_INSTALL_KCONFUPDATEDIR instead of hard-coding CMAKE_INSTALL_PREFIX (authored by heikobecker). REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasm

[Differential] [Request, 7 lines] D2564: Find KF5Wayland with other frameworks

2016-08-24 Thread heikobecker (Heiko Becker)
heikobecker created this revision. heikobecker added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2564 AF

[Differential] [Request, 2 lines] D2563: Include KDECompilerSettings earlier to silence cmake warning

2016-08-24 Thread heikobecker (Heiko Becker)
heikobecker created this revision. heikobecker added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It needs to be placed before find_package(KF5Init) in this case because of KF5InitMacros. Otherwise

[Differential] [Updated] D2562: Use KDE_INSTALL_DATADIR instead of hard-coding CMAKE_INSTALL_PREFIX

2016-08-24 Thread heikobecker (Heiko Becker)
heikobecker added a reviewer: Plasma. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D2562 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #plasma Cc: plasma-devel, lesliez

[Differential] [Updated, 4 lines] D2562: Use KDE_INSTALL_DATADIR instead of hard-coding CMAKE_INSTALL_PREFIX

2016-08-24 Thread heikobecker (Heiko Becker)
heikobecker updated this revision to Diff 6237. heikobecker added a comment. s/DATADIR/KCONFUPDATEDIR/ REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2562?vs=6227&id=6237 BRANCH master REVISION DETAIL ht

[Differential] [Request, 4 lines] D2562: Use KDE_INSTALL_DATADIR instead of hard-coding CMAKE_INSTALL_PREFIX

2016-08-24 Thread heikobecker (Heiko Becker)
heikobecker created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D2562 AFFECTED FILE

[Differential] [Commented On] D2377: use the feature summary to communicate runtime deps

2016-08-09 Thread heikobecker (Heiko Becker)
heikobecker added a comment. In https://phabricator.kde.org/D2377#44495, @sitter wrote: > In https://phabricator.kde.org/D2377#44484, @heikobecker wrote: > > > So I think two Find... modules are also needed or "message..." should stay. > > > Well. No. > > https://cmake.org/c

[Differential] [Commented On] D2377: use the feature summary to communicate runtime deps

2016-08-09 Thread heikobecker (Heiko Becker)
heikobecker added a comment. I like packages stating their dependencies (even runtime ones) because that's where I look first as a packager. But if I'm not missing something (maybe a git add?) this change is a bit misleading because they can never be found. So I think two Find... modules are

[Differential] [Closed] D1944: Make NetworkManagerQt and BluezQt optional

2016-06-18 Thread heikobecker (Heiko Becker)
This revision was automatically updated to reflect the committed changes. Closed by commit rPOWERDEVIL3257be562b2c: Make NetworkManagerQt and BluezQt optional (authored by heikobecker). REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1944?vs=4604&id=4

[Differential] [Commented On] D1944: Make NetworkManagerQt and BluezQt optional

2016-06-18 Thread heikobecker (Heiko Becker)
heikobecker added a comment. > Yes. What dependencies are causing problems for you? NetworkManager and its dependencies mostly. If I compare the situation to kwin and kscreenlocker, for example, and its hard dependency on wayland there's an obvious benefit and wayland is rather small in

[Differential] [Commented On] D1944: Make NetworkManagerQt and BluezQt optional

2016-06-18 Thread heikobecker (Heiko Becker)
heikobecker added a comment. In https://phabricator.kde.org/D1944#35784, @broulik wrote: > We've been through the "make action optional" dance with DPMS in the past and it has been a maintenance nightmare. Sure, in the end you're the maintainer. > The action checks for whethe

[Differential] [Request, 61 lines] D1944: Make NetworkManagerQt and BluezQt optional

2016-06-18 Thread heikobecker (Heiko Becker)
heikobecker created this revision. heikobecker added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY While it is most certainly sensible and helpful on a system equipped with Bluetooth and Wi-

[Differential] [Closed] D851: Port kded plugin to json metadata

2016-01-24 Thread heikobecker (Heiko Becker)
This revision was automatically updated to reflect the committed changes. Closed by commit rKWRITED5fd327369bc6: Port kded plugin to json metadata (authored by heikobecker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D851?vs=2062&id=2081#toc REPOSITORY rKWRITED KWriteD CHANGES SINC

[Differential] [Updated, 174 lines] D851: Port kded plugin to json metadata

2016-01-22 Thread heikobecker (Heiko Becker)
heikobecker updated this revision to Diff 2062. heikobecker added a comment. Used suggested kcoreaddons_add_plugin REPOSITORY rKWRITED KWriteD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D851?vs=2058&id=2062 BRANCH master REVISION DETAIL https://phabricator.kde.org/D851 AFF

[Differential] [Request, 11 lines] D851: Port kded plugin to json metadata

2016-01-21 Thread heikobecker (Heiko Becker)
heikobecker created this revision. heikobecker added a reviewer: plasma-devel. REPOSITORY rKWRITED KWriteD BRANCH master REVISION DETAIL https://phabricator.kde.org/D851 AFFECTED FILES CMakeLists.txt kwrited.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref