[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

2016-12-28 Thread knambiar (Rajeesh K Nambiar)
knambiar added a comment. Might this change fix this issue? https://bugs.kde.org/show_bug.cgi?id=370588 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, davi

[Differential] [Commented On] D3617: [Touchpad KCM] New KWin Wayland version

2016-12-08 Thread knambiar (Rajeesh K Nambiar)
knambiar added a comment. A query about the dbus calls in findTouchpads(). INLINE COMMENTS > kwinwaylandbackend.cpp:72 > +QStringList devicesSysNames; > +QVariant reply = m_deviceManager->property("devicesSysNames"); > +if (reply.isValid()) { Just wondering whether these calls ar

[Differential] [Commented On] D2754: Touchpad KDED: fix metadata warning

2016-09-13 Thread knambiar (Rajeesh K Nambiar)
knambiar added a comment. Thanks for the review, but actually I am not convinced that this gets rid of the warning message. Sifting through the KF5 porting notes, I am not sure how this should be handled -- kded tries to load the plugin with just "name" and if not found it looks for "kded_na

[Differential] [Request, 1 line] D2754: Touchpad KDED: fix metadata warning

2016-09-12 Thread knambiar (Rajeesh K Nambiar)
knambiar created this revision. knambiar added a reviewer: Plasma. knambiar set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Get rid of kded warning: