markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.
Looks nice and clean to me now :)
Nice job!
REPOSITORY
R242 Plasma Frameworks
REVISION DETAIL
https://phabricator.kde.org/D4012
EMAIL PREFERENCES
https://phabricator.kde.org/settings
markg added inline comments.
INLINE COMMENTS
> tooltipdialog.cpp:116-118
> +if (KWindowSystem::isPlatformX11()) {
> flags = flags | Qt::BypassWindowManagerHint;
> }
Isn't this redundant anyway?
It's being set in the constructor as well.
The constructor only deviates in initial
markg requested changes to this revision.
markg added a reviewer: markg.
markg added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> units.cpp:61
> SharedAppFilter *Units::s_sharedAppFilter = nullptr;
> +Units *Units::s_self = nullptr;
>
Remove this line if y
markg added inline comments.
INLINE COMMENTS
src/context.cpp:424 You can merge this one and the earlier isNew i think.
Something like:
```
auto result = m_sinkInputs.data().constFind(eventRoleIndex);
if (result == m_sinkInputs.data().constEnd()) {
emit m_sinkInputs.added(
