[Differential] [Accepted] D3992: Sync kicker tooltip icon to config setting

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3992 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: d

[Differential] [Updated, 7 lines] D3981: better clean up of duplicate containments

mart updated this revision to Diff 9766. mart added a comment. - remove the disconnect REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3981?vs=9759&id=9766 BRANCH phab/cleanupcontainments REVISION DETAIL https://phabricator.kde.org/D3981 AFFE

[Differential] [Commented On] D3981: better clean up of duplicate containments

mart added inline comments. INLINE COMMENTS > mart wrote in shellcorona.cpp:1922 > i could just remove that disconnect, the thing is, i'm always hesitant to > change things in ways that may have had a reason. > that disconenct was added somewhere back in 2014, i can test removing it if > it sti

[Differential] [Commented On] D3981: better clean up of duplicate containments

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in shellcorona.cpp:1909 > > catches also containments of other activities > > No it doesn't - you're looping through m_desktopContainments.value(activity) >so only things of the same activity. > Either your comment is nonse

[Differential] [Commented On] D3981: better clean up of duplicate containments

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in shellcorona.cpp:1922 > Why are you doing this? cont is being deleted there, i'm making sure it's not in m_desktopContainments anymore for not even an instant. desktopContainmentDestroyed wasn't even called before as it's disc

[Differential] [Updated] D3981: better clean up of duplicate containments

mart updated the summary for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3981 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts

[Differential] [Request, 4 lines] D3981: better clean up of duplicate containments

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY due to old multiscreen bugs, sometimes the appletsrc file gets polluted with a lot of containments with same acti

[Differential] [Accepted] D3971: RFC: Run first action on Shift+Return

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. anyways, for me, i like it, if there isn't anybody with a significant complaint, go for it REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D3

[Differential] [Accepted] D3969: Kill audioplayercontrolrunner

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. :''( ooh, well, so long REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3969 EMAIL PREFERENCES https://phabricator.kde.org/se

[Differential] [Accepted] D3967: [Fifteen Puzzle] Add "Browse" button

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3967 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, m

[Differential] [Accepted] D3968: [Fifteen Puzzle] Start timer on tile click, stop timer on shuffle

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3968 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, w

[Differential] [Commented On] D3971: RFC: Run first action on Shift+Return

mart added a comment. I like it.. it's a very hidden feature tough, one of the nice things but that noone notices :/ REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D3971 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #

[Differential] [Accepted] D3975: Add high DPI support to kfontview and kfontinst KCM

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3975 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: d

[Differential] [Accepted] D3976: And enable high DPI on the icons in kfontview

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3976 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: d

[Differential] [Accepted] D3963: Fix syncing of geometry to internal window when using ::move

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. BRANCH move-internal-window REVISION DETAIL https://phabricator.kde.org/D3963 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #pl

[Differential] [Accepted] D3966: [Fifteen Puzzle] Animate moving of tiles

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. love this little whimsical things, we should pay more attention to such details :D REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3

[Differential] [Accepted] D3962: Add Appstream summary

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R166 Spectacle REVISION DETAIL https://phabricator.kde.org/D3962 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, bgupt

[Differential] [Accepted] D3958: [PackageLoader] Don't access invalid KPluginMetadata

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D3958 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, apol,

plasma-devel@kde.org

This revision was automatically updated to reflect the committed changes. Closed by commit R118:229803bec3e5: export kwin theme to l&f (authored by mart). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3833?vs=9449&id=9701 REVISION DETAIL https://phabrica

[Differential] [Accepted] D3939: fix description for option -t in man page

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D3939 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: lueck, #plasma, #framewo

[Differential] [Accepted] D3953: Improve error message

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D3953 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, mart Cc: plasma-devel

[Differential] [Accepted] D3948: Add-app-to-panel string overhaul.

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3948 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, broulik, mart C

[Differential] [Accepted] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3950 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

plasma-devel@kde.org

This revision was automatically updated to reflect the committed changes. Closed by commit R119:81be6962b1e4: import kwin deco and button order in l&f (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3832?vs=9662&id=9699 REVISION DETA

[Differential] [Accepted] D3947: Clean up after a window delegate drag exits the window.

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3947 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ T

[Differential] [Closed] D3936: use KPluginMetaData::readStringList()

This revision was automatically updated to reflect the committed changes. Closed by commit R242:94edfa149f1d: use KPluginMetaData::readStringList() (authored by mart). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3936?vs=9660&id=9663 REVISION DETA

plasma-devel@kde.org

mart added inline comments. INLINE COMMENTS > graesslin wrote in kcm.cpp:342 > I think you got that part wrong. The difference is the value passed to > library. eew, sorry, that's what you get for writing that before cofee :/ REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabrica

plasma-devel@kde.org

mart updated this revision to Diff 9662. mart added a comment. - the ifdef should be at setWindowDecoration REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3832?vs=9650&id=9662 BRANCH arcpatch-D3832 REVISION DETAIL https://phabricator.kde.org/D3

[Differential] [Commented On] D3892: [Icon Item] Support non-square icons

mart added a comment. +1 from me REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3892 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, hein Cc: #frameworks, mart, davidedmundson, plasma-devel, lesliezha

[Differential] [Request, 10 lines] D3936: use KPluginMetaData::readStringList()

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY replace the last remaining place in pluginloader where a string list was read as a normal s

[Differential] [Updated] D3936: use KPluginMetaData::readStringList()

mart added a reviewer: broulik. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3936 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, broulik Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterb

[Differential] [Accepted] D3928: Sync opacity from an internal QWindow to its ShellClient

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH opacity-internal-window REVISION DETAIL https://phabricator.kde.org/D3928 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D3630: [Digital Clock] Bug fixes and ui code optimization

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3630 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma, mart Cc: mart, plasma-devel

[Differential] [Accepted] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3905 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

[Differential] [Accepted] D3917: AppletConfig: Use correct icon state for category icons

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3917 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: d

[Differential] [Accepted] D3914: Rename expander icon tooltip to "close popup" to close the popup

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3914 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

plasma-devel@kde.org

mart updated this revision to Diff 9650. mart added a comment. - use proper breeze plugin id if found REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3832?vs=9479&id=9650 BRANCH arcpatch-D3832 REVISION DETAIL https://phabricator.kde.org/D3832 A

plasma-devel@kde.org

mart added inline comments. INLINE COMMENTS > graesslin wrote in kcm.cpp:337 > what remains is that this is not the default used in KWin. > > In KWin it's: > > static const QString s_aurorae = QStringLiteral("org.kde.kwin.aurorae"); > static const QString s_pluginName = QStringLiteral("org.

[Differential] [Closed] D3934: Fix the help message for --type

This revision was automatically updated to reflect the committed changes. Closed by commit R290:d04769cf7459: Fix the help message for --type (authored by mart). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3934?vs=9648&id=9649 REVISION DETAIL https://ph

[Differential] [Request, 2 lines] D3934: Fix the help message for --type

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY the type as "package", "wallpaper", "theme" was coming from the old plasmapkg2 tool, which

[Differential] [Requested Changes To] D3630: [Digital Clock] Bug fixes and ui code optimization

mart requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3630 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma, mart Cc: mart, pl

[Differential] [Commented On] D3630: [Digital Clock] Bug fixes and ui code optimization

mart added a comment. the problem for me is sizehelper having a wrong size when the state is horizontalPanelSmall if i add an huge pixelSize to sizehelper (as it was used to have), the layout problem is fixed INLINE COMMENTS > DigitalClock.qml:531 > font.italic: timeLabel.font

[Differential] [Commented On] D3630: [Digital Clock] Bug fixes and ui code optimization

mart added a comment. I'm afraid we're still not there: if i slowly resize the panel, for most sized is ok, but if i get it just the right size, that's what i get: F1712327: Spectacle.C23157.png REPOSITORY R120 Plasma Workspace REVISION DETAIL htt

[Differential] [Accepted] D3915: Sync startplasma with a startkde change

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3915 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D3911: [Containment Appearance] Make sure to always load a config view

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3911 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Updated] D3805: Per-activity favorites (WIP)

mart added a comment. probably needs to be rebased for eventual conflicts with https://phabricator.kde.org/D3910 REVISION DETAIL https://phabricator.kde.org/D3805 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, hein, mart Cc: plasma-devel, leslie

[Differential] [Accepted] D3910: [Kicker] Don't nuke favorites on startup

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3910 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Commented On] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

mart added a comment. if i understood correctly the code, for deskto files that points to an app shortcut those two entries would not be added, right? (that's i think how it should work) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3905 EMAIL PREFERENCE

[Differential] [Accepted] D3893: [Folder View] Let IconItem take entire delegate width

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. +100 as soon as https://phabricator.kde.org/D3892 can go in REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3893 EMAIL PREFERENCES

[Differential] [Accepted] D3878: Use removeOne when uninstalling an InputEventFilter

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. fine as the asserts guards more than one is never added INLINE COMMENTS > input.cpp:1378 > > void InputRedirection::prepandInputEventFilter(InputEventFilter *fil

[Differential] [Changed Subscribers] D3892: [Icon Item] Support non-square icons

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in iconitem.cpp:325 > This makes no sense. > You can't round it to icon sizes *after* scaling, it means the shorter size > is always just wrong. > > If we do merge this patch, you want: > > m_iconPixmap.size().scaled(QSize(Unit

[Differential] [Accepted] D3877: Use a templated approach for InputRedirection::processFilters

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH input-event-filter-process-predicate REVISION DETAIL https://phabricator.kde.org/D3877 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emai

[Differential] [Updated] D3805: Per-activity favorites (WIP)

mart added a comment. anyways, i don't see evident issues in the code, +1 for me, maybe wait Eike is back, but looking good REVISION DETAIL https://phabricator.kde.org/D3805 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, hein, mart Cc: plasma-de

[Differential] [Accepted] D3847: SWT/Eclipse toolbar fix

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D3847 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jsalatas, #breeze,

plasma-devel@kde.org

mart updated this revision to Diff 9479. mart added a comment. - add unmanaged case REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3832?vs=9478&id=9479 BRANCH phab/kwinlnf REVISION DETAIL https://phabricator.kde.org/D3832 AFFECTED FILES kcms

plasma-devel@kde.org

mart updated this revision to Diff 9478. mart added a comment. - call kwin config reload only once REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3832?vs=9442&id=9478 BRANCH phab/kwinlnf REVISION DETAIL https://phabricator.kde.org/D3832 AFFECT

plasma-devel@kde.org

mart added inline comments. INLINE COMMENTS > graesslin wrote in kcm.cpp:642-646 > in KWin? eh, no, please not. nono, i meant in the kcm :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3832 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

plasma-devel@kde.org

mart added inline comments. INLINE COMMENTS > graesslin wrote in kcm.cpp:642-646 > now we have two sections which will reload KWin's config. Can we merge that? > A reload of KWin's config can be really expensive and we don't want to do > that twice. maybe an even compression with a timer? REP

[Differential] [Closed] D3852: import/export panel visibility with js

This revision was automatically updated to reflect the committed changes. Closed by commit R120:28f30459dca1: import/export panel visibility with js (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3852?vs=9448&id=9450 REVISION DETA

[Differential] [Updated] D3852: import/export panel visibility with js

mart updated the summary for this revision. REPOSITORY R120 Plasma Workspace BRANCH phab/exportPanVisibility REVISION DETAIL https://phabricator.kde.org/D3852 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: davidedmun

[Differential] [Accepted] D3838: [Calendar] Optimize day delegate

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3838 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasm

plasma-devel@kde.org

mart updated this revision to Diff 9449. mart added a comment. - export servicetypes REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3833?vs=9439&id=9449 BRANCH phab/kwintheme REVISION DETAIL https://phabricator.kde.org/D3833 AFFECTED FILES looka

[Differential] [Request, 16 lines] D3852: import/export panel visibility with js

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Both when exporting and importing plasma layout to json consider the panel cisibility as well together the other

[Differential] [Closed] D3822: use a native event filter to notice the screen was swapped

This revision was automatically updated to reflect the committed changes. Closed by commit R120:668aba4dfa27: use a native event filter to notice the screen was swapped (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3822?vs=9409&id

[Differential] [Commented On] D3822: use a native event filter to notice the screen was swapped

mart added a comment. so, landing in both master and 5.8 REPOSITORY R120 Plasma Workspace BRANCH phab/nativeeventfilt REVISION DETAIL https://phabricator.kde.org/D3822 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, sebas, davidedmundson, #p

plasma-devel@kde.org

mart updated this revision to Diff 9442. mart added a comment. - drop window button order REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3832?vs=9413&id=9442 BRANCH phab/kwinlnf REVISION DETAIL https://phabricator.kde.org/D3832 AFFECTED FILES

plasma-devel@kde.org

mart updated this revision to Diff 9439. mart added a comment. - drop buttons order REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3833?vs=9414&id=9439 BRANCH phab/kwintheme REVISION DETAIL https://phabricator.kde.org/D3833 AFFECTED FILES lookan

[Differential] [Commented On] D3822: use a native event filter to notice the screen was swapped

mart added inline comments. INLINE COMMENTS > pmuralidharan wrote in screenpool.cpp:203 > Wondering whether returning false always is correct. It feels wrong but I may > be missing something. always returning false means you don't want to ever block such events from further management, which i

plasma-devel@kde.org

mart added a comment. In https://phabricator.kde.org/D3832#71855, @graesslin wrote: > I don't think the buttons should be set by a lnf package. the user request was to make possible the l&f themes to emulate a different os (that is actually part of the design reason of l&f themes)

plasma-devel@kde.org

mart added inline comments. INLINE COMMENTS > graesslin wrote in lnflogic.cpp:163 > like in the other request I don't like this being exported. would empty string make it use the default? REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D3833 EMAIL PREFERENCES http

[Differential] [Accepted] D3834: [Panel Containment] Replace restore order logic by "algorithms"

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3834 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Accepted] D3839: Avoid using deprecated Qt code QAbstractItemModel::reset

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks BRANCH master REVISION DETAIL https://phabricator.kde.org/D3839 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To

[Differential] [Accepted] D3835: [Calendar] Populate overview models on-demand

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3835 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasm

plasma-devel@kde.org

mart updated the summary for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3832 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,

plasma-devel@kde.org

mart added a dependency: D3832: import kwin deco and button order in l&f. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D3833 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed

plasma-devel@kde.org

mart added a dependent revision: D3833: export kwin theme to l&f. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3832 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, je

plasma-devel@kde.org

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY export also kwin theme to look and feel themes including the button order tabbox and desktoip switcher are fixe

plasma-devel@kde.org

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY support both button order and decoration theme of kwin when applying for a lnf theme. The deco theme is compose

[Differential] [Accepted] D3828: [Plasma ScrollViewStyle] Show scroll bar background only on hover

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3828 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasm

[Differential] [Accepted] D3823: [Lock Screen] Use QtRendering for Clock

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. I think it's correct. anyways, you don't need hinting when the font is so huge REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3

[Differential] [Updated, 89 lines] D3822: use a native event filter to notice the screen was swapped

mart updated this revision to Diff 9409. mart added a comment. - move in screenpool REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3822?vs=9385&id=9409 BRANCH phab/nativeeventfilt REVISION DETAIL https://phabricator.kde.org/D3822 AFFECTED FI

[Differential] [Commented On] D3822: use a native event filter to notice the screen was swapped

mart added a comment. In https://phabricator.kde.org/D3822#71673, @davidedmundson wrote: > Given the only member variable we use is m_screenPool-> shouldn't this just be in ScreenPool? > > Also I don't understand how this is works: > > qxcbconnection::handleXcbEvent > > calls

[Differential] [Commented On] D3805: Per-activity favorites (WIP)

mart added inline comments. INLINE COMMENTS > kastatsfavoritesmodel.h:45 > + > +Q_PROPERTY(bool enabled READ enabled WRITE setEnabled NOTIFY > enabledChanged) > +Q_PROPERTY(QStringList favorites READ favorites WRITE setFavorites > NOTIFY favoritesChanged) just a line of comments for ea

[Differential] [Accepted] D3818: [KUIserver] Forward "destUrl" to all clients

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3818 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

[Differential] [Accepted] D3819: [Applicationjobs Data Engine] Expose job "destUrl"

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3819 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

[Differential] [Accepted] D3821: Add a manual test for unity launchers

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D3821 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Updated] D3822: use a native event filter to notice the screen was swapped

mart added reviewers: davidedmundson, sebas. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3822 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, davidedmundson, sebas Cc: plasma-devel, lesliezhai, ali-mohamed

[Differential] [Updated] D3822: use a native event filter to notice the screen was swapped

mart updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3822 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abet

[Differential] [Request, 77 lines] D3822: use a native event filter to notice the screen was swapped

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY this replaces the approach with the expose event in https://phabricator.kde.org/R120:20b439a4f4a1aa652f7960f0e6df

[Differential] [Commented On] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

mart added a comment. +1 from me but i feel that moving it to a submenu kinda misses the point to make the places immediately accessible REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3815 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emai

[Differential] [Accepted] D3816: [Task Manager] Parent QAction to "parent" instead of this

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3816 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Accepted] D3812: Deprecate Plasma::Package API in PluginLoader

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks BRANCH deprecate-package-in-pluginloader REVISION DETAIL https://phabricator.kde.org/D3812 EMAIL PREFERENCES https://phabricator.kde.org/settings/

[Differential] [Closed] D3777: notice when the only screen changes

This revision was automatically updated to reflect the committed changes. Closed by commit R120:20b439a4f4a1: notice when the only screen changes (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3777?vs=9355&id=9357 REVISION DETAIL

[Differential] [Closed] D3777: notice when the only screen changes

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f7b170de9fd9: notice when the only screen changes (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3777?vs=9355&id=9357 REVISION DETAIL

[Differential] [Updated, 35 lines] D3777: notice when the only screen changes

mart updated this revision to Diff 9355. mart added a comment. - Revert "e a native event filter over XCB_RANDR_NOTIFY" REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3777?vs=9352&id=9355 BRANCH arcpatch-D3777 REVISION DETAIL https://phabrica

[Differential] [Commented On] D3777: notice when the only screen changes

mart added a comment. In https://phabricator.kde.org/D3777#71267, @mart wrote: > yep, you are right, at the beginning i tought this was a qscreen problen on top of the xcb qpa, but it turns out is x11 specific, so the nativeeventfilter is more correct there seems to be no XCB_RAN

[Differential] [Commented On] D3777: notice when the only screen changes

mart added a comment. In https://phabricator.kde.org/D3777#71262, @davidedmundson wrote: > > so, is this workaround ok with a message to remove when/if we depend from a qt with a proper solution to https://bugreports.qt.io/browse/QTBUG-57785 ? > > Based on this I still don't really ge

[Differential] [Commented On] D3777: notice when the only screen changes

mart added a comment. this is an attempt so use the native event filter approach (can't test yet, as i'm away and don't have an external screen handy) will proper test tomorrow (too bad it's getting really tight for release:/) REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D3777

[Differential] [Updated, 46 lines] D3777: notice when the only screen changes

mart updated this revision to Diff 9352. mart added a comment. - use a native event filter over XCB_RANDR_NOTIFY REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3777?vs=9327&id=9352 BRANCH arcpatch-D3777 REVISION DETAIL https://phabricator.kde

[Differential] [Commented On] D3777: notice when the only screen changes

mart added a comment. so, is this workaround ok with a message to remove when/if we depend from a qt with a proper solution to https://bugreports.qt.io/browse/QTBUG-57785 ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3777 EMAIL PREFERENCES https://ph

  1   2   3   4   5   6   7   8   9   10   >