[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

oliverhenshaw added a comment. Surely the ideal world is one where the movie player realises the screen is locked and makes the decision to pause by itself? Media controls might still be a better option for audio players, but I wonder whether volume controls are better than that?

[Differential] [Closed] D2934: Explain re-triggering lid close on profile change

This revision was automatically updated to reflect the committed changes. Closed by commit rPOWERDEVILaa7c7560c213: Explain re-triggering lid close on profile change (authored by oliverhenshaw). REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2935: Improve ksmserver debug output

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE1531c7688315: Improve ksmserver debug output (authored by oliverhenshaw). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Updated, 66 lines] D2935: Improve ksmserver debug output

oliverhenshaw updated this revision to Diff 7093. oliverhenshaw added a comment. Add patch 3 - Use QLoggingCategory in ksmserver-logout-greeter REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2935?vs=7092=7093 BRANCH

[Differential] [Updated, 58 lines] D2935: Improve ksmserver debug output

oliverhenshaw updated this revision to Diff 7092. oliverhenshaw added a comment. Add patch 2 - Use QLoggingCategory more in ksmerver REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2935?vs=7090=7092 BRANCH phab/better-logging

[Differential] [Request, 2 lines] D2935: Improve ksmserver debug output

oliverhenshaw created this revision. oliverhenshaw set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Correct misleading debug output. Make all

[Differential] [Updated] D2934: Explain re-triggering lid close on profile change

oliverhenshaw added a reviewer: Plasma. REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D2934 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: oliverhenshaw, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Request, 2 lines] D2934: Explain re-triggering lid close on profile change

oliverhenshaw created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This code was added for https://bugs.kde.org/show_bug.cgi?id=243618 but the frameworks repo splitting makes the history hard to reach

[Differential] [Commented On] D2033: Clear idle timeouts when session becomes inactive

oliverhenshaw added a comment. In https://phabricator.kde.org/D2033#50969, @broulik wrote: > So, should we go with this patch then? Powerdevil is now a separate binary, so > > IdleTime::instance()->removeAllIdleTimeouts(); > > shouldn't cause side-effects on other modules and

[Differential] [Commented On] D2033: Clear idle timeouts when session becomes inactive

oliverhenshaw added a comment. In https://phabricator.kde.org/D2033#44650, @broulik wrote: > So, what should we do with this? Since we now have powerdevil as a separate binary we could savely do > > KIdleTime::instance()->removeAllIdleTimeouts(); > > without jeopardizing other

[Differential] [Request, 4 lines] D2393: Don't check current active session at all

oliverhenshaw created this revision. oliverhenshaw added reviewers: Plasma, broulik. oliverhenshaw added a subscriber: plasma-devel. oliverhenshaw set the repository for this revision to rPOWERDEVIL Powerdevil. oliverhenshaw added a project: Plasma. REVISION SUMMARY Simply use cached value so

[Differential] [Reopened] D2325: Don't unconditionally emit buttonPressed on profile load

oliverhenshaw reopened this revision. oliverhenshaw added a comment. This revision is now accepted and ready to land. > I can't find any evidence about the reason this was put in there in the first place. 'git blame' [1] shows that this was added for

[Differential] [Requested Changes To] D2033: Clear idle timeouts when session becomes inactive

oliverhenshaw requested changes to this revision. oliverhenshaw added a reviewer: oliverhenshaw. oliverhenshaw added a comment. This revision now requires changes to proceed. I may not have much pull, but I'd rather these changes were revised again before being landed. Sorry! Note that

[Differential] [Commented On] D2033: Clear idle timeouts when session becomes inactive

oliverhenshaw added inline comments. INLINE COMMENTS > powerdevilcore.cpp:151 > +// to an idle session by removing all idle timeouts > +KIdleTime::instance()->removeAllIdleTimeouts(); > +m_registeredActionTimeouts.clear(); Like you said, other kidletime users

[Differential] [Commented On] D2033: Ignore idle timeout when session isn't active

oliverhenshaw added a comment. Cancelling all timeouts set by powerdevil when the session becomes inactive is probably the right thing to do here. Also, by my reading, QList::erase(iterator pos) is a safe way to delete iterator elements. But I could be wrong. REPOSITORY rPOWERDEVIL