broulik accepted this revision.
broulik added a reviewer: broulik.
broulik added a comment.
This revision is now accepted and ready to land.
I just noticed I had an uncommited change which tried to solve the same thing:
- width: units.iconSizes.smallMedium
- height: width
+ Layout.preferredWidth: units.iconSizes.smallMedium
+ Layout.fillHeight: true
But yours is clearly better.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
BRANCH
pager
REVISION DETAIL
https://phabricator.kde.org/D1952
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, jensreuterberg, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
