mart added inline comments. INLINE COMMENTS
> panelview.cpp:1096 > > +void PanelView::writeScaledConfigEntry(const char *name, int pixelSize) > +{ why adding a new setter and getter that work in pixels? if something like that should be added, i wuld like just working with grid units. perhaps having the old thickness/setThickness etc that still accept sizes in pixels for compatibility and have new setUnitsThickness or whatever that accepts units? > panelview.cpp:1098 > +{ > + config().writeEntry(name, pixelSize / m_theme.mSize().width()); > +} in the scripting the m height is binded, not the width REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1986 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: mart, plasma-devel, jensreuterberg, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel