mart added inline comments. INLINE COMMENTS
> image.cpp:186 > > - //qDebug() << "wanted" << m_targetSize << "options" << images; > - > - // choose the nearest resolution, always preferring images with the same > aspect ratio > + //float targetAspectRatio = (m_targetSize.height() > 0 ) ? > m_targetSize.width() / (float)m_targetSize.height() : 0; > + //qDebug() << "wanted" << m_targetSize << "options" << images << "aspect > ratio" << targetAspectRatio; remove dead code > image.cpp:196 > } > - float candidateAspectRatio = > candidate.width()/(float)candidate.height(); > + //float candidateAspectRatio = (candidate.height() > 0 ) ? > candidate.width() / (float)candidate.height() : FLT_MAX; > dead code > testfindpreferredimage.cpp:90 > + total++; > + if (preferred != expected) failed++; > + std::cout << "For a screen size of " << > qPrintable(formatResolution(resolution)) good that a test has been added! but instead of doing all of this manually, couldn't it use qt autotest stuff, qcompare, qtest etc? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3188 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #plasma Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
