bdhruve added a comment.
Thank you @graesslin and @bshah
REPOSITORY
rKWAYLAND KWayland
BRANCH
fake-input-touch
REVISION DETAIL
https://phabricator.kde.org/D1672
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bdhruve, Plasma, bshah, graesslin
Cc:
bdhruve added a comment.
In https://phabricator.kde.org/D1672#31870, @bshah wrote:
> Looks good.
Output of arc land fake-input-touch:
TARGET Landing onto "master", the default target under git.
REMOTE Using remote "origin", the default remote under git.
FETCH Fetching o
graesslin added a comment.
> On server side FakeInputInterface, FakeInputDevice or client side in
FakeInput?
Needs to be done on server side. The thought is that the Client might send
incorrect data (the interface is the protocol, not your client code), so the
server needs to do input v
bdhruve added a comment.
In https://phabricator.kde.org/D1672#31141, @graesslin wrote:
> In https://phabricator.kde.org/D1672#31140, @bdhruve wrote:
>
> > In https://phabricator.kde.org/D1672#31046, @graesslin wrote:
> >
> > > I'm wondering: should we ensure that the ids are correc
graesslin added a comment.
In https://phabricator.kde.org/D1672#31140, @bdhruve wrote:
> In https://phabricator.kde.org/D1672#31046, @graesslin wrote:
>
> > I'm wondering: should we ensure that the ids are correct. E.g. a touchUp
for id 1 doesn't make sense if we never got a touchDown
bdhruve added a comment.
In https://phabricator.kde.org/D1672#31046, @graesslin wrote:
> I'm wondering: should we ensure that the ids are correct. E.g. a touchUp
for id 1 doesn't make sense if we never got a touchDown for id 1. This would
require tracking the used ids in FakeInputInterfa
graesslin added a comment.
In https://phabricator.kde.org/D1672#31094, @bshah wrote:
> In https://phabricator.kde.org/D1672#31046, @graesslin wrote:
>
> > I'm wondering: should we ensure that the ids are correct. E.g. a touchUp
for id 1 doesn't make sense if we never got a touchDown f
bshah added a comment.
In https://phabricator.kde.org/D1672#31046, @graesslin wrote:
> I'm wondering: should we ensure that the ids are correct. E.g. a touchUp
for id 1 doesn't make sense if we never got a touchDown for id 1. This would
require tracking the used ids in FakeInputInterface
graesslin added a comment.
I'm wondering: should we ensure that the ids are correct. E.g. a touchUp for
id 1 doesn't make sense if we never got a touchDown for id 1. This would
require tracking the used ids in FakeInputInterface. But it must be done
somewhere - either in the library or by th
