[Differential] [Commented On] D1784: Ensure that WaylandServer::shellClientAdded only gets emitted once

2016-06-07 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > sebas wrote in shell_client_test.cpp:129 > aren't you going overboard here? I don't think this makes the backtrace a lot > easier to read... backtraces here? This is an autotest. If that code crashes at that place we have a bigger problem than

[Differential] [Commented On] D1784: Ensure that WaylandServer::shellClientAdded only gets emitted once

2016-06-07 Thread Sebastian Kügler
sebas added a comment. a few questions and suggestions, feedback welcome... INLINE COMMENTS > shell_client_test.cpp:129 > +{ > +#define CLEANUP(name) \ > +if (name) { \ aren't you going overboard here? I don't think this makes the backtrace a lot easier to read... > shell_client_test.c