elvisangelaccio added inline comments.
INLINE COMMENTS
> dfaure wrote in kdeplatformfiledialoghelper.cpp:78
> Can you explain and document here what this function does, i.e. input args
> and return value? It's a bit confusing.
>
> "kde" is a mimetype name, e.g. application/zip right?
> "list"
dfaure added inline comments.
INLINE COMMENTS
> kdeplatformfiledialoghelper.cpp:78
> /*
> * Map a KDE filter string into a Qt one.
> */
Can you explain and document here what this function does, i.e. input args and
return value? It's a bit confusing.
"kde" is a mimetype name, e.g.
graesslin added a comment.
Looks good to me. You expanded the manual test, would it be possible to also
expand the autotest?
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D1813
EMAIL PREFERENCES
elvisangelaccio added a comment.
Ping?
I've been testing `QFileDialog` on Gnome shell and this issue cannot be
reproduced there. So we should definitely fix in Plasma.
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
REVISION DETAIL
elvisangelaccio added a comment.
Ping?
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D1813
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio, #plasma
Cc: mart,
elvisangelaccio added a comment.
In https://phabricator.kde.org/D1813#33780, @elvisangelaccio wrote:
> kde2QtFilter() is now more readable and we loop over the filter list only
once.
Ping?
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
REVISION DETAIL
elvisangelaccio added a comment.
In https://phabricator.kde.org/D1813#33652, @mart wrote:
> shouldn't be kde2QtFilter() fixed instead?
I guess I can try, but I'm not sure what exactly the function does...
Btw this is the commit where it was introduced:
mart added a comment.
shouldn't be kde2QtFilter() fixed instead?
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D1813
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: