broulik added a comment.
> The powerdevil binary does drawing for the fadeout effect, right?
It just sets an X property on the root window and KWin does the fading.
REPOSITORY
rPOWERDEVIL Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D2033
EMAIL PREFERENCES
oliverhenshaw added a comment.
In https://phabricator.kde.org/D2033#50969, @broulik wrote:
> So, should we go with this patch then? Powerdevil is now a separate binary,
so
>
> IdleTime::instance()->removeAllIdleTimeouts();
>
> shouldn't cause side-effects on other modules and
graesslin added a comment.
+1
REPOSITORY
rPOWERDEVIL Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D2033
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, oliverhenshaw, sebas, #plasma
Cc: sebas, oliverhenshaw, graesslin,
broulik added a comment.
So, should we go with this patch then? Powerdevil is now a separate binary, so
IdleTime::instance()->removeAllIdleTimeouts();
shouldn't cause side-effects on other modules and also should fix it for
non-weird X setups like mine. ;)
REPOSITORY
oliverhenshaw added a comment.
In https://phabricator.kde.org/D2033#44650, @broulik wrote:
> So, what should we do with this? Since we now have powerdevil as a separate
binary we could savely do
>
> KIdleTime::instance()->removeAllIdleTimeouts();
>
> without jeopardizing other
broulik added a comment.
So, what should we do with this? Since we now have powerdevil as a separate
binary we could savely do
KIdleTime::instance()->removeAllIdleTimeouts();
without jeopardizing other kded modules.
REPOSITORY
rPOWERDEVIL Powerdevil
REVISION DETAIL
broulik added a comment.
Don't worry, Oliver, I actually wasn't going to push this before I had
further feedback from you. :)
I'll address the clear all idle timeouts call (oh, how I wish I had already
done the powerdevil-as-separate-binary thing) and then should be good to go,
minus
oliverhenshaw added inline comments.
INLINE COMMENTS
> powerdevilcore.cpp:151
> +// to an idle session by removing all idle timeouts
> +KIdleTime::instance()->removeAllIdleTimeouts();
> +m_registeredActionTimeouts.clear();
Like you said, other kidletime users
