[Differential] [Commented On] D3006: fix screenForContainment when screen ids > count

2016-10-10 Thread mart (Marco Martin)
mart added a comment. this version has the old logic again, it iterates trough all the screens but doesn't check for ids being < of the count, it just checks that thre is a qscreen for that screen id by using the association in screenpool REPOSITORY rPLASMAWORKSPACE Plasma Workspace

[Differential] [Commented On] D3006: fix screenForContainment when screen ids > count

2016-10-10 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D3006#55743, @davidedmundson wrote: > I can see how this is a bug that needs fixing for the a screen ID > screenCount but what about the case where the screenID isn't valid anymore? > > i.e > a panel was on screen 2 you shutdown

[Differential] [Commented On] D3006: fix screenForContainment when screen ids > count

2016-10-10 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. I can see how this is a bug that needs fixing for the a screen ID > screenCount but what about the case where the screenID isn't valid anymore? i.e a panel was on screen 2 you shutdown (assuming ID's are also 1 and 2 respectively) when you boot up you