[Differential] [Commented On] D3166: make sure containment actions config is up to date

mart added a comment. In https://phabricator.kde.org/D3166#59071, @davidedmundson wrote: > It's still a bodge round broken user code. it is, but the thing is, that's the way is supported by the api right now, and there are users for it, so it has to work, regardless if it's quite

[Differential] [Commented On] D3166: make sure containment actions config is up to date

davidedmundson added a comment. It's still a bodge round broken user code. ConfigGroup.write() can't be expected to update anything on the fly, that's not how config works, and it's not how any of the rest of the scripting works. Config API even allows you to open a different file that

[Differential] [Commented On] D3166: make sure containment actions config is up to date

mart added a comment. in this version, i'm rebuilding everything on scriptengine teardown, this should make work correctly even if one adds a new plugin, or removes one. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3166 EMAIL PREFERENCES

[Differential] [Commented On] D3166: make sure containment actions config is up to date

mart added a comment. In https://phabricator.kde.org/D3166#58841, @davidedmundson wrote: > Also this script is making an optimistic assumption that in the script where you might be modding containment configs, you'd create a containment instance. That's not always true (like from the

[Differential] [Commented On] D3166: make sure containment actions config is up to date

davidedmundson added a comment. > If the containment actions plugins have been configured in the startup script, their config must be reloaded when the script ends, That part makes sensebut why is this code in the containment destructor? REPOSITORY rPLASMAWORKSPACE Plasma