[Differential] [Commented On] D3191: guard against dataengine missing

2016-10-31 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. So then checking isValid() is useless. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3191 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: davidedmundson, plasm

[Differential] [Commented On] D3191: guard against dataengine missing

2016-10-31 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D3191#59338, @davidedmundson wrote: > So why is PluginLoader::loadDataEngine returning something? from https://bugs.kde.org/show_bug.cgi?id=371779 it looks like it's not? REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DET

[Differential] [Commented On] D3191: guard against dataengine missing

2016-10-28 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. So why is PluginLoader::loadDataEngine returning something? REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3191 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: