[Differential] [Commented On] D3598: rework kscreen's OSD logic

2016-12-12 Thread Sebastian Kügler
sebas added a comment. Correct, that's the idea. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D3598 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc: mart, graesslin, broulik, plasma-devel, davidedmundson,

[Differential] [Commented On] D3598: rework kscreen's OSD logic

2016-12-12 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D3598#67455, @sebas wrote: > protocol), we'll move this code into its own daemon and kwin will authorize that daemon. THat's basically the same approach we'll have to take with powerdevil. so in the end the authorized process

[Differential] [Commented On] D3598: rework kscreen's OSD logic

2016-12-12 Thread broulik (Kai Uwe Broulik)
broulik added a comment. A bunch of nitpicks below. Haven't tried it yet, though :) Is there a chance we could serve the novice user usecase of Meta+P and then *click* / choose the desired setup? As far as I can tell we only show "You now use $setup" but not "You can choose: [Clone,

[Differential] [Commented On] D3598: rework kscreen's OSD logic

2016-12-06 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. It has the future wayland problem that MG wants to limit which applications can access which interfaces; you're implicitly using a plasma specific one in Dialog to position the window, which would make kded need to be a "trusted application" So whatever

[Differential] [Commented On] D3598: rework kscreen's OSD logic

2016-12-05 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > broulik wrote in osd.cpp:120 > Compare with QL1S - in case you have KWindowSystem you can ask it We only have KWindowSystem implicitly, I'm going with the QGuiApplication::platformName() comparison (changed to QL1S). > broulik wrote in