sebas added a comment.
Clarified your questions.
My remaining comments are all non-critical so as long as you consider them,
it's up to you if you change things or not. Just wanted to make sure it's not
an oversight there.
INLINE COMMENTS
> ExclGroupBox.qml:53
> +id
subdiff added inline comments.
INLINE COMMENTS
> sebas wrote in kwinwaylandtouchpad.h:36
> I wonder if it wouldn't be neater if the features would be an enum, and you'd
> have methods to check for supported and enabled features. Have you thought of
> this?
Haven't thought about it. The structu
graesslin added inline comments.
INLINE COMMENTS
> subdiff wrote in kwinwaylandbackend.cpp:84
> Are you sure? The foreach keyword is still listed in the official Qt docu.
> What's the best alternative? A normal for-loop? With upcounting integer or
> iterator?
https://www.kdab.com/goodbye-q_for
subdiff added inline comments.
INLINE COMMENTS
> knambiar wrote in kwinwaylandbackend.cpp:72
> Just wondering whether these calls are synchronous and may cause delay in
> startup.
> Just wondering whether these calls are synchronous and may cause delay in
> startup.
I assume so. Should be no
knambiar added a comment.
A query about the dbus calls in findTouchpads().
INLINE COMMENTS
> kwinwaylandbackend.cpp:72
> +QStringList devicesSysNames;
> +QVariant reply = m_deviceManager->property("devicesSysNames");
> +if (reply.isValid()) {
Just wondering whether these calls ar
