[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

2016-12-14 Thread broulik (Kai Uwe Broulik)
broulik added a comment. > use apparmor at some future point and from what I understand DBus access can be restricted on a per-interface/service basis with that? Dunno if it can do wildcards, though. > Kai, can you expand on your use cases At Randa I was listening to music, then

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

2016-12-14 Thread Martin Gräßlin
graesslin added a comment. > Having the movie contiue before you've logged back in is a state I've been in. Arguable that could also be handled by the media players by doing a temp inhibit to pause the movie. But yes that makes sense, but maybe more in powermanagement than in lock scree

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

2016-12-14 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. > But for the sake of argument let's assume the usecase is valid. No assumption is needed, it *is* valid. Assuming you have lock on suspend, which is the default: Case 1: You run out of power. Case 2: You close the lid Having the movie co

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

2016-12-14 Thread Martin Gräßlin
graesslin added a comment. > So, about proper media controls, would re-using the mpris data engine in Plasma from QML be an option or should it rather be some implementation in ksldapp given you wanted to disable dbus access for the locker? reusing the existing engine is fine. For disabl

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

2016-12-14 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D3674#68838, @davidedmundson wrote: > > The feature like that doesn't make sense IMHO. > > Why? > > Media controls doesn't help with this usecase. You come back, you press resume, your movie resumes...whilst your screen is

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

2016-12-14 Thread oliverhenshaw (Oliver Henshaw)
oliverhenshaw added a comment. Surely the ideal world is one where the movie player realises the screen is locked and makes the decision to pause by itself? Media controls might still be a better option for audio players, but I wonder whether volume controls are better than that? REPOSITORY

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

2016-12-14 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. > The feature like that doesn't make sense IMHO. Why? Media controls doesn't help with this usecase. You come back, you press resume, your movie resumes...whilst your screen is still locked. And if you unlock first..then you don't have the controls v

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

2016-12-14 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. Seems sensible. +1 As it's an RFC, it's a shame we have so much duplicated code for media player management; but I don't think there's any existing simple way round that. Any thoughts on how we collectively can fix that? REPOSITORY R133 KScreenLocker

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

2016-12-14 Thread mart (Marco Martin)
mart added a comment. I would rather have media controls in the greeter. I don't like yet another option that does something rather weird :/ REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D3674 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/em