[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

hein added a comment. Thanks! Sorry for straight committing, I was getting a bit grumpy ;) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, jensreuterberg,

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

broulik added a comment. I think I can live with that. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, jensreuterberg, apol Cc: subdiff, mart, hein, broul

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

broulik added a comment. With this patch the icon is actually *bigger* now than it was before. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, jensreuterb

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

hein added a comment. After living it for a while I now agree that the indicators are too large, so I'd prefer this to go into 5.9. I'm worried about the 0.7 magic number though. What does the systray do? The tray icons are much smaller than the audio indicators on my panel, and feel li

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

apol added a comment. In https://phabricator.kde.org/D4090#76737, @mart wrote: > so, let's keep 5.9 as is, and get sizing tought better for 5.10 So should I push to master? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES h

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

mart added a comment. so, let's keep 5.9 as is, and get sizing tought better for 5.10 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, jensreuterberg Cc: s

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

subdiff added a comment. Log or squareroot? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, jensreuterberg Cc: subdiff, mart, hein, broulik, plasma-devel,

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

broulik added a comment. > if iconsizes.small is non visible on a particular device, then it's a problem of units scaling on dpi, not a taskbar problem It's also super tiny on my non high dpi desktop F2008245: Screenshot_20170112_112623.png REPOS

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

mart added a comment. I prefer reducing the size, and the screenshots here look ok to me (even those brousgt as an example of "barely visible") if the icon never goes less than iconSizes.small, then semantically the size of the icon is always semantically correct (if iconsizes.small is no

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

hein added a comment. I'm against reducing opacity, using a fade-out for something that's "on" gets us into design trouble when we want to use fade out to say "off". I'm OK with reducing size a bit, but I also don't have a problem with the version on master personally. If we do resize size,

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

apol added a comment. In https://phabricator.kde.org/D4090#76560, @broulik wrote: > Just tried your patch, here it's so small I can hardly see it now. F2004967: Screenshot_20170111_201649.png Should I try a different multiplier? 0.8 instead o

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

broulik added a comment. What about reducing opacity to minimize the attention it draws? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, jensreuterberg Cc

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

broulik added a comment. Just tried your patch, here it's so small I can hardly see it now. F2004967: Screenshot_20170111_201649.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES https://phabri

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

apol added a comment. before F2004962: Spectacle.M31405.png after F2004958: Spectacle.Z31190.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES https://ph

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

broulik added a comment. +1 for the verticalCenter change nonetheless, though REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma Cc: broulik, plasma-devel, le

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

broulik added a comment. Can you make a screenshot? It's intentional, at least for regular task manager to be the same size. Icon tasks situation isn't ideal, though. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES https://phabricator