[Differential] [Commented On] D4366: WIP: Add screen recorder interface

2017-02-08 Thread Fredrik Höglund
fredrik added a comment. I know this revision has been abandoned, but I wanted to comment on a few things for future reference. INLINE COMMENTS > screencast.cpp:105 > + > +QRect geometry = effects->virtualScreenGeometry(); > + I strongly suggest that you use the damage information from

[Differential] [Commented On] D4366: WIP: Add screen recorder interface

2017-01-31 Thread Martin Gräßlin
graesslin added a comment. > Sharing a GBM won't work on all platforms Yes, it won't work on NVIDIA. Just like Wayland in general won't work on NVIDIA. For the nested platforms: fine with me, if recording doesn't work. Fbdev is probably something to consider dropping and hwcomposer is