graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY By default kcmshell5 registers as org.kde.kcmshell5, but such a desktop file does not exist. Which means that on Wayland neither window manager nor task manager is able to provide a useful window icon for configuration window. This change tries to locate the desktop file of the module passed to kcmshell5. If it is found it is set as the application's desktop file name. Thus the compositor and task manager actually know the desktop file which was used to start the kcmshell5 instance. This is only done if kcmshell5 is invoked for only one module. In case of multiple modules the application invoking kcmshell5 should pass a proper desktop file name through the command line argument. And if the desktopfile got specified already it is not updated from the module. TEST PLAN KWin Effects KCM shows proper icon on Wayland REPOSITORY rKDECLITOOLS KDE CLI Utilities BRANCH desktop-file-name REVISION DETAIL https://phabricator.kde.org/D3161 AFFECTED FILES kcmshell/main.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas