broulik created this revision. broulik added reviewers: Plasma, mck182. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY This ensures the dialog gets a proper position before being shown. On Wayland notification popups are animated by the morphing popup effect and would fly all over the screen when shown; now they only move around in the vicinity of their final position, looking really nice. TEST PLAN Only tested on Wayland. With all of X's quirks this overly complex code needs to be tested more. I removed the updateVisibility calls which I don't think are neccessary and it works just fine here but I don't trust X here. Will test on X soon. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3209 AFFECTED FILES applets/notifications/plugin/notificationshelper.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mck182 Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas