broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
broulik added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  The finished signal is not emitted when the dialog is just closed and neither 
is the reject signal.
  Since the dialog is DeleteOnClose we can just connect to QObject::destroyed

TEST PLAN
  I think there's a better solution but I finally found why I often ended up 
with a bunch of drkonqis still hanging around when I couldnt be bothered to 
actually finish filing a bug :)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1044

AFFECTED FILES
  drkonqi/drkonqidialog.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma
Cc: plasma-devel
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to