graesslin marked 3 inline comments as done.
REPOSITORY
rKSCREENLOCKER KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D827
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, bshah, Plasma, broulik
Cc: plasma-devel
broulik added a comment.
+1
INLINE COMMENTS
greeter/greeterapp.cpp:616 perhaps cache the end?
for (auto it = m_views.constBegin(), end = m_views.constEnd(); it != end;
++it)
powermanagement.cpp:110 I prefer returning a reference for singletons but I
guess this way is just consistent
graesslin added a reviewer: Plasma.
graesslin added a subscriber: plasma-devel.
graesslin added a project: Plasma.
REPOSITORY
rKSCREENLOCKER KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D827
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
