[PATCH] Multiscreen fix!

2009-01-30 Thread Alessandro Diaferia
As you can see from the sources Plasma::View uses QTimer::singleShot(0, this, SLOT(privateInit())) in the ctor but DesktopView calls adjustSize() in the ctor with no delay.. This causes the fact that adjustSize() uses invalid information about the current screen to setup its size and makes my secon

Re: [PATCH] Multiscreen fix!

2009-01-30 Thread Marco Martin
On Friday 30 January 2009, Alessandro Diaferia wrote: > As you can see from the sources Plasma::View uses > QTimer::singleShot(0, this, SLOT(privateInit())) in the ctor but > DesktopView calls adjustSize() in the ctor with no delay.. > This causes the fact that adjustSize() uses invalid information

Re: [PATCH] Multiscreen fix!

2009-01-31 Thread Aaron J. Seigo
On Friday 30 January 2009, Marco Martin wrote: > to me seems correct, it's a bit tricky the fact that privateinit was > enqueued before so by enqueuing adjustsize we are sure that it will be > executed after, but i don't see other ways to achieve that, so just put a > comment about that and i thi

Re: [PATCH] Multiscreen fix!

2009-01-31 Thread Alessandro Diaferia
2009/1/31 Aaron J. Seigo > On Friday 30 January 2009, Marco Martin wrote: > > to me seems correct, it's a bit tricky the fact that privateinit was > > enqueued before so by enqueuing adjustsize we are sure that it will be > > executed after, but i don't see other ways to achieve that, so just p

Re: [PATCH] Multiscreen fix!

2009-02-01 Thread Guillaume Pothier
2009/2/1 Alessandro Diaferia : > I deeply checked and Kephal actually returns correct screen info (2 > screens, > the first (0, 0, 1280, 1024), the second(1280, 0, 1680, 1050)). Moreover > adjustSize() uses Plasma::View::screen() > in order to resize the view, and before delaying adjustSize,

Re: [PATCH] Multiscreen fix!

2009-02-01 Thread Alessandro Diaferia
2009/2/1 Guillaume Pothier > 2009/2/1 Alessandro Diaferia : > > I deeply checked and Kephal actually returns correct screen info (2 > > screens, > > the first (0, 0, 1280, 1024), the second(1280, 0, 1680, 1050)). > Moreover > > adjustSize() uses Plasma::View::screen() > > in order to resize

Re: [PATCH] Multiscreen fix!

2009-02-01 Thread Alessandro Diaferia
2009/2/1 Guillaume Pothier > Hi Alessandro, sorry I didn't reply earlier, Hi Guillaume, np :) > I was offline this week. > I think your fix is not in the ideal place. I think that what happens > is that you are using a driver that is not xrandr1.2-aware (please > tell me if I'm wrong), ho

Re: [PATCH] Multiscreen fix!

2009-02-01 Thread Guillaume Pothier
Hi Alessandro, sorry I didn't reply earlier, I was offline this week. I think your fix is not in the ideal place. I think that what happens is that you are using a driver that is not xrandr1.2-aware (please tell me if I'm wrong), and therefore Kephal falls back to QDesktopWidget for screen manageme